Hi Baptiste,
I reviewed and mostly accepted your patch. The only thing I changed was
to keep the current behavior of spacecmd where "name" is a required
option and "label" (if not provided) is the same as name. Your change
would have made "name" optional and the new "label" required, and while
that makes perfect sense it also breaks backwards-compatibility and
would have annoyed users who use spacecmd in their scripts.
Committed to Spacewalk master as d182cc2601ba20a9ad2e6913821d00402da6c513.
Thanks for the patch!
-Stephen
On 04/16/2013 12:12 PM, Baptiste AGASSE wrote:
Hi,
Just a small patch to spacecmd to add "-l/--label" option to
configchannel_create command.
The current behavior of the command is to ask a "name" and set label and name to this value, but
"label" is more restrictive than "name" (for labels, only alphanumeric characters, '-',
'_', and '.' are allowed).
With this patch, the label must be provided, and name is set to label value if
name is not provided.
Have a nice day.
Regards.
---
Baptiste AGASSE
Lyra Network, Service Systèmes et Réseaux
Rue Carmin, BP 87350, 31673 Labège Cedex - France
Tél: (+33)5.67.22.31.87
Fax: (+33)5.67.22.31.61
Mail: baptiste.aga...@lyra-network.com
Site: http://www.lyra-network.com
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
_______________________________________________
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel
