[speedtouch] Re: dump code buggy (no bounds checks)

2003-09-30 Thread Edouard Gomez
Applied -- See commit email -- Edouard Gomez -- Attached file included as plaintext by Listar -- -- File: signature.asc -- Desc: Digital signature -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.3 (GNU/Linux) iD8DBQE/ef0+R5dTYz5sWMcRAi1CAJ9xb/u2wZ60f9AhDIPa4NHN7SX5NQCfQk8V

[speedtouch] Re: dump code buggy (no bounds checks)

2003-09-25 Thread Leonard den Ottolander
Hi, I wrote: It looks like the code for function dump is buggy. It does no bounds checks whatsoever on line and ptr. Setting verbosity of pppoa3 to 2 will cause pppoa3 to crash after a few minutes. But disabling the (only) call to dump seems to fix this problem. After closer

[speedtouch] Re: dump code buggy (no bounds checks)

2003-09-25 Thread Leonard den Ottolander
Hi, Since the attached patch was dropped here it is inlined. Sorry for possible line wraps (I set the margin to 100 chars for this). diff -pruN src.000/pppoa3.c src.000.verbosity/pppoa3.c --- src.000/pppoa3.c2003-06-28 00:03:28.0 +0200 +++ src.000.verbosity/pppoa3.c 2003-09-25