On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
Anyone up for writing some patches ? If not, I'll do it.
Go ahead.
Ok, will do. It isn't that
Dear Shawn Guo,
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
Anyone up for writing some patches ? If not, I'll do it.
Go ahead.
Ok,
Dear Marek Vasut,
[...]
-out_host_free:
+out_free_dma:
+ dma_release_channel(ssp-dmach);
clk_disable_unprepare(ssp-clk);
+out_host_free:
spi_master_put(host);
kfree(host);
+
Please remove this newline.
return ret;
}
Missing dma_release_channel() in
On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote:
On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck li...@roeck-us.net wrote:
On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
Dear Shawn Guo,
On Tue, Jul 31, 2012 at 08:35:59PM -0700, Guenter Roeck wrote:
I
Dear Guenter Roeck,
On Wed, Aug 01, 2012 at 02:28:40PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck wrote:
Anyone up for
Dear Guenter Roeck,
On Wed, Aug 01, 2012 at 11:16:15AM +0530, Shubhrajyoti Datta wrote:
On Wed, Aug 1, 2012 at 10:59 AM, Guenter Roeck li...@roeck-us.net wrote:
On Wed, Aug 01, 2012 at 07:00:54AM +0200, Marek Vasut wrote:
Dear Shawn Guo,
On Tue, Jul 31, 2012 at 08:35:59PM -0700,
Dear Guenter Roeck,
On Wed, Aug 01, 2012 at 08:10:37AM +0200, Marek Vasut wrote:
Dear Shawn Guo,
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 10:29:47PM -0700, Guenter Roeck
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
Dear Guenter Roeck,
On Wed, Aug 01, 2012 at 08:10:37AM +0200, Marek Vasut wrote:
Dear Shawn Guo,
On Tue, Jul 31, 2012 at 10:42:28PM -0700, Guenter Roeck wrote:
On Wed, Aug 01, 2012 at 01:58:56PM +0800, Shawn Guo
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
I must be missing something. Why do almost all spi drivers call it in the
error path, even if there is no call to spi_master_get ?
To push the refcounting to 0, to deallocate the device, I'd say ...
It's not going to work if
On Wed, Aug 01, 2012 at 03:40:53PM +0800, Shawn Guo wrote:
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
I must be missing something. Why do almost all spi drivers call it in the
error path, even if there is no call to spi_master_get ?
To push the refcounting to 0, to
On Tue, Jul 31, 2012 at 11:56:50PM -0700, Guenter Roeck wrote:
Guess we are in violent agreement. The sequence would then either be
master = spi_alloc_device();
The discussion is around spi_alloc_master rather than spi_alloc_device,
isn't it?
Regards,
Shawn
...
Shawn Guo writes:
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
I must be missing something. Why do almost all spi drivers call it in the
error path, even if there is no call to spi_master_get ?
To push the refcounting to 0, to deallocate the device, I'd say ...
On Wed, Aug 01, 2012 at 09:38:07AM +0200, Lothar Waßmann wrote:
Shawn Guo writes:
On Wed, Aug 01, 2012 at 08:45:19AM +0200, Marek Vasut wrote:
I must be missing something. Why do almost all spi drivers call it in
the
error path, even if there is no call to spi_master_get ?
The kfree() is taken care of by the spi core (spi_master_release() function)
that is called once the last reference to the underlying struct device has
been released. So the driver need not call kfree.
Also the put was missed in some of the error handling fix the same.
There by fixing the missing
On Wed, Aug 01, 2012 at 03:50:12PM +0800, Shawn Guo wrote:
On Tue, Jul 31, 2012 at 11:56:50PM -0700, Guenter Roeck wrote:
Guess we are in violent agreement. The sequence would then either be
master = spi_alloc_device();
The discussion is around spi_alloc_master rather than
On Wed, Aug 01, 2012 at 03:06:28PM +0530, Shubhrajyoti D wrote:
The kfree() is taken care of by the spi core (spi_master_release() function)
that is called once the last reference to the underlying struct device has
been released. So the driver need not call kfree.
Also the put was missed in
On Mon, Jul 23, 2012 at 10:40:48PM +0200, Marek Vasut wrote:
This is slightly reworked version of the SPI driver.
Support for DT has been added and it's been converted
to queued API.
Looks reasonable overall.
+ bits_per_word = dev-bits_per_word;
+ if (t t-bits_per_word)
+
On Mon, Jul 23, 2012 at 10:40:50PM +0200, Marek Vasut wrote:
+ /*
+ * Small blocks can be transfered via PIO.
+ * Measured by empiric means:
+ *
+ * dd if=/dev/mtdblock0 of=/dev/null bs=1024k count=1
+ *
+
Mark,
could you have another look at these patches maybe? They aren't urgent,
I just want to avoid the get lost.
Thanks for your time,
Daniel
On 25.07.2012 13:44, Daniel Mack wrote:
The spi-gpio driver currently assumes the chipselect gpio number is
stored in -controller_data of the device's
The spi-gpio driver currently assumes the chipselect gpio number is
stored in -controller_data of the device's static board information.
In devicetree environments, this information is unavailable and has to
be derived from the DT node.
This patch moves the gpio storage to the controller's
On 01.08.2012 22:51, Mark Brown wrote:
On Wed, Aug 01, 2012 at 10:45:19PM +0200, Daniel Mack wrote:
could you have another look at these patches maybe? They aren't urgent,
I just want to avoid the get lost.
Can you please resend them with me in the CCs? My process for handling
patches is
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML
Lien miroir :
http://m10-fr.com/mc10_m/YT0xMyZiPTE3MjYyJmM9NDgzNjEyJmQ9MjAxMi0wOC0wMiAwMDoyMDowMSZlPTEmaD0xNzI2MSZmPTE3MjYyJmc9MTcyNjI=
Lien de désinscription :
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML
Lien miroir :
http://m10-fr.com/mc10_m/YT0xMyZiPTE3MjYxJmM9NDgzNjEyJmQ9MjAxMi0wOC0wMiAwMDozMDowMSZlPTEmaD0xNzI2MCZmPTE3MjYxJmc9MTcyNjE=
Lien de désinscription :
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML
Lien miroir :
http://m10-fr.com/mc10_m/YT0xMyZiPTE3MjY1JmM9NDgzNjEyJmQ9MjAxMi0wOC0wMiAwMDozMDowMSZlPTEmaD0xNzI2NCZmPTE3MjY1Jmc9MTcyNjU=
Lien de désinscription :
Upon reviewing your account, we noticed that your website is not listed first
on Google, Yahoo, Bing or any other search engine.
This may be costing you sales and website traffic, so we wanted to bring this
to your attention.
Please give me a call at 1 (800) 455-8040 to discuss how we can get
25 matches
Mail list logo
