Re: [PATCH v2 6/6] of_spi: Initialize cs_gpios and cs_gpio with -EEXIST

On Tue, 29 Jan 2013 15:53:43 +0100, Andreas Larsson wrote: > Holes in the cs-gpios DT phandle list is supposed to mark that native > chipselects is to be used. The value returned from of_get_named_gpio_flags in > this case is -EEXIST. By initializing cs_gpios and cs_gpio with -EEXIST, this > and o

Re: [PATCH v2 5/6] of_spi: Add fetching of of_gpio flags to of_spi_register_master

On Tue, 29 Jan 2013 15:53:42 +0100, Andreas Larsson wrote: > When using a gpio chip select with a OF_GPIO_ACTIVE_LOW flag, this needs to be > known to the controller driver. > > Signed-off-by: Andreas Larsson Out of curiosity, what do you need the flags for? Polarity of the CS signal? I think i

Re: [PATCH v2 4/6] of_spi: Document cs_gpios and cs_gpio in kernel-doc

On Tue, 29 Jan 2013 15:53:41 +0100, Andreas Larsson wrote: > This adds missing kernel-doc entries for cs_gpios in struct spi_master and > cs_gpio in struct spi_device. > > Signed-off-by: Andreas Larsson Applied, thanks. I did tweak the language a bit. g. > --- > include/linux/spi/spi.h |

Re: [PATCH v2 3/6] of_spi: Initialize cs_gpios properly

On Tue, 29 Jan 2013 15:53:40 +0100, Andreas Larsson wrote: > Using memset does not set an array of integers properly > > Signed-off-by: Andreas Larsson Applied, thanks. g. > --- > drivers/spi/spi.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/s

Re: [PATCH v2 2/6] of: Return -ENXIO from of_parse_phandle_with_args for too large index and return errors from of_gpio_named_count

On Tue, 29 Jan 2013 15:53:39 +0100, Andreas Larsson wrote: > This lets of_gpio_named_count return an errno on errors by being able to > distinguish between reaching the end of the phandle list and getting some > other > error from of_parse_phandle_with_args. > > Return error from of_spi_register