RE: [PATCH 5/5] mmc: omap_hsmmc: Add reg-offset to bindings documentation

2013-06-25 Thread Hebbar, Gururaja
On Wed, Jun 26, 2013 at 06:55:01, Fernandes, Joel wrote: From: Joel A Fernandes agnel.j...@gmail.com A new reg-offset property was added to account for register offsets in some omap-hsmmc's. Document the new property. Small nitpick I usually get feedback that any driver DT changes and the

RE: [PATCH 05/11] spi: omap2-mcspi: enhance pinctrl support

2013-06-04 Thread Hebbar, Gururaja
On Sun, Jun 02, 2013 at 00:57:26, Mark Brown wrote: On Fri, May 31, 2013 at 03:43:05PM +0530, Hebbar Gururaja wrote: Amend the spi omap controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume and before performing an spi transfer

RE: [PATCH] spi/omap2: Let device core handle pinctrl

2013-05-13 Thread Hebbar, Gururaja
On Fri, May 10, 2013 at 15:26:29, Mark Brown wrote: On Tue, May 07, 2013 at 10:47:31AM +, Hebbar, Gururaja wrote: On Tue, May 07, 2013 at 14:25:35, Mark Brown wrote: There's also been some discussion about factoring out the suspend/resume code since it's going to get equally

RE: [PATCH] spi/omap2: Let device core handle pinctrl

2013-05-07 Thread Hebbar, Gururaja
On Tue, May 07, 2013 at 14:25:35, Mark Brown wrote: On Tue, May 07, 2013 at 03:56:09AM +, Hebbar, Gururaja wrote: There are cases where driver('s) needs to place pin-mux's to sleep on suspend default/idle on resume. For such cases Pinctrl needs to be handled inside the driver

RE: [PATCH] spi/omap2: Let device core handle pinctrl

2013-05-06 Thread Hebbar, Gururaja
On Tue, May 07, 2013 at 01:06:38, Mark Brown wrote: Since commit ab78029 (drivers/pinctrl: grab default handles from device core) we can rely on device core for handling pinctrl so remove devm_pinctrl_get_select_default() from the driver. NACK. There are cases where driver('s) needs to place

RE: [PATCH v4 01/14] ARM: davinci: move private EDMA API to arm/common

2013-01-10 Thread Hebbar, Gururaja
On Fri, Jan 11, 2013 at 11:18:37, Porter, Matt wrote: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx) as well. This just moves the private EDMA API and enables it to build on OMAP. Signed-off-by: Matt Porter mpor...@ti.com --- arch/arm/Kconfig

RE: [PATCH v4 05/14] dmaengine: edma: Add TI EDMA device tree binding

2013-01-10 Thread Hebbar, Gururaja
On Fri, Jan 11, 2013 at 11:18:41, Porter, Matt wrote: The binding definition is based on the generic DMA controller binding. Signed-off-by: Matt Porter mpor...@ti.com --- Documentation/devicetree/bindings/dma/ti-edma.txt | 51 + 1 file changed, 51 insertions(+)

RE: [RFC PATCH v3 13/16] ARM: dts: add AM33XX MMC support

2013-01-03 Thread Hebbar, Gururaja
Matt, On Thu, Oct 18, 2012 at 18:56:52, Porter, Matt wrote: Adds AM33XX MMC support for am335x-bone and am335x-evm. I want to test Suspend/Resume feature on omap hsmmc driver. Do you any tree based on mainline kernel v3.8-rc1 with these edma mmc patches. Signed-off-by: Matt Porter

RE: [RFC PATCH v3 00/16] DMA Engine support for AM33XX

2012-11-04 Thread Hebbar, Gururaja
On Thu, Oct 18, 2012 at 18:56:39, Porter, Matt wrote: ...snip... ...snip... ...snip... This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously supported by only a private API implementation (much like the situation with OMAP DMA) found on

RE: [RFC PATCH v3 05/16] ARM: edma: add AM33XX crossbar event support

2012-10-26 Thread Hebbar, Gururaja
On Thu, Oct 18, 2012 at 18:56:44, Porter, Matt wrote: Adds support for the per-EDMA channel event mux. This is required for any peripherals using DMA crossbar mapped events. Signed-off-by: Matt Porter mpor...@ti.com --- arch/arm/common/edma.c | 63

RE: [RFC PATCH v2 08/16] ARM: omap: add hsmmc am33xx specific init

2012-10-12 Thread Hebbar, Gururaja
Matt On Fri, Oct 12, 2012 at 00:34:33, Porter, Matt wrote: AM33xx requires special handling in hsmmc initialization platform glue. Since AM335x boots mainly through DT, do we still need this patch. This function will be called in case of initializing hsmmc with Platform data.

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-26 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 23:52:11, Porter, Matt wrote: On Fri, Sep 21, 2012 at 08:27:07AM +, Hebbar, Gururaja wrote: On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-24 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 23:52:11, Porter, Matt wrote: On Fri, Sep 21, 2012 at 08:27:07AM +, Hebbar, Gururaja wrote: On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:34, Porter, Matt wrote: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx atm) as well. This just moves the private EDMA API but does not support OMAP. Signed-off-by: Matt Porter mpor...@ti.com --- arch/arm/Kconfig

RE: [RFC PATCH 00/13] DMA Engine support for AM33xx

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:33, Porter, Matt wrote: This series adds DMA Engine support for AM33xx, which uses an EDMA DMAC. The EDMA DMAC has been previously supported by only a private API implementation (much like the situation with OMAP DMA) found on the DaVinci family of SoCs. There

RE: [RFC PATCH 05/13] dma: Add TI EDMA device tree binding

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:38, Porter, Matt wrote: The binding definition is based on the generic DMA controller binding. Signed-off-by: Matt Porter mpor...@ti.com --- Documentation/devicetree/bindings/dma/ti-edma.txt | 49 + 1 file changed, 49 insertions(+)

RE: [RFC PATCH 03/13] ARM: edma: add DT and runtime PM support for AM335x

2012-09-21 Thread Hebbar, Gururaja
On Thu, Sep 20, 2012 at 20:13:36, Porter, Matt wrote: Adds support for parsing the TI EDMA DT data into the required EDMA private API platform data. Calls runtime PM API only in the DT case in order to unidle the associated hwmods on AM335x. Signed-off-by: Matt Porter mpor...@ti.com ---

RE: [RFC PATCH 01/13] ARM: davinci: move private EDMA API to arm/common

2012-09-21 Thread Hebbar, Gururaja
On Fri, Sep 21, 2012 at 14:59:23, Russell King - ARM Linux wrote: On Thu, Sep 20, 2012 at 10:43:34AM -0400, Matt Porter wrote: Move mach-davinci/dma.c to common/edma.c so it can be used by OMAP (specifically AM33xx atm) as well. This just moves the private EDMA API but does not support