Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-20 Thread Linus Walleij
On Wed, Sep 19, 2012 at 5:31 AM, viresh kumar viresh.ku...@linaro.org wrote: On Tue, Sep 18, 2012 at 5:20 PM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar viresh.ku...@linaro.org wrote: The amba layer is taking care of interface clock only and

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-18 Thread Linus Walleij
On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar viresh.ku...@linaro.org wrote: Yes, we don't need to call prepare() again atleast for SPEAr. You are correct. I saw the driver after a long time :) I'm asking because it's actually OK to do this, I was more asking whether it was really needed by

[PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Vipul Kumar Samar
clk_{un}prepare is mandatory for platforms using common clock framework. Add clk_{un}prepare() support for spi-pl022 runtime PM. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com --- drivers/spi/spi-pl022.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread viresh kumar
On Mon, Sep 17, 2012 at 4:07 PM, Vipul Kumar Samar vipulkumar.sa...@st.com wrote: clk_{un}prepare is mandatory for platforms using common clock framework. Add clk_{un}prepare() support for spi-pl022 runtime PM. You are not calling these routines in actualy patch.. Fix commit log and add my

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Sergei Shtylyov
Hello. On 17-09-2012 14:37, Vipul Kumar Samar wrote: clk_{un}prepare is mandatory for platforms using common clock framework. Add clk_{un}prepare() support for spi-pl022 runtime PM. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com [...] @@ -2342,10 +2342,13 @@ static int

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Linus Walleij
On Mon, Sep 17, 2012 at 12:37 PM, Vipul Kumar Samar vipulkumar.sa...@st.com wrote: clk_{un}prepare is mandatory for platforms using common clock framework. Add clk_{un}prepare() support for spi-pl022 runtime PM. Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com This driver does

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread viresh kumar
On Mon, Sep 17, 2012 at 7:09 PM, Linus Walleij linus.wall...@linaro.org wrote: This driver does clk_prepare/unprepare at probe and removed, so I guess what you're trying to say is that on your platform the clk_unprepare() process context call is needed to save power? Please elaborate... Hi