Re: [PATCH 2/3] OMAP: SPI: call pm_runtime_disable in error path and remove

2011-10-30 Thread Shubhrajyoti
On Saturday 29 October 2011 05:36 PM, Grant Likely wrote: > On Fri, Oct 28, 2011 at 05:14:18PM +0530, Shubhrajyoti D wrote: >> omap mcspi probe() doesnt call pm_runtime disable functions >> in case of failure. remove() doesnt call pm_runtime disable. This could >> lead to warnings as below on subs

Re: [PATCH 2/3] OMAP: SPI: call pm_runtime_disable in error path and remove

2011-10-29 Thread Grant Likely
On Fri, Oct 28, 2011 at 05:14:18PM +0530, Shubhrajyoti D wrote: > omap mcspi probe() doesnt call pm_runtime disable functions > in case of failure. remove() doesnt call pm_runtime disable. This could > lead to warnings as below on subsequent insmod. > > ~# insmod spi-omap2-mcspi.ko > [ 255.38367

[PATCH 2/3] OMAP: SPI: call pm_runtime_disable in error path and remove

2011-10-28 Thread Shubhrajyoti D
omap mcspi probe() doesnt call pm_runtime disable functions in case of failure. remove() doesnt call pm_runtime disable. This could lead to warnings as below on subsequent insmod. ~# insmod spi-omap2-mcspi.ko [ 255.383671] omap2_mcspi omap2_mcspi.1: Unbalanced pm_runtime_enable! ... This patch