Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Grant Likely
On Tue, 17 Apr 2012 11:29:37 +0200, Linus Walleij wrote: > On Tue, Apr 17, 2012 at 9:10 AM, Vinit Shenoy wrote: > > > pl022 ssp controller supports word lengths from 4 to 16 (or 32) bits. > > Currently implemented checks were incorrect. It has following check > > > > if (pl022->vendor->max_bpw

Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Shubhrajyoti Datta
Hi Vinit, Looks OK to me , On Tue, Apr 17, 2012 at 12:40 PM, Vinit Shenoy wrote: > pl022 ssp controller supports word lengths from 4 to 16 (or 32) bits. > Currently implemented checks were incorrect. It has following check > > if (pl022->vendor->max_bpw >= 32) > > which must be checking for <=.

Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Linus Walleij
On Tue, Apr 17, 2012 at 9:10 AM, Vinit Shenoy wrote: > pl022 ssp controller supports word lengths from 4 to 16 (or 32) bits. > Currently implemented checks were incorrect. It has following check > > if (pl022->vendor->max_bpw >= 32) > > which must be checking for <=. > > Also error print message

[PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Vinit Shenoy
pl022 ssp controller supports word lengths from 4 to 16 (or 32) bits. Currently implemented checks were incorrect. It has following check if (pl022->vendor->max_bpw >= 32) which must be checking for <=. Also error print message is incorrect, that prints "range is from 1 to 16". Fix both these i