Re: [spi-devel-general] [patch 2.6.22-git5 2/4] MMC block learns about SPI

2007-07-26 Thread David Brownell
On Thursday 26 July 2007, Pierre Ossman wrote: > On Thu, 26 Jul 2007 10:00:16 -0700 > David Brownell <[EMAIL PROTECTED]> wrote: > > > > > But then it can't hurt either, and will be safer to cut'n'paste. :) > > > > Andrew Morton regularly gives feedback which amounts to "that's correct > > in th

Re: [spi-devel-general] [patch 2.6.22-git5 2/4] MMC block learns about SPI

2007-07-26 Thread Pierre Ossman
On Thu, 26 Jul 2007 10:00:16 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > > But then it can't hurt either, and will be safer to cut'n'paste. :) > > Andrew Morton regularly gives feedback which amounts to "that's correct > in this context, but please adopt this always-safe idiom" on the gro

Re: [spi-devel-general] [patch 2.6.22-git5 2/4] MMC block learns about SPI

2007-07-26 Thread David Brownell
On Thursday 26 July 2007, Pierre Ossman wrote: > On Sat, 14 Jul 2007 15:06:42 -0700 > David Brownell <[EMAIL PROTECTED]> wrote: > > > @@ -302,13 +309,14 @@ static int mmc_blk_issue_rq(struct mmc_q > > goto cmd_err; > > } > > > > - if (rq_data_dir(req) !=

Re: [spi-devel-general] [patch 2.6.22-git5 2/4] MMC block learns about SPI

2007-07-26 Thread Pierre Ossman
On Sat, 14 Jul 2007 15:06:42 -0700 David Brownell <[EMAIL PROTECTED]> wrote: > @@ -302,13 +309,14 @@ static int mmc_blk_issue_rq(struct mmc_q > goto cmd_err; > } > > - if (rq_data_dir(req) != READ) { > + if (!mmc_host_is_spi(card->host)