Re: [spi-devel-general] [PATCH v2 1/6] spi/mpc8xxx: refactor the common code for SPI/eSPI controller

2010-08-10 Thread Grant Likely
On Mon, Aug 2, 2010 at 1:51 AM, Mingkai Hu mingkai...@freescale.com wrote: Refactor the common code in file spi_mpc8xxx.c to spi_fsl_lib.c used by SPI/eSPI controller driver as a library, move the SPI controller driver to a new file spi_fsl_spi.c, and leave the QE/CPM SPI controller code in

Re: [spi-devel-general] [PATCH] spi: omap2_mcspi: make use of dev_vdbg()

2010-08-10 Thread Felipe Balbi
Hi, On Tue, Aug 10, 2010 at 08:33:41AM +0200, ext Grant Likely wrote: Now picked up into my test-spi branch. I'll add it to linux-next after the merge window closes. ok, thanks Grant -- balbi DefectiveByDesign.org

Re: [spi-devel-general] [PATCH v2 2/6] eSPI: add eSPI controller support

2010-08-10 Thread Grant Likely
On Mon, Aug 2, 2010 at 1:52 AM, Mingkai Hu mingkai...@freescale.com wrote: Add eSPI controller support based on the library code spi_fsl_lib.c. The eSPI controller is newer controller 85xx/Pxxx devices supported. There're some differences comparing to the SPI controller: 1. Has different

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Grant Likely
On Mon, Aug 2, 2010 at 1:52 AM, Mingkai Hu mingkai...@freescale.com wrote: Signed-off-by: Mingkai Hu mingkai...@freescale.com --- v2:  - Move the flash partition function from of_spi.c to MTD driver  drivers/mtd/devices/m25p80.c |   29 +  1 files changed, 29

Re: [spi-devel-general] [PATCH] spi: omap2_mcspi: make use of dev_vdbg()

2010-08-10 Thread Grant Likely
On Mon, Aug 09, 2010 at 01:36:18PM +0300, Felipe Balbi wrote: On Thu, Jun 03, 2010 at 01:09:01PM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote: From: Felipe Balbi felipe.ba...@nokia.com dev_vdbg() is only compiled when VERBOSE is defined, so there's no need to wrap dev_dbg() on #ifdef

Re: [spi-devel-general] [PATCH v2 6/6] DTS: add SPI flash(s25fl128p01) support on p4080ds and mpc8536ds board

2010-08-10 Thread Grant Likely
Hi Mingkai, one comment below. Otherwise this patch looks good, and so does patch 5. g. On Mon, Aug 2, 2010 at 1:52 AM, Mingkai Hu mingkai...@freescale.com wrote: Signed-off-by: Mingkai Hu mingkai...@freescale.com --- v2:  - Remove the whitespace inconsitencies  

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Grant Likely
On Tue, Aug 10, 2010 at 1:14 AM, David Brownell davi...@pacbell.net wrote: --- On Mon, 8/9/10, Grant Likely grant.lik...@secretlab.ca wrote: +       nr_parts = of_mtd_parse_partitions(spi-dev, np, parts); Let's keep OF-specific logic out of drivers like this one ...  intended to work

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread David Brownell
--- On Mon, 8/9/10, Grant Likely grant.lik...@secretlab.ca wrote: +       nr_parts = of_mtd_parse_partitions(spi-dev, np, parts); Let's keep OF-specific logic out of drivers like this one ... intended to work without OF. NAK on adding dependencies like OF to drivers and other

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Joakim Tjernlund
On Tue, Aug 10, 2010 at 1:14 AM, David Brownell davi...@pacbell.net wrote: --- On Mon, 8/9/10, Grant Likely grant.lik...@secretlab.ca wrote: +       nr_parts = of_mtd_parse_partitions(spi-dev, np, parts); Let's keep OF-specific logic out of drivers like this one ...  intended

Re: [spi-devel-general] [PATCH v2 4/6] mtd: m25p80: add a read function to read page by page

2010-08-10 Thread David Brownell
--- On Tue, 8/10/10, Grant Likely grant.lik...@secretlab.ca wrote: This one bothers me, but I can't put my finger on it. The flag feels like a controller specific hack. That's because it *IS* ... Not clear what a good fix would look like. But in general, SPI master controllers are

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Grant Likely
On Tue, Aug 10, 2010 at 2:29 AM, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: On Tue, Aug 10, 2010 at 1:14 AM, David Brownell davi...@pacbell.net wrote: --- On Mon, 8/9/10, Grant Likely grant.lik...@secretlab.ca wrote: +       nr_parts = of_mtd_parse_partitions(spi-dev,

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Anton Vorontsov
On Tue, Aug 10, 2010 at 08:56:42AM -0600, Grant Likely wrote: [...] The suggestion has been raised to use something like bus notifiers to get a hook onto the device registration before the driver is probed so that the platform_data can be translated in an separate chuck of code, but down that

Re: [spi-devel-general] [PATCH] [SPI] SPI100k: Fix 8-bit and RX-only transfers

2010-08-10 Thread Grant Likely
On Mon, Aug 2, 2010 at 9:34 AM, Cory Maccarrone darkstar6...@gmail.com wrote: On Sat, May 29, 2010 at 5:12 PM, Cory Maccarrone darkstar6...@gmail.com wrote: This change fixes 8-bit transfers and RX-only transfers.  The SPI100k framework requires minimum 16-bit words to be written, so 8-bit

Re: [spi-devel-general] [PATCH v2 3/6] mtd: m25p80: add support to parse the SPI flash's partitions

2010-08-10 Thread Grant Likely
On Tue, Aug 10, 2010 at 11:23 AM, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: glik...@secretlab.ca wrote on 2010/08/10 16:56:42: On Tue, Aug 10, 2010 at 2:29 AM, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: On Tue, Aug 10, 2010 at 1:14 AM, David Brownell

[spi-devel-general] nitin vishnoi invites you to join Ecademy

2010-08-10 Thread nitin vishnoi
Hi, Join Ecademy now for business networking and support - Share Knowledge - Build your Network - Grow your Business thanks, nitin vishnoi nitvish...@gmail.com This email was sent to spi-devel-general@lists.sourceforge.net To avoid receiving these emails in the future send an email from that