Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driver forbutton/scrollwhell/slider/touchpad

2009-09-02 Thread Song, Barry
-Original Message- From: uclinux-dist-devel-boun...@blackfin.uclinux.org [mailto:uclinux-dist-devel-boun...@blackfin.uclinux.org] On Behalf Of David Brownell Sent: Wednesday, September 02, 2009 9:52 AM To: Barry Song Cc: dbrown...@users.sourceforge.net; d...@mail.ru;

Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driver forbutton/scrollwhell/slider/touchpad

2009-09-02 Thread Barry Song
David, I am really surprised the kmalloc memory can keep DMA-safe. Check the code, no matter spi_write_then_read and spi_init, they only get memory by a simple kmalloc(SPI_BUFSIZ, GFP_KERNEL); I can't find map_single or dma coherent operations at all. So did I lose something? Thanks Barry On

Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driver forbutton/scrollwhell/slider/touchpad

2009-09-02 Thread Song, Barry
-Original Message- From: Barry Song [mailto:21cn...@gmail.com] Sent: Wednesday, September 02, 2009 3:52 PM To: David Brownell Cc: Song, Barry; Mike Frysinger; dbrown...@users.sourceforge.net; d...@mail.ru; dmitry.torok...@gmail.com; spi-devel-general@lists.sourceforge.net;

Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driver forbutton/scrollwhell/slider/touchpad

2009-09-02 Thread David Brownell
On Wednesday 02 September 2009, Barry Song wrote: David, I am really surprised the kmalloc memory can keep DMA-safe. Then you need to internalize more of the docs on the DMA calls ... :) Notably see in Documentation/DMA-mapping.txt the section up top where it describes what memory can be used

Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driverforbutton/scrollwhell/slider/touchpad

2009-09-02 Thread Mike Frysinger
On Wed, Sep 2, 2009 at 05:50, Robin Getz wrote: On Tue 1 Sep 2009 23:17, Song, Barry pondered: No. I can't agree other coding style issues you said. I will keep my original codes for these issues except adding a BUS_SPI. style is different than performance Did you think about Mike's

Re: [spi-devel-general] [Uclinux-dist-devel] [PATCH 2/2] add ad714x input driverforbutton/scrollwhell/slider/touchpad

2009-09-02 Thread Robin Getz
On Tue 1 Sep 2009 23:17, Song, Barry pondered: No. I can't agree other coding style issues you said. I will keep my original codes for these issues except adding a BUS_SPI. style is different than performance Did you think about Mike's comment - I think it was a performance issue he was

Re: [spi-devel-general] [PATCH 1/2] add ad714x platform_data definition

2009-09-02 Thread Bill Gatliff
David Brownell wrote: It's good policy to include a brief GPL statement at the top of every source file too, including a Copyright (C) you. I think good policy is probably understating things a bit. :) b.g. -- Bill Gatliff b...@billgatliff.com

Re: [spi-devel-general] [patch 2.6.31-rc7] spi: Freescale STMP driver

2009-09-02 Thread David Brownell
On Tuesday 01 September 2009, Andrew Morton wrote: +#define busy_wait(cond)  \ + ({  \ + unsigned long end_jiffies = jiffies + STMP_SPI_TIMEOUT; \ + bool

Re: [spi-devel-general] [patch 2.6.31-rc7 2/3] spi: McSPI saves CHCONFx too

2009-09-02 Thread David Brownell
On Tuesday 01 September 2009, Andrew Morton wrote: On Thu, 27 Aug 2009 20:21:11 -0700 David Brownell davi...@pacbell.net wrote: From: Tero Kristo tero.kri...@nokia.com Previous restore was lazy and only restored CHxCONF when it was needed by a specific chip select. This could cause

Re: [spi-devel-general] [patch 2.6.31-rc7] spi: Freescale STMP driver

2009-09-02 Thread dmitry pervushin
On Wed, 2009-09-02 at 08:47 -0700, David Brownell wrote: On Tuesday 01 September 2009, Andrew Morton wrote: +#define busy_wait(cond) \ + ({ \ + unsigned long

Re: [spi-devel-general] [patch 2.6.31-rc7] spi: Freescale STMP driver

2009-09-02 Thread Andrew Morton
On Wed, 2 Sep 2009 08:47:18 -0700 David Brownell davi...@pacbell.net wrote: On Tuesday 01 September 2009, Andrew Morton wrote: +#define busy_wait(cond)\

Re: [spi-devel-general] [patch 2.6.31-rc7 2/3] spi: McSPI saves CHCONFx too

2009-09-02 Thread Andrew Morton
On Wed, 2 Sep 2009 08:53:16 -0700 David Brownell davi...@pacbell.net wrote: On Tuesday 01 September 2009, Andrew Morton wrote: On Thu, 27 Aug 2009 20:21:11 -0700 David Brownell davi...@pacbell.net wrote: From: Tero Kristo tero.kri...@nokia.com Previous restore was lazy and only

[spi-devel-general] [SPAM] T_. From one of the letters we learn that Lucil

2009-09-02 Thread Clarine
If he shall survive his eccentricities of diet that long. He was an omnivorous buyer, picking up everything he could lay his h inline: cheesed.jpg-- Let Crystal Reports handle the reporting - Free Crystal Reports 2008