RE: [PATCH 0/2] S3C24XX: remove some spi left overs

2012-01-27 Thread Kukjin Kim
Heiko Stübner wrote:
 
 This series removes unused setup-code of the s3c24xx spi driver.
 
 It has no current in kernel users and also no development activity trying
 to change this. I also checked the upstream git of the only board including
 the spi.h file (the gta02 at http://git.openmoko.org). The setup calls
 are also not used there.
 
 I recall a thread some time back talking about removing the spi-s3c24xx
 driver altogether, but as current linux-next still carries the driver
 I'm not sure what became of it. So this series does the next smaller thing.
 
 
 Heiko Stuebner (2):
   S3C24XX: remove unused spi gpio setup functions
   S3C24XX: move spi-s3c24xx platdata out of mach
 
  arch/arm/mach-s3c2410/include/mach/spi.h |   38 
 --
  arch/arm/mach-s3c2440/mach-gta02.c   |2 +-
  arch/arm/plat-s3c24xx/Kconfig|   20 -
  arch/arm/plat-s3c24xx/Makefile   |6 
  arch/arm/plat-s3c24xx/spi-bus0-gpe11_12_13.c |   36 
  arch/arm/plat-s3c24xx/spi-bus1-gpd8_9_10.c   |   38 
 --
  arch/arm/plat-s3c24xx/spi-bus1-gpg5_6_7.c|   36 
  drivers/spi/spi-s3c24xx.c|2 +-
  8 files changed, 2 insertions(+), 176 deletions(-)
  delete mode 100644 arch/arm/mach-s3c2410/include/mach/spi.h
  delete mode 100644 arch/arm/plat-s3c24xx/spi-bus0-gpe11_12_13.c
  delete mode 100644 arch/arm/plat-s3c24xx/spi-bus1-gpd8_9_10.c
  delete mode 100644 arch/arm/plat-s3c24xx/spi-bus1-gpg5_6_7.c
 
 --
 1.7.2.3

Looks good :)
Applied in my cleanup-s3c24xx, thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


[PATCH v2 2/2] S3C24XX: move spi-s3c24xx platdata out of mach

2012-01-27 Thread Heiko Stübner
spi.h now only contains the definition of the platform data structure
for the driver in spi-s3c24xx.c . Therefore it does not need to stay
in include/mach but can instead live in linux/spi/s3c24xx.h .

Signed-off-by: Heiko Stuebner he...@sntech.de
---
Sorry for messing up, but it seems I forgot to readd the moved spi header
in the original submission of the second patch, which I noticed just now.
As your cleanup-s3c24xx branch is not pushed out yet, could you please
replace it with this one, which adds the forgotten file.

 arch/arm/mach-s3c2410/include/mach/spi.h |   27 ---
 arch/arm/mach-s3c2440/mach-gta02.c   |2 +-
 drivers/spi/spi-s3c24xx.c|2 +-
 include/linux/spi/s3c24xx.h  |   26 ++
 4 files changed, 28 insertions(+), 29 deletions(-)
 delete mode 100644 arch/arm/mach-s3c2410/include/mach/spi.h
 create mode 100644 include/linux/spi/s3c24xx.h

diff --git a/arch/arm/mach-s3c2410/include/mach/spi.h 
b/arch/arm/mach-s3c2410/include/mach/spi.h
deleted file mode 100644
index 2a686c0..000
--- a/arch/arm/mach-s3c2410/include/mach/spi.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/* arch/arm/mach-s3c2410/include/mach/spi.h
- *
- * Copyright (c) 2006 Simtec Electronics
- * Ben Dooks b...@simtec.co.uk
- *
- * S3C2410 - SPI Controller platform_device info
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
-*/
-
-#ifndef __ASM_ARCH_SPI_H
-#define __ASM_ARCH_SPI_H __FILE__
-
-struct s3c2410_spi_info {
-   int  pin_cs;/* simple gpio cs */
-   unsigned int num_cs;/* total chipselects */
-   int  bus_num;   /* bus number to use. */
-
-   unsigned int use_fiq:1; /* use fiq */
-
-   void (*gpio_setup)(struct s3c2410_spi_info *spi, int enable);
-   void (*set_cs)(struct s3c2410_spi_info *spi, int cs, int pol);
-};
-
-#endif /* __ASM_ARCH_SPI_H */
diff --git a/arch/arm/mach-s3c2440/mach-gta02.c 
b/arch/arm/mach-s3c2440/mach-gta02.c
index 5859e60..cf270f5 100644
--- a/arch/arm/mach-s3c2440/mach-gta02.c
+++ b/arch/arm/mach-s3c2440/mach-gta02.c
@@ -38,6 +38,7 @@
 #include linux/platform_device.h
 #include linux/serial_core.h
 #include linux/spi/spi.h
+#include linux/spi/s3c24xx.h
 
 #include linux/mmc/host.h
 
@@ -73,7 +74,6 @@
 #include mach/regs-gpioj.h
 #include mach/fb.h
 
-#include mach/spi.h
 #include plat/usb-control.h
 #include mach/regs-mem.h
 #include mach/hardware.h
diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c
index fc06453..8ee7d79 100644
--- a/drivers/spi/spi-s3c24xx.c
+++ b/drivers/spi/spi-s3c24xx.c
@@ -24,10 +24,10 @@
 
 #include linux/spi/spi.h
 #include linux/spi/spi_bitbang.h
+#include linux/spi/s3c24xx.h
 #include linux/module.h
 
 #include plat/regs-spi.h
-#include mach/spi.h
 
 #include plat/fiq.h
 #include asm/fiq.h
diff --git a/include/linux/spi/s3c24xx.h b/include/linux/spi/s3c24xx.h
new file mode 100644
index 000..c23b923
--- /dev/null
+++ b/include/linux/spi/s3c24xx.h
@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) 2006 Simtec Electronics
+ * Ben Dooks b...@simtec.co.uk
+ *
+ * S3C2410 - SPI Controller platform_device info
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#ifndef __LINUX_SPI_S3C24XX_H
+#define __LINUX_SPI_S3C24XX_H __FILE__
+
+struct s3c2410_spi_info {
+   int  pin_cs;/* simple gpio cs */
+   unsigned int num_cs;/* total chipselects */
+   int  bus_num;   /* bus number to use. */
+
+   unsigned int use_fiq:1; /* use fiq */
+
+   void (*gpio_setup)(struct s3c2410_spi_info *spi, int enable);
+   void (*set_cs)(struct s3c2410_spi_info *spi, int cs, int pol);
+};
+
+#endif /* __LINUX_SPI_S3C24XX_H */
-- 
1.7.5.4


--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH] spi/pl022: Add high priority message pump support

2012-01-27 Thread Grant Likely
On Thu, Jan 26, 2012 at 7:48 AM, Linus Walleij linus.wall...@linaro.org wrote:
 On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown broo...@sirena.org.uk wrote:
 On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote:

 This switches the PL022 worker to a kthread in order to get
 hold of a mechanism to control the message pump priority. On
 low-latency systems elevating the message kthread to realtime
 priority give a real sleek response curve. This has been
 confirmed by measurements. Realtime priority elevation for
 a certain PL022 port can be requested from platform data.

 It really feels like we should be pulling this into the core - lots of
 drivers use a workqueue to drive data through the system and they're all
 going to have exactly the same issue.

 That reads to me like the entire message queue and transfer pump
 mechanism from the PL022 driver should be made into generic
 code. That is the key ingredient from the PL022 driver that has
 allowed us to get real nice throughput on it.

 And that observation is correct, but a bit of upfront code.

 If Grant is in on it I might give it a try.

Go for it and see what it looks like.

g.

--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general