Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On Wed, May 9, 2012 at 3:34 AM, Thomas Abraham thomas.abra...@linaro.org wrote: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use

Re: [PATCH 00/10] spi: s3c64xx: add support for device tree

2012-05-09 Thread Jassi Brar
On Wed, May 9, 2012 at 3:34 AM, Thomas Abraham thomas.abra...@linaro.org wrote: This patch series adds device tree based discovery support for Samsung's s3c64xx compatible spi controller. This is mainly tested for Exynos4210 and Exynos5250 with onboard spi nor flash device. This patch series

Re: [PATCH 10/10] spi: s3c64xx: add device tree support

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote: +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no + particular order). The format of the gpio specifier depends on the gpio + controller. This seems odd... This isn't a bitbanging controller, and

Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Heiko Stübner
Am Mittwoch, 9. Mai 2012, 10:56:17 schrieb Mark Brown: On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote: + s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1); Shouldn't we just set the name in the struct platform_device rather than requiring the machine to pass it through by

[PATCH] SPI: Refactor spi-orion to use SPI framework queue.

2012-05-09 Thread Andrew Lunn
Replace the deprecated master-transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn and...@lunn.ch --- Note: This patch depends on clk-next and clk-next-orion held by Mike Turquette and soon to be pushed upstream. So it

Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote: + s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1); Shouldn't we just set the name in the struct platform_device rather than requiring the machine to pass it through by hand?

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote: With the addition of platform specific driver data in the spi-s3c64xx driver, the device name of spi controllers are changed. Accordingly, update the device name of spi clocks instances. This should've been squashed into the patch

Re: [PATCH 07/10] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-05-09 Thread Jassi Brar
On 9 May 2012 14:50, Heiko Stübner he...@sntech.de wrote: Am Mittwoch, 9. Mai 2012, 00:04:51 schrieb Thomas Abraham: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery.

Re: [PATCH v3] spi/ep93xx: clean probe/remove routines

2012-05-09 Thread Hannu Heikkinen
Hi, any progress on this (patch in below)? Haven't received any comments after v2 br, Hannu On Thu, Apr 19, 2012 at 7:05 PM, Hannu Heikkinen hann...@iki.fi wrote: Use devm_* functions for managing devres resources. Also use local variable irq and remove irq variable from struct

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-09 Thread Thomas Abraham
On 9 May 2012 16:52, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote: With the addition of platform specific driver data in the spi-s3c64xx driver, the device name of spi controllers are changed. Accordingly, update the

Re: [PATCH 10/10] spi: s3c64xx: add device tree support

2012-05-09 Thread Thomas Abraham
On 9 May 2012 17:07, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote: +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no +  particular order). The format of the gpio specifier depends on the gpio +  

Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Thomas Abraham
On 9 May 2012 22:33, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 09, 2012 at 10:22:26PM +0800, Thomas Abraham wrote: On 9 May 2012 18:55, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Yes, that's the normal way of handling this and is actually what the code was

Jusqu'à 50% sur votre séjour dans un hôtel Disney

2012-05-09 Thread Madame Vacances par Duano
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTExMzQ4JmM9NDgzNjEyJmQ9MjAxMi0wNS0wOSAxMTo1MDowMSZlPTEmaD0xMTM0NyZmPTExMzQ4Jmc9MTEzNDg= Lien de désinscription :

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-09 Thread Thomas Abraham
On 9 May 2012 22:28, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, May 09, 2012 at 09:40:26PM +0800, Thomas Abraham wrote: On 9 May 2012 16:52, Mark Brown broo...@opensource.wolfsonmicro.com wrote: This should've been squashed into the patch that updated to use driver data

Re: [PATCH 10/10] spi: s3c64xx: add device tree support

2012-05-09 Thread Thomas Abraham
On 10 May 2012 00:47, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, May 10, 2012 at 12:39:29AM +0800, Thomas Abraham wrote: On 9 May 2012 22:32, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Yeah, I know.  I'm saying we should try to come up with a binding for this

[PATCH] spi/topcliff: use correct __devexit_p annotation

2012-05-09 Thread mathieu . poirier
From: Arnd Bergmann a...@arndb.de __devexit functions are discarded when CONFIG_HOTPLUG is not set, so the symbol needs to be referenced carefully. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Mathieu Poirier mathieu.poir...@linaro.org --- drivers/spi/spi-topcliff-pch.c |2 +-

Re: [PATCH] spi/topcliff: use correct __devexit_p annotation

2012-05-09 Thread Grant Likely
On Wed, 9 May 2012 16:35:23 -0600, mathieu.poir...@linaro.org wrote: From: Arnd Bergmann a...@arndb.de __devexit functions are discarded when CONFIG_HOTPLUG is not set, so the symbol needs to be referenced carefully. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Mathieu

Re: [PATCH] spi/omap: cleanup probe/remove routines

2012-05-09 Thread Grant Likely
On Wed, 9 May 2012 15:43:58 +0300, Hannu Heikkinen hann...@iki.fi wrote: Cleanup probe and remove routines, use devm_* functions for managing resources. Also, in under free_master label, change use of kfree() into spi_master_put(). Patch does not apply to my current spi/next branch[1].