[PATCH] SPI: SIRF: replace -EINVAL by PTR_ERR(clk) when clk_get fails
From: Barry Song baohua.s...@csr.com
With this patch, the ret value will be more meaningful.
Signed-off-by: Barry Song baohua.s...@csr.com
---
drivers/spi/spi-sirf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/spi/spi-sirf.c b/drivers/spi/spi-sirf.c
index ecc3d97..0b10e4f 100644
--- a/drivers/spi/spi-sirf.c
+++ b/drivers/spi/spi-sirf.c
@@ -567,7 +567,7 @@ static int __devinit spi_sirfsoc_probe(struct
platform_device *pdev)
sspi-clk = clk_get(pdev-dev, NULL);
if (IS_ERR(sspi-clk)) {
- ret = -EINVAL;
+ ret = PTR_ERR(sspi-clk);
goto free_pin;
}
clk_enable(sspi-clk);
--
1.7.1
Member of the CSR plc group of companies. CSR plc registered in England and
Wales, registered number 4187346, registered office Churchill House, Cambridge
Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at
http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
2ème Démarque jusqu’à -50% en Boutique et sur l’E-shop – Livraison Gratuite à Domicile!
CHEVIGNON Si vous ne pouvez pas visualiser ce message, consulter notre version en ligne. SOLDES – 2ème Démarque jusqu’à -50% en Boutique et sur l’E-shop – Livraison Gratuite http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogQfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKU http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogRvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKV http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogR_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKa http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogRPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKb http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogRfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKY http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogWvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKZ SUIVI DE COMMANDE LIVRAISON GRATUITE ECHANGE EN MAGASIN SATISFAIT OU REMBOURSE PAIEMENT SECURISE Cuir : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogW_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKe | Blousons : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogWPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKf | Pulls : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogWfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKc | Polos : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogXvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKd | T-shirts : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogX_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKi | Chemises : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogXPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKj | Pantalons : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogXfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKg | Chaussures : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogUvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKh | Accessoires : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogU_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKm | Femme : http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogUPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKn http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogUfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKk http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogVvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKl http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogV_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKq http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogVPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKr http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogVfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKo http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogavcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKp http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEoga_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKu http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogaPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKv http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogafcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKs http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogbvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKt http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogb_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKy http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogbPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKz http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogbfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKw http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogYvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlKx http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogY_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK2 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogYPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK3 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogYfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK0 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogZvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK1 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogZ_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK6 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogZPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK7 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogZfcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK4 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogevcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK5 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEoge_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK- http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogePcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK_ http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogefcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK8 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogfvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlK9 http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogf_cStGb5lw8W0bBhOG5mpqVsje_HhdA5HlLC http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogfPcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlLD http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogffcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlLA http://p5trc.emv2.com/HS?a=ENX7CqmVXCyi8SA9MKJF5d3nGHxKLEogcvcStGb5lw8W0bBhOG5mpqVsje_HhdA5HlLB
[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-s3c64xx.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index b7aeb5d..3514ef9 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -74,11 +74,6 @@
#define S3C64XX_SPI_SLAVE_AUTO (11)
#define S3C64XX_SPI_SLAVE_SIG_INACT(10)
-#define S3C64XX_SPI_ACT(c) writel(0, (c)-regs + S3C64XX_SPI_SLAVE_SEL)
-
-#define S3C64XX_SPI_DEACT(c) writel(S3C64XX_SPI_SLAVE_SIG_INACT, \
- (c)-regs + S3C64XX_SPI_SLAVE_SEL)
-
#define S3C64XX_SPI_INT_TRAILING_EN(16)
#define S3C64XX_SPI_INT_RX_OVERRUN_EN (15)
#define S3C64XX_SPI_INT_RX_UNDERRUN_EN (14)
@@ -712,14 +707,15 @@ static int s3c64xx_spi_transfer_one_message(struct
spi_master *master,
enable_cs(sdd, spi);
/* Start the signals */
- S3C64XX_SPI_ACT(sdd);
+ writel(0, sdd-regs + S3C64XX_SPI_SLAVE_SEL);
spin_unlock_irqrestore(sdd-lock, flags);
status = wait_for_xfer(sdd, xfer, use_dma);
/* Quiese the signals */
- S3C64XX_SPI_DEACT(sdd);
+ writel(S3C64XX_SPI_SLAVE_SIG_INACT,
+ sdd-regs + S3C64XX_SPI_SLAVE_SEL);
if (status) {
dev_err(spi-dev, I/O Error:
@@ -923,7 +919,7 @@ static void s3c64xx_spi_hwinit(struct
s3c64xx_spi_driver_data *sdd, int channel)
sdd-cur_speed = 0;
- S3C64XX_SPI_DEACT(sdd);
+ writel(S3C64XX_SPI_SLAVE_SIG_INACT, sdd-regs + S3C64XX_SPI_SLAVE_SEL);
/* Disable Interrupts - we use Polling if not DMA mode */
writel(0, regs + S3C64XX_SPI_INT_EN);
--
1.7.10
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Soldes 3Suisses 2ème démarques jusqu'à -80 pourcent
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTE1MjA0JmM9NDgzNjEyJmQ9MjAxMi0wNy0wNCAxNDo0MDowMSZlPTEmaD0xNTIwMyZmPTE1MjA0Jmc9MTUyMDQ= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTE1MjA0JmM9NDgzNjEyJmQ9MjAxMi0wNy0wNCAxNDo0MDowMSZlPTEmaD0xNTIwMyZmPTE1MjA0Jmc9MTUyMDQ= -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2 07/12] I2C: MV64XXX: Add Device Tree support
Hello Andrew, On Tuesday 03 July 2012 18:58:39 Andrew Lunn wrote: On Tue, Jul 03, 2012 at 05:59:13PM +0200, Florian Fainelli wrote: Hello Andrew, On Tuesday 03 July 2012 16:22:40 Andrew Lunn wrote: Extends the driver to get properties from device tree. Also extend the kirkwood DT support to supply the needed properties. Signed-off-by: Andrew Lunn and...@lunn.ch --- [snip] - if ((pd-id != 0) || !pdata) + if ((!pdata !pd-dev.of_node) || (pdata (pd-id != 0))) return -ENODEV; This is more a reminder than a real remark, but the driver here should not be limiting us to a single platform_device. In fact kirkwood55 (88F6282) has two I2C controllers for instance. Yes, i don't understand this code. It looks impossible to use it using platform_data with more than one controller. Any idea why its like this? I didn't want to change the behavior because i don't understand why its like this. No idea, we just stumbled over this with a colleague the other day, and just removing the check made our second I2C controller work, so I don't see any reason why there is such a limitation. That said, this is for a subsequent patch. However, it should be possible to instantiate multiple I2C controllers using DT. However, i've only tested it with one. Andrew ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Florian -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver
Dear Fabio Estevam, Hi Marek, On 6/29/12, Marek Vasut ma...@denx.de wrote: iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!iores) + dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0); + irq_err = platform_get_irq(pdev, 0); + irq_dma = platform_get_irq(pdev, 1); + if (!iores || irq_err 0 || irq_dma 0) Shouldn't you check for dmares 0 here too? Yes. What about the rest of the patches? Are they applicable? Best regards, Marek Vasut -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 8/8] mmc: spi: Add DMA support into SPI driver
On Wed, Jul 4, 2012 at 6:40 PM, Marek Vasut ma...@denx.de wrote: Shouldn't you check for dmares 0 here too? Yes. What about the rest of the patches? Are they applicable? They look fine for me. Let's see if we have more comments. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28
On Fri, Jun 29, 2012 at 10:22:58AM +0200, Marek Vasut wrote: +config SPI_MXS + tristate Freescale MXS SPI controller + depends on ARCH_MXS + help + SPI driver for Freescale MXS devices. + ... + stmp_reset_block(ssp-base); + So SPI_MXS may need to select STMP_DEVICE. -- Regards, Shawn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
项目申报会议通知（7月20日苏州会议）
9:36:05-- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Votre animal est t-il bien assure
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTE1MDczJmM9NDgzNjEyJmQ9MjAxMi0wNy0wNSAwMzoxMDowMiZlPTEmaD0xNTA3MiZmPTE1MDczJmc9MTUwNzM= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTE1MDczJmM9NDgzNjEyJmQ9MjAxMi0wNy0wNSAwMzoxMDowMiZlPTEmaD0xNTA3MiZmPTE1MDczJmc9MTUwNzM= -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 6/8] mmc: spi: Add SPI driver for mx233/mx28
On 5 July 2012 13:46, Marek Vasut ma...@denx.de wrote: Correct, this I fixed in my tree and will repost the series. I also fixed the documentation issue. But ... what about the rest of the series, are you OK with it as is ? Yes, it looks okay to me. Regards, Shawn -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
