Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM
On Tue, Sep 18, 2012 at 5:20 PM, Linus Walleij wrote:
> On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar wrote:
>
>> Yes, we don't need to call prepare() again atleast for SPEAr. You are
>> correct.
>> I saw the driver after a long time :)
>
> I'm asking because it's actually OK to do this, I was more asking whether it
> was really needed by any platforms...
Yes, I got that. Patch from Vipul is correct and should be there for
any platforms
which do anything in prepare/unprepare. But Atleast for SPEAr we don't need it.
But i would still insist in keeping it for completeness. :)
> We clk_disable() at runtime_suspend() and clk_enable() at runtime resume,
> and the driver gives hints to the runtime PM layer to autosuspend the
> driver whenever it's unused. Check the pm_runtime_* calls.
Ahh.. How could i miss it.
>> The amba layer is taking care of interface clock only and not
>> functional clock. So
>> i believe that's not the magic code. :)
>
> This clock is the one for the external bus. In some designs these two
> clocks are one and the same, and these won't currently get into any clock
> disabled states, sadly. (We need to fix that some day.)
I went through the code and found following in amba/bus.c:
static int amba_pm_runtime_suspend(struct device *dev)
{
struct amba_device *pcdev = to_amba_device(dev);
int ret = pm_generic_runtime_suspend(dev);
if (ret == 0 && dev->driver)
clk_disable(pcdev->pclk);
return ret;
}
static int amba_pm_runtime_resume(struct device *dev)
{
struct amba_device *pcdev = to_amba_device(dev);
int ret;
if (dev->driver) {
ret = clk_enable(pcdev->pclk);
/* Failure is probably fatal to the system, but... */
if (ret)
return ret;
}
return pm_generic_runtime_resume(dev);
}
If i am not wrong, these routines also get called with runtiime suspend/resume
of pl022? If that is the case, the even the interface clock of pl022 is getting
disabled when not in used.
And so for Architectures like SPEAr (where functional and interface
clock are controlled
by a single bit), we don't need anything else for power saving, with
respect to clocks.
Isn't it so?
@Vipul/Vinit: Can you please confirm this behavior?
--
viresh
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[SPAM] 代/开――发/票
您好： 本公司优惠代理全国各地大城市发票; 贵公司如有需要，欢迎您的来电与我联系： 负责人：张先生(0)13544100624 -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Especial Eletrolux com descontos especiais
Seu cliente de e-mail não pode ler este e-mail. Para visualizá-lo on-line, por favor, clique aqui: http://emailmais.com/mkt/display.php?M=1124451&C=0b7ccc17e240df20d33812a1a734e400&S=6&L=4&N=2 Para parar de receber nossos Emails:http://emailmais.com/mkt/unsubscribe.php?M=1124451&C=0b7ccc17e240df20d33812a1a734e400&L=4&N=6 Email Marketing -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
* Shubhrajyoti [120918 05:09]: > On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote: > > Adds pinctrl support to support OMAP platforms that boot from DT > > and rely on pinctrl support to set pinmuxes. > looks good > > Acked-by: Shubhrajyoti D Acked-by: Tony Lindgren -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree
Hi, On 09/18/2012 02:08 PM, Linus Walleij wrote: >> When we have sorted out this driver change (please check the new pl022 >> specific dt property names!), I will provide patches for arm-soc to >> actually use this new interface via dts files. > > OK cool I guess you will do this for the LPC32xx? Or are you testing > this on some other platforms? LPC32xx for now. The new code is backwards compatible, so I'd prefer for others to adopt and test it on their platforms individually before patching everything at once without testing. Roland -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
La livraison a domicile est offerte sur Mistergooddeal
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT04JmI9MjAwOTkmYz0xOTYxNjQxJmQ9MjAxMi0wOS0xOCAwODowMDowMSZlPTEmaD0yMDA5OCZmPTIwMDk5Jmc9MjAwOTk= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT04JmI9MjAwOTkmYz0xOTYxNjQxJmQ9MjAxMi0wOS0xOCAwODowMDowMSZlPTEmaD0yMDA5OCZmPTIwMDk5Jmc9MjAwOTk= -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states
On Mon, Sep 17, 2012 at 7:22 PM, Matt Porter wrote: > Enable pinctrl dummy states for all OMAP platforms that don't > populate DT. This allows drivers to be converted to pinctrl > and not generate new warnings on platforms that do not provide > pinctrl data. These platforms already have pinmuxes configured > before the drivers probe. > > Signed-off-by: Matt Porter Looks like a good idea, so FWIW: Acked-by: Linus Walleij Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
On Tuesday 18 September 2012 05:31 PM, Matt Porter wrote:
> Adds pinctrl support to support OMAP platforms that boot from DT
> and rely on pinctrl support to set pinmuxes.
looks good
Acked-by: Shubhrajyoti D
> Signed-off-by: Matt Porter
> ---
> drivers/spi/spi-omap2-mcspi.c |8
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index b2fb141..9502566 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -38,6 +38,8 @@
> #include
> #include
> #include
> +#include
> +#include
>
> #include
>
> @@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct
> platform_device *pdev)
> static int bus_num = 1;
> struct device_node *node = pdev->dev.of_node;
> const struct of_device_id *match;
> + struct pinctrl *pinctrl;
>
> master = spi_alloc_master(&pdev->dev, sizeof *mcspi);
> if (master == NULL) {
> @@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct
> platform_device *pdev)
> if (status < 0)
> goto dma_chnl_free;
>
> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev,
> + "pins are not configured from the driver\n");
> +
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
> pm_runtime_enable(&pdev->dev);
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree
On Mon, Sep 17, 2012 at 7:03 PM, Roland Stigge wrote: > On 09/10/2012 01:11 PM, Linus Walleij wrote: >> >> It appears Roland has written his bindings such that DT >> data augments platform data (yes, I am also getting crazy >> about this prioritization, mea culpa for ACKing this without >> proper discussion) so it appears that you could actually >> use AUXDATA and some stuff in the DT at the same >> time. > > Sorry for the incompleteness of the devicetree conversion. I'm sending a > patch (separately) that makes it possible to specify everything via > devicetree, so you can choose between dt and platform data. OK it was not such a big deal, but many many thanks for fixing this up! :-) > Except in case of callback specification (dma_filter()), you need to > provide platform data. OK. > Interestingly, when I removed the actual platform data from the board > file, I noticed that I still needed to specify a device name (like > dev:ssp0) to make it work. But this seems to be expected according to > the documentation of OF_DEV_AUXDATA(). Are there any plans or ideas how > to fix this? This is very likely because the clock tree has a name like "dev:ssp0" encoded for this device, and if you don't nail it down like that the device name will be the same as the node in your device tree and then clock lookup will fail. The "real fix" is to convert the clock drivers to use device tree so the drivers can just refer to the phandles to figure out what clock node they need. Along with the DMA channel mapping this is one of the major roadblocks to finalizing the device tree adoptions. > When we have sorted out this driver change (please check the new pl022 > specific dt property names!), I will provide patches for arm-soc to > actually use this new interface via dts files. OK cool I guess you will do this for the LPC32xx? Or are you testing this on some other platforms? Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
On Tue, Sep 18, 2012 at 10:57:26AM +0530, Shubhrajyoti wrote:
> On Monday 17 September 2012 10:52 PM, Matt Porter wrote:
> > Adds pinctrl support to support OMAP platforms that boot from DT
> > and rely on pinctrl support to set pinmuxes.
> >
> > Signed-off-by: Matt Porter
> > ---
> looks good to me.
> you may want to repost with Mark in cc to review.
> Acked-by: Shubhrajyoti D
Thanks...reposted this part with Mark cced.
-Matt
> > drivers/spi/spi-omap2-mcspi.c |8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> > index b2fb141..9502566 100644
> > --- a/drivers/spi/spi-omap2-mcspi.c
> > +++ b/drivers/spi/spi-omap2-mcspi.c
> > @@ -38,6 +38,8 @@
> > #include
> > #include
> > #include
> > +#include
> > +#include
> >
> > #include
> >
> > @@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct
> > platform_device *pdev)
> > static int bus_num = 1;
> > struct device_node *node = pdev->dev.of_node;
> > const struct of_device_id *match;
> > + struct pinctrl *pinctrl;
> >
> > master = spi_alloc_master(&pdev->dev, sizeof *mcspi);
> > if (master == NULL) {
> > @@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct
> > platform_device *pdev)
> > if (status < 0)
> > goto dma_chnl_free;
> >
> > + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> > + if (IS_ERR(pinctrl))
> > + dev_warn(&pdev->dev,
> > + "pins are not configured from the driver\n");
> > +
> > pm_runtime_use_autosuspend(&pdev->dev);
> > pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
> > pm_runtime_enable(&pdev->dev);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[REPOST PATCH v2 1/2] spi: omap2-mcspi: add pinctrl support
Adds pinctrl support to support OMAP platforms that boot from DT
and rely on pinctrl support to set pinmuxes.
Signed-off-by: Matt Porter
---
drivers/spi/spi-omap2-mcspi.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index b2fb141..9502566 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -38,6 +38,8 @@
#include
#include
#include
+#include
+#include
#include
@@ -1124,6 +1126,7 @@ static int __devinit omap2_mcspi_probe(struct
platform_device *pdev)
static int bus_num = 1;
struct device_node *node = pdev->dev.of_node;
const struct of_device_id *match;
+ struct pinctrl *pinctrl;
master = spi_alloc_master(&pdev->dev, sizeof *mcspi);
if (master == NULL) {
@@ -1219,6 +1222,11 @@ static int __devinit omap2_mcspi_probe(struct
platform_device *pdev)
if (status < 0)
goto dma_chnl_free;
+ pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
+ if (IS_ERR(pinctrl))
+ dev_warn(&pdev->dev,
+ "pins are not configured from the driver\n");
+
pm_runtime_use_autosuspend(&pdev->dev);
pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
pm_runtime_enable(&pdev->dev);
--
1.7.9.5
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Decouvrez les offres à -50% sur Weight Watchers Online
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT0xMyZiPTIwMzA5JmM9NDgzNjEyJmQ9MjAxMi0wOS0xOCAwNzo1MDowMSZlPTEmaD0yMDMwOCZmPTIwMzA5Jmc9MjAzMDk= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT0xMyZiPTIwMzA5JmM9NDgzNjEyJmQ9MjAxMi0wOS0xOCAwNzo1MDowMSZlPTEmaD0yMDMwOCZmPTIwMzA5Jmc9MjAzMDk= -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM
On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar wrote: > Yes, we don't need to call prepare() again atleast for SPEAr. You are correct. > I saw the driver after a long time :) I'm asking because it's actually OK to do this, I was more asking whether it was really needed by any platforms... > Can you please elaborate, why can't i see any clk_disable/enable calls > anywhere > else from probe. If i remember correctly, earlier we used to enable/disable > clk after transfers and also during suspend/resume. We clk_disable() at runtime_suspend() and clk_enable() at runtime resume, and the driver gives hints to the runtime PM layer to autosuspend the driver whenever it's unused. Check the pm_runtime_* calls. > The amba layer is taking care of interface clock only and not > functional clock. So > i believe that's not the magic code. :) This clock is the one for the external bus. In some designs these two clocks are one and the same, and these won't currently get into any clock disabled states, sadly. (We need to fix that some day.) Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Ventes Flash : premiers arrives premiers servis
Pour voir le message, veuillez utiliser un lecteur de mail compatible HTML Lien miroir : http://m10-fr.com/mc10_m/YT04JmI9MjAyNjkmYz0xOTYxNjQxJmQ9MjAxMi0wOS0xNyAxOTozMDowMSZlPTEmaD0yMDI2OCZmPTIwMjY5Jmc9MjAyNjk= Lien de désinscription : http://m10-fr.com/mc10_unsub/YT04JmI9MjAyNjkmYz0xOTYxNjQxJmQ9MjAxMi0wOS0xNyAxOTozMDowMSZlPTEmaD0yMDI2OCZmPTIwMjY5Jmc9MjAyNjk= -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
