Since commit ab78029 (drivers/pinctrl: grab default handles from device
core) we can rely on device core for handling pinctrl so remove
devm_pinctrl_get_select_default() from the driver.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-omap2-mcspi.c |7
-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 4ab992b..6d6537d 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi
Don't silently ignore errors, report them.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
MAINTAINERS |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index a3be666..0c9c104 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7431,9 +7431,10 @@ S: Maintained
F
On Tue, Apr 16, 2013 at 04:58:47PM +0530, Girish KS wrote:
On Tue, Apr 16, 2013 at 4:50 PM, Mark Brown broo...@kernel.org wrote:
I'm missing patch 1 of this series.
its already merged to stable tree after your review
The patch numbering should reflect what you're posting. If you're only
The core can do the validation for us.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 7f5f8ee..27ff669 100644
On Fri, Mar 22, 2013 at 11:09:08AM +0900, Jingoo Han wrote:
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used
when the CONFIG_PM_SLEEP is
On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote:
This patch adds support for spi controllers with
dedicated clk/miso/mosi/cs pins. It skips the gpio
parsing and initialization for controllers that
have dedicated pins.
if (sdd-tgl_spi != spi) { /* if last mssg on diff
user
implementing EDMA so in the !DT case we can default to the OMAP DMA
filter.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
--
Everyone hates slow websites. So do we.
Make your web apps faster
() on the
message.
Reviewed-by: Mark Brown broo...@opensource.wolfsonmicro.com
for the helpers, we should try to get them merged separately to the
coccinelle rules if there's issue with those.
--
Master Visual Studio
Use GFP_DMA in order to ensure that the memory we allocate for transfers
in spi_write_then_read() can be DMAed. On most platforms this will have
no effect.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion
On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote:
As for i2c-core, let the SPI core handle the removal of the device's
drvdata, after a remove() or a probe() failure.
Any driver that notices this change is buggy, the driver shouldn't
use a drvdata value that it didn't set. I had
Grant said he would find it helpful for me to continue handling some of
the legwork for SPI so add myself to MAINTAINERS so I get CCed on
patches.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
MAINTAINERS |1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index ad93231..6495352 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
On Tue, Dec 18, 2012 at 11:29:34AM -0500, Jun Chen wrote:
* @master: Controller to which device is connected
+ * device_was_children_of_master is flag which the device is registed
+ * as the children of the bus
This isn't a kerneldoc style comment (it needs the @XXX: format). The
name is
On Thu, Dec 06, 2012 at 02:04:27PM +, Grant Likely wrote:
Alright, applied. I've also merged in your spi-next tree. Let me know if
that causes problems because it needs to be rebased.
No problem - do you just want to take over the SPI tree again or should
I carry on applying things?
On Thu, Dec 06, 2012 at 11:35:47PM +, Grant Likely wrote:
Fix problem discovered with sparse:
+ drivers/spi/spi.c:1554:37: sparse: incompatible types in comparison
expression (different signedness)
drivers/spi/spi.c: In function 'spi_write_then_read':
drivers/spi/spi.c:1554:23: warning:
On Thu, Dec 06, 2012 at 12:00:26AM +, Grant Likely wrote:
Looks good to me. Probably 3.9 material though.
Acked-by: Grant Likely grant.lik...@secretlab.ca
Hrm, I'd be inclined to apply it now - it's isolated enough that it can
be reverted if it explodes and we have the -rc cycle to notice
we can dynamically allocate and in fact already have a fallback
to do so when there is contention for the fixed buffer remove this
restriction and instead dynamically allocate a suitably sized buffer if
the transfer won't fit.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
On Fri, Oct 05, 2012 at 05:51:11PM +0200, Ulf Hansson wrote:
From: Ulf Hansson ulf.hans...@linaro.org
This reverts commit 6887237cd7da904184dab2750504040c68f3a080.
Applied, thanks.
--
Everyone hates slow websites. So
On Sun, Oct 14, 2012 at 04:32:55AM +0200, Marek Vasut wrote:
In the current code implementing the MXS SPI driver, every transferred
message had assigned status = 0, which is not correct. Properly assign
status returned from the I/O functions.
Applied both, thanks.
On Wed, Oct 03, 2012 at 08:30:12AM +0900, Thomas Abraham wrote:
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare
calls as required by common clock framework.
Applied, thanks.
--
Everyone hates
On Wed, Oct 03, 2012 at 11:56:52AM +0200, Florian Fainelli wrote:
Hi Mark, Grant,
This small series contains cleanups and fixes that had already been previously
merged by Grant in his tree, but not pushed upstream. I am resending them
rebased on Mark's spi-next branch.
Applied all, thanks.
On Sun, Oct 07, 2012 at 06:19:44PM +0200, Daniel Mack wrote:
Allow D0 to be an input and D1 to be an output, configurable via
platform data and a new DT property.
Applied, thanks.
--
Everyone hates slow websites. So do
On Mon, Oct 08, 2012 at 04:39:40PM -0600, Stan Hu wrote:
McSPI driver previously assumed that D0 was input (MISO) and D1 was output
(MOSI).
This forces the hardware designer to wire all SPI peripherals in this way when
it should be a software configuration option.
I applied a similar patch
On Fri, Oct 12, 2012 at 04:42:53PM +0200, Ulf Hansson wrote:
Hi Mark,
Just a kind remember on this. Do you see any problem merging this?
Kind regards
Ulf Hansson
On 5 October 2012 09:43, Ulf Hansson ulf.hans...@stericsson.com wrote:
Don't top post and don't send contentless nags less
On Thu, Oct 11, 2012 at 02:24:03PM +0200, Florian Fainelli wrote:
I did not get any feedback from you on this, is it ok from your perspective?
My perspective is that you sent this in the merge window so there's no
rush to look at it until after the merge window.
On Thu, Aug 02, 2012 at 05:17:33PM +0900, Shimoda, Yoshihiro wrote:
Because the latest shdma driver changed, it caused build error in
the spi-rspi driver. This patch fixed the build error.
Applied, thanks. This should really have been done as part of the shdma
update...
On Fri, Aug 17, 2012 at 02:47:30PM +0300, Aaro Koskinen wrote:
Delete soon-obsolete e-mail address.
Applied, thanks.
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app
On Thu, Oct 04, 2012 at 10:04:39AM +0200, Ulf Hansson wrote:
From: Ulf Hansson ulf.hans...@linaro.org
This reverts commit 6887237cd7da904184dab2750504040c68f3a080.
This reverts is done due to earlier wrong commit, which is
also reverted. Revert spi/pl022: enable runtime PM
Why? Wrong
On Fri, Oct 05, 2012 at 02:21:15PM +0200, Linus Walleij wrote:
I think patch 1/3 and 2/3 needs to go into the -rc fixes.
Who's funneling this now? Grant or Mark?
Me still for the moment.
--
Don't let slow site
On Fri, Sep 28, 2012 at 01:09:25AM +0300, Nuutti Kotivuori wrote:
There seems to be no way to prevent the deactivation and reactivation of
the clock and everything between separate transfers - and a single
transfer is bounded in size and no progress is reported for it. Even
within a single
On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote:
Heard from Linus Walleij that you Mark has been helping out merging
spi patches, did not know that when sending out this series. Anyway,
do you guys see any issues merging this?
[PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable
On Wed, Oct 03, 2012 at 04:28:34PM +0200, Ulf Hansson wrote:
I will do a resend and include some explanation for the reverts in the
cover-letter.
It'd be good if the explanation could be in the commit logs so that
people reading history can understand things.
Mark Brown (4):
spi/gpio: Fix stub for spi_gpio_probe_dt()
Merge tag 'v3.6-rc6' into spi-drivers
Merge tag 'v3.6-rc6' into spi-mxs
Merge branches 'spi-drivers' and 'spi-mxs' into spi-next
Matt Porter (1):
spi: omap2-mcspi: add pinctrl support
Patrice Chotard (1
On Mon, Oct 01, 2012 at 03:11:41PM +0530, Laxman Dewangan wrote:
It will be great if this goes in k3.7 so that we can post the new
driver on K3.8.
Why would this make any difference to the ability to post a new version?
I do wish stop making up version numbers, it's very irritating. I
On Fri, Sep 28, 2012 at 10:15:48AM -0600, Stephen Warren wrote:
From: Stephen Warren swar...@nvidia.com
The current SPI driver has many issues. Examples are:
Applied, thanks.
--
Got visibility?
Most devs has no idea
On Wed, Sep 26, 2012 at 04:48:36PM +0200, Linus Walleij wrote:
This switches the PL022 SPI driver to use devm_* managed resources
for IRQ, clocks, ioremap and GPIO. Prior to this, the GPIOs would
even leak.
Applied, thanks.
On Wed, Sep 26, 2012 at 06:06:22PM +0200, Linus Walleij wrote:
This factors out the resource handling in runtime
suspend/resume and also calls it from the ordinary suspend
and resume hooks.
Applied, thanks.
--
Got
On Tue, Sep 25, 2012 at 01:21:57PM +0200, Dirk Behme wrote:
From: Knut Wohlrab knut.wohl...@de.bosch.com
There are SPI devices which need a SPI clock with active low polarity and
high inactive state.
Applied, thanks.
On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote:
On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar
SPI functional clock must be disalble/enable in non RTPM suspend/resume
hooks. Currently it is only done for RTPM cases.
This patch add support to disable/enbale clock for
On Mon, Sep 24, 2012 at 01:31:22PM +0200, Dirk Behme wrote:
Let me know if you can find above thread on one of the both mailing
lists. If not, I would be happy to resend it again.
Yes, of course - it's hard to apply patches from web archives.
On Mon, Sep 24, 2012 at 08:34:27AM +0200, Dirk Behme wrote:
Being not so familiar with the flow of SPI patches, I was told that you
are taking care of spi patches recently?
Do you like to have a look to this patch?
Well, nobody appears to have sent me a copy of it...
On Mon, Sep 17, 2012 at 04:51:20PM -0700, Guenter Roeck wrote:
The I2C core provides a means to instantiate devices from userspace
using sysfs attributes. Provide the same mechanism for SPI devices.
So, unlike I2C this is only going to work for a subset of controllers -
anything that relies on
On Thu, Sep 13, 2012 at 04:31:30PM +0200, Sylwester Nawrocki wrote:
When s3c64xx-spi is instantiated from device tree an instance of
struct s3c64xx_spi_csinfo is dynamically allocated in the driver.
Applied, thanks.
--
On Wed, Sep 19, 2012 at 02:23:46PM +0200, Linus Walleij wrote:
From: Patrice Chotard patrice.chot...@stericsson.com
Amend the PL022 pin controller to optionally take a pin control
handle and set the state of the pins to default on boot and
runtime resume, and to sleep at runtime suspend.
On Thu, Sep 20, 2012 at 10:43:46AM -0400, Matt Porter wrote:
Documentation/feature-removal-schedule.txt | 10 ++
1 file changed, 10 insertions(+)
We decided at kernel summit that we'd stop bothering with this, it's
mostly just bitrot and rarely read. I guess the ASoC driver update
FIFO.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can
FIFO.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can
On Thu, Sep 13, 2012 at 05:36:30PM -0600, Stephen Warren wrote:
Please note that I've applied this to Tegra's for-3.7/dmaengine branch,
even though it hasn't been ack'd by an ASoC maintainer.
Please don't apply this without review, we've got quite enough problems
with the dmaengine stuff as it
On Thu, Sep 06, 2012 at 05:50:07PM -0600, Stephen Warren wrote:
On 08/16/2012 08:13 AM, Laxman Dewangan wrote:
Remove the support code which uses the legacy APB DMA driver
for accessing the SPI FIFO.
The driver will use the dmaengine based APB DMA driver for
accessing reqding/writing to
On Fri, Sep 14, 2012 at 09:57:48AM -0600, Stephen Warren wrote:
On 09/06/2012 05:50 PM, Stephen Warren wrote:
I'd like to take this patch through the Tegra tree, since it relies on
the previous Tegra patches to convert to dmaengine. Could I please get
an ack if that's OK? Thanks.
I'm
On Fri, Sep 14, 2012 at 09:57:35AM -0600, Stephen Warren wrote:
On 09/06/2012 05:50 PM, Stephen Warren wrote:
I'd like to take this patch through the Tegra tree, since it relies on
the previous Tegra patches to convert to dmaengine. Could I please get
an ack if that's OK? Thanks.
I'm
On Fri, Sep 14, 2012 at 10:00:39AM -0600, Stephen Warren wrote:
But do note that I pinged 8 days ago for an ack, and received no
objections, and you were well aware that the bug was fixed since you
I didn't read these mails enough to notice that they were asking for an
ack, they were followups
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote:
Currently in omap2_mcspi_txrx_dma the tx and the rx support is
interleaved. Make the rx related code in omap2_mcspi_rx_dma
and the tx related code omap2_mcspi_tx_dma and call the functions.
Applied, thanks.
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote:
Currently in omap2_mcspi_txrx_dma the tx and the rx support is
interleaved. Make the rx related code in omap2_mcspi_rx_dma
and the tx related code omap2_mcspi_tx_dma and call the functions.
I'd ideally like some testing from the
The gpio_ was missing from the name. Add a name for the parameter while
we're at it since GCC warns.
Reported-by: Stephen Rothwell s...@canb.auug.org.au
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-gpio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
On Wed, Sep 05, 2012 at 11:04:35AM +0200, Daniel Mack wrote:
The spi-gpio driver currently assumes the chipselect gpio number is
stored in -controller_data of the device's static board information.
Applied both, thanks.
On Tue, Sep 04, 2012 at 04:40:14AM +0200, Marek Vasut wrote:
I humbly present fixes for further issues found in the SPI driver
for i.MX23/i.MX28.
Applied all, thanks.
--
Live Security Virtual Conference
Exclusive live
On Sat, Sep 01, 2012 at 06:33:08PM +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
devm free functions should not have to be explicitly used.
Applied, thanks.
--
Live Security Virtual Conference
On Mon, Sep 03, 2012 at 10:14:29AM +0200, Roland Stigge wrote:
The new chip select handling via GPIO introduced a pointer computation bug:
Applied, thanks.
--
Live Security Virtual Conference
Exclusive live event will
On Tue, Sep 04, 2012 at 04:58:35PM +0530, Sachin Kamat wrote:
module_spi_driver eliminates module_init and module_exit
calls and makes the code simpler.
Applied, thanks.
--
Live Security Virtual Conference
Exclusive
On Mon, Sep 03, 2012 at 01:50:34PM +0200, Linus Walleij wrote:
On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack zon...@gmail.com wrote:
Hmm, I don't know whether anyone took those patches yet? Mark?
Mark better take them, ping on Mark.
IIRC I did reply saying that the patches didn't apply for
On Fri, Aug 24, 2012 at 04:34:18AM +0200, Marek Vasut wrote:
Restart the SSP block in case the SSP transfer failed in any way.
The block hung in some cases otherwise.
Applied, thanks.
--
Live Security Virtual
On Fri, Aug 24, 2012 at 04:56:27AM +0200, Marek Vasut wrote:
The init_completion() call does reinit not only the variable carrying
the flag that the completion finished, but also initialized the
waitqueue associated with the completion. On the contrary, the
INIT_COMPLETION() call only reinits
On Thu, Aug 23, 2012 at 08:08:47PM -0700, Guenter Roeck wrote:
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. The remove function accesses the freed memory after
On Fri, Aug 24, 2012 at 04:42:41AM +0200, Marek Vasut wrote:
This allows user to select the slave mode of operation of the controller.
This is by no means standard, see the binding documentation for details,
there is plenty of them. Sadly, such knowledge is not provided in the chip
On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause subsequent
module unload attempts to fail. Drop the calls.
Applied, thanks.
On Fri, Aug 24, 2012 at 11:03:02AM -0700, Guenter Roeck wrote:
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is complete; it reduces the device reference count to zero, which results in
device memory being freed. The remove function accesses the freed memory after
On Fri, Aug 24, 2012 at 01:37:39PM -0700, Guenter Roeck wrote:
For some reason most spi drivers have similar problems. I learned it
the hard way when I tested my own driver, and decided to fix as many
drivers as I can. Which is why you see all those patches from me
lately.
It's not exactly
On Thu, Aug 16, 2012 at 08:25:59PM -0700, Guenter Roeck wrote:
The call sequence spi_alloc_master/spi_register_master/spi_unregister_master
is
complete; it reduces the device reference count to zero, which and results in
device memory being freed. The subsequent call to spi_master_put is
On Fri, Aug 17, 2012 at 05:28:41PM +0200, Linus Walleij wrote:
From: Michel JAOUEN michel.jao...@stericsson.com
amba drivers does not need to enable pm runtime at probe.
amba_probe already enables pm runtime.
This rids this warning in the ux500 boot log:
ssp-pl022 ssp0: Unbalanced
On Thu, Aug 16, 2012 at 08:49:30PM +0530, Shubhrajyoti D wrote:
Remove the call of platform_set_drvdata(pdev, NULL) as they are not
needed anymore.
Applied, thanks. These calls were never *needed* people just like to
put them in.
On Thu, Aug 16, 2012 at 12:44:38PM +0200, Tobias Klauser wrote:
platform_set_drvdata expects a void *, so pass NULL instead of 0.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
Better yet, remove these calls - they're completely redundant.
On Wed, Aug 15, 2012 at 08:09:07AM -0500, Rob Herring wrote:
On 08/15/2012 02:30 AM, Tobias Klauser wrote:
Instead of having to define the match table to NULL if CONFIG_OF isn't
set, use the of_match_ptr() macro which will do this for us.
Signed-off-by: Tobias Klauser tklau...@distanz.ch
On Wed, Aug 15, 2012 at 09:30:28AM +0200, Tobias Klauser wrote:
Instead of having to define the match table to NULL if CONFIG_OF isn't
set, use the of_match_ptr() macro which will do this for us.
Applied, thanks.
--
On Fri, Aug 10, 2012 at 01:56:27PM -0700, Guenter Roeck wrote:
The call to spi_unregister_master() in the device remove function frees device
memory, and with it any device local data. However, device local data is still
accessed after the call to spi_unregister_master().
Applied, thanks.
On Fri, Aug 03, 2012 at 05:26:05PM +0200, Marek Vasut wrote:
This patchset adds SPI master support for Freescale i.MX233/i.MX28.
This is rebased on top of next-20120713. Please consider applying,
bugs shall now be squashed during the previous two review rounds.
Do we have any ETA for review
On Fri, Aug 03, 2012 at 10:08:12AM +0530, Sachin Kamat wrote:
Silences the following sparse warnings:
drivers/spi/spi-s3c64xx.c:1482:32: warning:
Applied, thanks.
--
Live Security Virtual Conference
Exclusive live
On Wed, Aug 01, 2012 at 10:57:17PM +0200, Daniel Mack wrote:
The spi-gpio driver currently assumes the chipselect gpio number is
stored in -controller_data of the device's static board information.
Applied both, thanks. It's a bit sad that we need an explict property
for num-chipselects
On Thu, Aug 02, 2012 at 04:41:25PM +0530, Shubhrajyoti D wrote:
The kfree() is taken care of by the spi core (spi_master_release() function)
that is called once the last reference to the underlying struct device has
been released. So the driver need not call kfree.
Applied, thanks.
On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote:
It'd be nice to only keep the clocks enabled while doing transfers but
again totally non-essential.
Hm, this is spread across mxs. Shawn, is there any plan for PM implementation
for MXS ?
Take a look at s3c64xx - I did
On Mon, Jul 23, 2012 at 10:40:48PM +0200, Marek Vasut wrote:
This is slightly reworked version of the SPI driver.
Support for DT has been added and it's been converted
to queued API.
Looks reasonable overall.
+ bits_per_word = dev-bits_per_word;
+ if (t t-bits_per_word)
+
On Mon, Jul 23, 2012 at 10:40:50PM +0200, Marek Vasut wrote:
+ /*
+ * Small blocks can be transfered via PIO.
+ * Measured by empiric means:
+ *
+ * dd if=/dev/mtdblock0 of=/dev/null bs=1024k count=1
+ *
+
On Wed, Jul 25, 2012 at 01:44:11PM +0200, Daniel Mack wrote:
The spi-gpio driver currently assumes the chipselect gpio number is
stored in -controller_data of the device's static board information.
Always CC maintainers on things... you've not CCed Grant or Linus W,
and for now I'm handling
On Wed, Jul 25, 2012 at 10:00:18PM +0200, Daniel Mack wrote:
I don't know what's wrong here, but clearly, the message in my inbox has
To: spi-devel-general@lists.sourceforge.net
Cc: grant.lik...@secretlab.ca,
rob.herr...@calxeda.com,
devicetree-disc...@lists.ozlabs.org,
On Wed, Jul 18, 2012 at 12:09:54AM +0200, Marek Vasut wrote:
On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote:
Always CC maintainers, and in this case me as well (I'm collecting SPI
patches for this release since Grant's mostly offline).
Ah, I wasn't aware you're the SPI
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus
depriving the caller of information and breaking automatic probe deferral
pushing back from the GPIO level. Also reformat the non-DT log message
so it's not word wrapped and we can grep for it.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c |9
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
Acked-by: Linus Walleij linus.wall...@linaro.org
---
drivers/spi/spi-s3c64xx.c | 18 +-
1 file changed, 1
to configure them.
Without this fix Cragganmore systems can't talk to their SPI devices.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi
On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote:
This patchset adds SPI master support for Freescale i.MX233/i.MX28.
This is rebased on top of next-20120713. Please consider applying,
bugs shall now be squashed during the previous two review rounds.
Always CC maintainers, and in
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote:
The set_level callback in the controller data, which is used to configure
the slave select line, cannot be supported when migrating the driver to
device tree based discovery. Since all the platforms currently use gpio
as the slave
On Thu, Jul 05, 2012 at 09:45:40AM +0200, Uwe Kleine-K?nig wrote:
On Thu, Feb 09, 2012 at 10:21:45PM +0100, Uwe Kleine-K?nig wrote:
The chip select line was configured as output with the initial value
being active explicitly. It was later deasserted during
spi_bitbang_setup() without any
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Linus
Saves some error handling and a small amount of code.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi/spi-s3c64xx.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
They have very few users and they're both just doing a single register
write so the advantage of having the macro is a bit limited. An inline
function might make sense but it's as easy to just do the writes directly.
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
drivers/spi
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote:
+- gpios: The gpio specifier for clock, mosi and miso interface lines (in no
+ particular order). The format of the gpio specifier depends on the gpio
+ controller.
This seems odd... This isn't a bitbanging controller, and
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote:
+ s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1);
Shouldn't we just set the name in the struct platform_device rather than
requiring the machine to pass it through by hand?
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote:
With the addition of platform specific driver data in the spi-s3c64xx
driver, the device name of spi controllers are changed. Accordingly,
update the device name of spi clocks instances.
This should've been squashed into the patch
1 - 100 of 164 matches
Mail list logo
