Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-11 Thread Sylwester Nawrocki
On 10/06/14 22:32, Rob Herring wrote: > On Tue, Jun 10, 2014 at 1:09 PM, Doug Anderson wrote: >> Naveen / Sylwester, >> >> On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch >> wrote: Can we support both "cs-gpio" and "cs-gpios" for backward compatibility ? After your change all DTBs us

Re: [PATCH 1/2 v2] spi: s3c64xx: use "cs-gpios" from spi node instead of "cs-gpio"

2014-06-10 Thread Sylwester Nawrocki
On 10/06/14 12:08, Naveen Krishna Chatradhi wrote: > Currently, spi-s3c64xx.c needs "cs-gpio" chip select GPIO to be > defined under "controller-data" node under each slave node. > > &spi_x { > cs-gpios <>; > ... > slave_node { > > controller-data { >

[PATCH RESEND] spi: s3c64xx: Fix pm_runtime_get_sync() return value check

2013-06-10 Thread Sylwester Nawrocki
] spi_master spi1: failed to prepare transfer hardware Likely because the driver uses synchronous API to runtime enable the device and asynchronous one to disable it. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- I used broo...@kernel.org e-mail address this time, as found in

[PATCH] spi: s3c64xx: Don't free controller_data on non-dt platforms

2012-09-13 Thread Sylwester Nawrocki
attempt to kfree controller_data when it was externally provided through the board code. Fix this by freeing controller_data only when dev->of_node is not null. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+)

Re: [PATCH] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Sylwester Nawrocki
Hi, On 07/05/2012 02:33 PM, Mark Brown wrote: > Saves some error handling and a small amount of code. > > Signed-off-by: Mark Brown > Acked-by: Linus Walleij Reviewed-by: Sylwester Nawrocki -- Regard

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Sylwester Nawrocki
On 07/04/2012 06:11 PM, Mark Brown wrote: > Saves some error handling and a small amount of code. > > Signed-off-by: Mark Brown > Acked-by: Linus Walleij > --- > drivers/spi/spi-s3c64xx.c | 25 + > 1 file changed, 1 insertion(+), 24 deletions(-) > > diff --git a/drive

Re: [PATCH] spi: Add the use of DMA config operation

2012-02-08 Thread Sylwester Nawrocki
of ‘req’ isn’t known drivers/spi/spi-s3c64xx.c:302: warning: unused variable ‘req’ Which tree has it been created off of ? It seems there are some patches not yet in mainline that it depends on. Thanks, -- Sylwester Na

[PATCH v2] spi: Add spi-s3c64xx driver dependency on ARCH_EXYNOS4

2012-01-25 Thread Sylwester Nawrocki
The spi-s3c64xx driver is also used on Exynos4 so update the dependency to enable build on those platforms. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- Resending with Jaswinder Singh e-mail address, which is not valid any more, removed. My apologies for the noise

[PATCH] spi: Add spi-s3c64xx driver dependency on ARCH_EXYNOS4

2012-01-25 Thread Sylwester Nawrocki
The spi-s3c64xx driver is also used on Exynos4 so update the dependency to enable build on those platforms. Cc: Jaswinder Singh Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/spi/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 04:29 PM, Mark Brown wrote: > On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: >> On 01/21/2012 02:24 PM, Mark Brown wrote: > >>> - int ret; >>> + int ret, irq; >>> + char clk_name[16]; > >> clk_name seems to

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:24 PM, Mark Brown wrote: > Although the hardware supports interrupts we're not currently using them > at all since for small transfers the overhead is greater than that for > busy waiting and for large transfers we have interrupts from the DMA. > This means that if the hardware rep