Re: [PATCH] spi: s3c64xx: add missing check for polling mode

2013-07-02 Thread Girish KS
On Thu, Jun 27, 2013 at 4:45 PM, Mark Brown broo...@kernel.org wrote: On Thu, Jun 27, 2013 at 12:26:53PM +0530, Girish K S wrote: After the patch spi/s3c64xx: Fix non-dmaengine usage with commit id 563b444e33810f3120838620c990480304e24e63 submitted by Mark Brown, the spi device detection in

Re: [PATCH v1 0/3] Polling support for s3c64xx spi controller

2013-06-09 Thread Girish KS
Hello Mark, pls let me know if there is any issue with this series On Mon, May 20, 2013 at 12:21 PM, Girish K S girishks2...@gmail.com wrote: This patch series adds support for the polling mode only. Also 2nd patch in the series adds support for dedicated cs pin. After Thomas's patch for

Re: [PATCH V4 2/5] spi: s3c64xx: added support for polling mode

2013-04-17 Thread Girish KS
On Tue, Apr 16, 2013 at 5:42 PM, Mark Brown broo...@kernel.org wrote: On Tue, Apr 16, 2013 at 04:58:47PM +0530, Girish KS wrote: On Tue, Apr 16, 2013 at 4:50 PM, Mark Brown broo...@kernel.org wrote: I'm missing patch 1 of this series. its already merged to stable tree after your review

Re: [PATCH V4 2/5] spi: s3c64xx: added support for polling mode

2013-04-16 Thread Girish KS
On Tue, Apr 16, 2013 at 4:50 PM, Mark Brown broo...@kernel.org wrote: On Mon, Apr 15, 2013 at 02:10:27PM +0530, Girish K S wrote: From: Girish K S girishks2...@gmail.com The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 13, 2013 at 12:13:33PM +0530, Girish K S wrote: From: Girish K S girishks2...@gmail.com The existing driver supports gpio based /cs signal. For controller's that have one device per controller,

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Apr 08, 2013 at 03:21:03PM +0530, Girish KS wrote: On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown It's also a bit odd that we end up checking cs_gpio and then using line in the code, it'd be more

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 5:15 PM, Girish KS girishks2...@gmail.com wrote: On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Apr 08, 2013 at 03:21:03PM +0530, Girish KS wrote: On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown It's also a bit odd that we end

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 5:50 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Apr 08, 2013 at 05:15:26PM +0530, Girish KS wrote: On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown Two options here, one is to just assume nobody will use GPIO 0 and the other is to set the number

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Mar 13, 2013 at 12:13:31PM +0530, Girish K S wrote: Some SoC's that adopt this controller might not have have dma interface. This patch adds support for complete polling mode and gives flexibity for

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Wed, Apr 3, 2013 at 5:19 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Apr 03, 2013 at 05:00:04PM +0530, Girish KS wrote: On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown - if (!sdd-pdev-dev.of_node) { + if (!sdd-pdev-dev.of_node !is_polling(sdd

Re: [PATCH V3 0/5] Add polling support for 64xx spi controller

2013-03-24 Thread Girish KS
Hello grant, any comments on this patch series? On Wed, Mar 13, 2013 at 12:13 PM, Girish K S girishks2...@gmail.com wrote: [PATCH 1/5]: fixes the error handling in the interrupt handler [PATCH 2/5]: The existing driver support partial polling mode. This patch modifies the

Re: [PATCH V2 3/5] spi: s3c64xx: Added provision for non-gpio i/o's

2013-03-11 Thread Girish KS
On Sun, Mar 3, 2013 at 4:26 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, 13 Feb 2013 12:03:46 -0800, Girish K S girishks2...@gmail.com wrote: Currently the drivers supports only the GPIO based i/o pins. But there are Exynos SoC's that use the same controller with dedicated i/o

Re: [PATCH V2 2/5] spi: s3c64xx: added support for polling mode

2013-03-03 Thread Girish KS
On Sun, Mar 3, 2013 at 4:28 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, 13 Feb 2013 12:03:45 -0800, Girish K S girishks2...@gmail.com wrote: The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved in polling mode.

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Thu, Feb 7, 2013 at 5:04 PM, Girish KS girishks2...@gmail.com wrote: On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 6, 2013 at 8:12 PM, Girish KS girishks2...@gmail.com wrote: On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Fri, Feb 8, 2013 at 12:33 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 07 of February 2013 09:46:58 Girish KS wrote: On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Girish, On Wednesday 06 of February 2013 12:12:29 Girish KS wrote: On Wed, Feb 6

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Fri, Feb 8, 2013 at 12:58 AM, Girish KS girishks2...@gmail.com wrote: On Fri, Feb 8, 2013 at 12:33 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Thursday 07 of February 2013 09:46:58 Girish KS wrote: On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Girish

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-07 Thread Girish KS
On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa t.f...@samsung.com wrote: Hi Girish, On Wednesday 06 of February 2013 12:12:29 Girish KS wrote: On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S girishks2...@gmail.com

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-07 Thread Girish KS
On Thu, Feb 7, 2013 at 3:55 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote: This patch adds support for spi controllers with dedicated clk/miso/mosi/cs pins. It skips the gpio parsing and initialization for controllers that

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-07 Thread Girish KS
On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 6, 2013 at 8:12 PM, Girish KS girishks2...@gmail.com wrote: On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S girishks2

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S girishks2...@gmail.com wrote: The status of the interrupt is available in the status register, so reading the clear pending register and writing back the same value will

Re: [PATCH 2/4] spi: s3c64xx: added support for polling mode

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:35 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:42 -0800, Girish K S girishks2...@gmail.com wrote: The 64xx spi driver supports partial polling mode. Only the last chunk of the transfer length is transferred or recieved in polling mode.

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:40 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:43 -0800, Girish K S girishks2...@gmail.com wrote: This patch adds support for spi controllers with dedicated clk/miso/mosi/cs pins. It skips the gpio parsing and initialization for

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Feb 6, 2013 at 8:12 PM, Girish KS girishks2...@gmail.com wrote: On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S girishks2