Re: [PATCH v5 0/6] OMAP: McSPI: Hwmod adaptation + runtime conversion

2011-01-25 Thread Govindraj
On Tue, Jan 25, 2011 at 3:56 AM, Kevin Hilman khil...@ti.com wrote: Hi Govindraj, Govindraj.R govindraj.r...@ti.com writes: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 2) McSPI driver hwmod adaptation with cleanup of base address    macros and using omap

Re: [PATCH v3 4/6] OMAP4: hwmod data: Add McSPI

2011-01-17 Thread Govindraj
On Mon, Jan 17, 2011 at 9:59 PM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Update omap4 hwmod file with McSPI info. Signed-off-by: Benoit Cousson b-cous...@ti.com Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Govindraj.R govindraj.r...@ti.com

Re: [PATCH 7/7 v2] OMAP: runtime: McSPI driver runtime conversion

2011-01-11 Thread Govindraj
merge this through the OMAP tree. None of my comments are showstoppers, so I'm even fine with merging them as-is as long as followup patches are posted to address the comments. Govindraj, since we've missed 2.6.38 for this series, I'd like to see the last few minor issues cleaned up before

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-28 Thread Govindraj
Hi Grant, On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R govindraj.r...@ti.com wrote: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 1) McSPI driver hwmod adaptation with cleanup of base address   macros and using omap-device API's. 2) Runtime Conversion of McSPI

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-17 Thread Govindraj
On Thu, Dec 16, 2010 at 11:47 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Govindraj, Raja, Govindraj govindraj.r...@ti.com writes: On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman khil...@deeprootsystems.com wrote:     Govindraj.R govindraj.r...@ti.com writes:     Changes

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-16 Thread Raja, Govindraj
Hi Kevin, On Wed, Dec 15, 2010 at 9:42 PM, Kevin Hilman khil...@deeprootsystems.comwrote: Govindraj.R govindraj.r...@ti.com writes: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 1) McSPI driver hwmod adaptation with cleanup of base address macros and

Re: [PATCH 0/7 v2] OMAP: McSPI: Hwmod adaptation + runtime conversion

2010-12-08 Thread Govindraj
On Wed, Dec 1, 2010 at 7:31 PM, Govindraj.R govindraj.r...@ti.com wrote: Changes invloves: 1) Addition of hwmod data for omap2/3/4. 1) McSPI driver hwmod adaptation with cleanup of base address   macros and using omap-device API's. 2) Runtime Conversion of McSPI driver Any

Re: [PATCH 5/5] OMAP McSPI: Adapt McSPI driver to use omap hwmod

2010-09-03 Thread Govindraj
apis while implementing it in HWMOD FW way. Hi Govindraj, Some comments below.  Short version is that this patch seems to lump a number of (mostly) unrelated changes (the register map, HWMOD stuff, and runtime pm) that makes it hard to review and understand.  I could use some help understanding