Doug Anderson wrote:
Mark or Kukjin,
Hi,
On Thu, Jun 12, 2014 at 8:59 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
Since, (3146bee spi: s3c64xx: Added provision for dedicated cs pin)
spi-s3c64xx.c driver expects
1. chip select gpios from cs-gpio(singular) under the
Mark Brown wrote:
Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
Acked-by: Kukjin Kim kgene@samsung.com
---
drivers/spi/spi-s3c64xx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index
ad93231..6495352
dma_transfer_direction' [-
Wenum-compare]
Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Ben Dooks ben-li...@fluff.org
Cc: Kukjin Kim kgene@samsung.com
Acked-by: Kukjin Kim kgene@samsung.com
BTW, don't we need following accordingly?
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers
this by freeing
controller_data only when dev-of_node is not null.
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
Yes, correct. Need to check it.
Acked-by: Kukjin Kim kgene@samsung.com
Thanks.
Best regards,
Kgene.
--
Kukjin
\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Acked-by: Kukjin Kim kgene@samsung.com
(Cc'ed Mark Brown who is handling spi for a moment
Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause
subsequent
module unload attempts to fail. Drop the calls.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Kukjin Kim kgene
,
+ gpio, ret);
goto free_gpio;
}
}
--
1.7.10.4
Mark, thanks for your re-work 3th and 4th patches in this series :-)
Looks good to me, applied this series.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com
tree? Because for samsung
spi dt, the file has been touched in samsung tree so it helps to avoid bad
conflicts.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd
Thomas Abraham wrote:
On 13 July 2012 19:12, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 16:58, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas
Thomas Abraham wrote:
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems occur
following build error with s3c6400_defconfig.
drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares':
drivers/spi/spi
Thomas Abraham wrote:
On 13 July 2012 16:58, Kukjin Kim kgene@samsung.com wrote:
Thomas Abraham wrote:
On 13 July 2012 04:08, Kukjin Kim kgene@samsung.com wrote:
Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems
occur
following build error
branch with
Grant's spi/next branch merged. I will check with your spi-next
branch. Thanks.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd
just to ensure that nothing is broken.
OK, great - then the Samsung tree it is.
Thanks, will apply.
Mark, if you want to add your ack or review on them, let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung
drivers/spi/spi-s3c64xx.c:1098: error: for each function it appears in.)
make[3]: *** [drivers/spi/spi-s3c64xx.o] Error 1
make[2]: *** [drivers/spi] Error 2
+ dma_data-dma_prop = prop;
+ return 0;
+}
[snip]
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior
.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat
Looks good to me but need to ack on spi patch in this series. I think, this
series should be picked up together.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd
Boojin Kim wrote:
Mark Brown wrote
This patch uses config() function to configure DMA transmit options.
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
Thanks for your ack and let me pick this up in Samsung tree.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com
as a prefix even though we have another s3c24xx spi driver now.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
Live Security
not sure Grant is ok on this.
Grant, this looks ok to me and I'd like to apply this in samsung tree.
So if any problem to send this via samsung tree, please let me know.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung
-gpd8_9_10.c
delete mode 100644 arch/arm/plat-s3c24xx/spi-bus1-gpg5_6_7.c
--
1.7.2.3
Looks good :)
Applied in my cleanup-s3c24xx, thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd
Kukjin Kim wrote:
Grant Likely wrote:
On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote:
Kukjin Kim wrote:
Thanks Grant, Jassi and all,
I will apply these 1 and 2 in my -fix tree for 3.0 with your acks.
Oops, this needs previous 'cleanup spi platform
Grant Likely wrote:
On Wed, Jul 06, 2011 at 03:22:08PM +0900, Kukjin Kim wrote:
Kukjin Kim wrote:
Grant Likely wrote:
On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote:
Kukjin Kim wrote:
Thanks Grant, Jassi and all,
I will apply these 1
both patches go through the samsung tree:
Acked-by: Grant Likely grant.lik...@secretlab.ca
Thanks Grant, Jassi and all,
I will apply these 1 and 2 in my -fix tree for 3.0 with your acks.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution
Kukjin Kim wrote:
Grant Likely wrote:
On Mon, Jul 4, 2011 at 12:55 AM, Grant Likely
grant.lik...@secretlab.ca
wrote:
On Fri, Jul 01, 2011 at 11:43:08AM +0530, Jassi Brar wrote:
On Fri, Jul 1, 2011 at 11:29 AM, padma venkat padma@gmail.com
wrote:
Hi Jassi,
On Fri, Jul
it directly into spi/next without a
topic branch.
Hi Grant,
I agree with you, it is not expected this makes some conflicts between spi
and samsung tree.
I think Ben's ack is enough on this, if required,
Acked-by: Kukjin Kim kgene@samsung.com
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene
Grant Likely wrote:
On Mon, Jul 04, 2011 at 07:08:55PM +0900, Kukjin Kim wrote:
Kukjin Kim wrote:
Thanks Grant, Jassi and all,
I will apply these 1 and 2 in my -fix tree for 3.0 with your acks.
Oops, this needs previous 'cleanup spi platform specific code' so can't
apply
Grant Likely wrote:
On Wed, Jan 12, 2011 at 03:00:23PM +0900, Kukjin Kim wrote:
From: Abhilash Kesavan a.kesa...@samsung.com
This patch enables the existing S3C64XX series SPI driver for S5P64X0
and removed dependency on EXPERIMENTAL because we don't need it now.
Signed-off
Brar jassi.b...@samsung.com
Signed-off-by: Kukjin Kim kgene@samsung.com
---
Changes since v1:
- Removed dependency on EXPERIMENTAL
Hi David and Grant,
I missed that send to you when I have got this via Linux Samsung SoC mailing
list.
Hmm...I know, it's 38 merge winodw...so I'm not sure can
Brar jassi.b...@samsung.com
Signed-off-by: Kukjin Kim kgene@samsung.com
---
Changes since v2:
- Changed dependency of S3C64XX_DMA
Changes since v1:
- Removed dependency on EXPERIMENTAL
(Following is same with previous patch v2)
Hi David and Grant,
I missed that send to you when I have got
29 matches
Mail list logo
