Re: [PATCH] spi: spi-rspi: add dmaengine supporting

2012-04-19 Thread Paul Mundt
On Thu, Apr 19, 2012 at 07:22:53PM +0900, Shimoda, Yoshihiro wrote: +static struct dma_async_tx_descriptor *rspi_dma_prep_sg(struct scatterlist *sg, + void *buf, unsigned len, struct dma_chan *chan, + enum dma_transfer_direction dir) +{

Re: [PATCH] spi: spi-sh: add IORESOURCE_MEM_TYPE_MASK decoding for access size

2012-01-26 Thread Paul Mundt
On Thu, Jan 26, 2012 at 05:43:57PM +0900, Shimoda, Yoshihiro wrote: This SPI controller's access size is 32, or 8-bit. The previous driver supported 32-bit only. So, this patch adds IORESOURCE_MEM_TYPE_MASK decoding, an then, the driver can handle the SPI controller of 8-bit. This patch also

Re: [PATCH] spi: spi-sh: add IORESOURCE_MEM_TYPE_MASK decoding for access size

2012-01-26 Thread Paul Mundt
On Fri, Jan 27, 2012 at 10:14:49AM +0900, Shimoda, Yoshihiro wrote: 2012/01/26 19:22, Paul Mundt wrote: On Thu, Jan 26, 2012 at 05:43:57PM +0900, Shimoda, Yoshihiro wrote: [ snip ] static void spi_sh_set_bit(struct spi_sh_data *ss, unsigned long val, @@ -464,6 +473,18 @@ static int

Re: [PATCH 1/3] SPI: spi_sh_msiof: cosmetic clean-up

2011-01-24 Thread Paul Mundt
On Mon, Jan 24, 2011 at 10:26:55PM -0700, Grant Likely wrote: On Mon, Jan 24, 2011 at 10:02 PM, Simon Horman ho...@verge.net.au wrote: Surely this is a bug in diff. Or perhaps put more politely, diff isn't smart enough to realise a) this is C and b) xxx: isn't a valid function name in C.

Re: [PATCH 3/3] SPI: spi_sh_msiof: fix wrong address calculation, which leads to an Oops

2011-01-21 Thread Paul Mundt
On Fri, Jan 21, 2011 at 09:27:43AM -0700, Grant Likely wrote: On Fri, Jan 21, 2011 at 04:56:47PM +0100, Guennadi Liakhovetski wrote: NULL + small offset != NULL, but reading from that small offset address is usually not a very good idea and often leads to problems, like kernel Oopses in

Re: [spi-devel-general] [GIT PULL] sh updates for 2.6.33-rc7

2010-02-02 Thread Paul Mundt
On Tue, Feb 02, 2010 at 01:17:49AM -0700, Grant Likely wrote: On Mon, Feb 1, 2010 at 9:06 PM, Paul Mundt let...@linux-sh.org wrote: Please pull from: ? ? ? ?master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git sh/for-2.6.33 Which contains: Magnus Damm (1): ? ? ?usb

Re: [spi-devel-general] [PATCH] spi: SuperH MSIOF SPI Master driver

2009-11-25 Thread Paul Mundt
On Wed, Nov 25, 2009 at 12:11:52PM -0800, Andrew Morton wrote: On Tue, 24 Nov 2009 21:55:31 +0900 Magnus Damm magnus.d...@gmail.com wrote: +struct sh_msiof_spi_priv { + struct spi_bitbang bitbang; /* must be first for spi_bitbang.c */ Well if that's the case then spi_bitbang.c needs

Re: [spi-devel-general] [RFT PATCH] SuperH HSPI controller driver.

2008-08-03 Thread Paul Mundt
On Mon, Jul 21, 2008 at 11:07:44AM +0200, Manuel Lauss wrote: Here is a very simple driver for the HSPI block on many SuperH processors. I could only subject it to limited testings, as my sole SPI device here is a write-only 8bit digital poti. It seems to do the right thing as far as I could

Re: [spi-devel-general] [RFT PATCH] SuperH HSPI controller driver.

2008-07-21 Thread Paul Mundt
On Mon, Jul 21, 2008 at 11:07:44AM +0200, Manuel Lauss wrote: +out2: + release_resource(priv-ioarea); + kfree(priv-ioarea); What is this kfree() for? +static int __devexit hspi_remove(struct platform_device *pdev) +{ + struct hspi_priv *priv = platform_get_drvdata(pdev); + +