Re: [PATCH 1/2 v2] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Sylwester Nawrocki
On 10/06/14 22:32, Rob Herring wrote:
 On Tue, Jun 10, 2014 at 1:09 PM, Doug Anderson diand...@chromium.org wrote:
 Naveen / Sylwester,

 On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch
 naveenkrishna...@gmail.com wrote:
 Can we support both cs-gpio and cs-gpios for backward compatibility ?
 After your change all DTBs using the original pattern will not work with
 new kernels any more. At least I would expect such backward compatibility
 maintained for few kernel releases.

 The reason behind removing the cs-gpio or not providing backward
 compatibility was

 1. Since spi-core started using cs-gpios string from spi device node
 several months ago.
   The spi-s3c64xx.c driver is partially broken for more than 6 months.

 2. Supporting cs-gpio would add extra bit of code.

 I've corrected the dts files that were using cs-gpio under
 controller-data(child node)
 to use cs-gpio from spi device node (parent node).

Normally properties get removed from existing dts files and then
marked in the binding documentation as deprecated.  Or least in the
commit messages it would be good to have clearly explained what was
replaced with what and what were the main reasons.  This is especially
useful for out-of-tree dts files, when you port a board to newer
kernel, things suddenly stop working and you're left with little
or no clue why.

 I will make another version if you insist.

I'm OK with dropping the old binding, I'm generally not a proponent
of a strict DT backward compatibility.  But we _must_ have things
documented properly, so it all doesn't turn into a debugging nightmare.

 Yup, as near as I can tell this has been broken since (3146bee spi:
 s3c64xx: Added provision for dedicated cs pin).  That landed June 25th
 of 2013 into the SPI tree.

 ...so clearly nobody was really testing Samsung's SPI driver on ToT
 Linux.  1 year of unnoticed brokenness seems like enough time that we
 could do away with the old code.  If someone comes out of the woodwork
 and claims a dire need to support the old binding then it can be added
 then.

 In-tree users of this appear to be:

 arch/arm/boot/dts/exynos4210-smdkv310.dts:
  cs-gpio = gpc1 2 0;
 arch/arm/boot/dts/exynos4412-trats2.dts:
  cs-gpio = gpb 5 0;
 arch/arm/boot/dts/exynos5250-smdk5250.dts:
  cs-gpio = gpa2 5 0;

 ...and I guess nobody has bothered using the SPI flash on those boards
 for the last year?

I guess the SMDK boards are not really well maintained now.  I've got a
working kernel for trats2 based on v3.15-rc4, the SPI is working fine
there, despite the offending commit you point out.

It seems the GPB[5]/SPI_1_nSS pin is in the reset default state, i.e.
an input with pull down enabled (gpb-5 is not a part of the SPI
interface pinctrl group).  So in case we don't pass the CS GPIO in the
SPI controller node or the driver doesn't handle it properly for any
other reason the chip select signal is always active and the SPI
communication works.

 I always try to warn people if they are breaking compatibility, but in
 this case I agree it is okay. Presumably no one expects BSD or vxworks
 support for this platform either?
 
 For the binding change:
 
 Acked-by: Rob Herring r...@kernel.org
 
 Rob

--
Thanks,
Sylwester

--
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing  Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH 1/2 v2] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-10 Thread Sylwester Nawrocki
On 10/06/14 12:08, Naveen Krishna Chatradhi wrote:
 Currently, spi-s3c64xx.c needs cs-gpio chip select GPIO to be
 defined under controller-data node under each slave node.
 
 spi_x {
   cs-gpios ;
   ...
   slave_node {
 
   controller-data {
   cs-gpio = ;
   ...
   };
   ...
   };
   ...
 };
 
 Where as, SPI core and many other drivers uses cs-gpios for
 from device tree node.
 
 Hence, make changes in spi-s3c64xx.c driver to make use of
 cs-gpios from SPI node(parent) instead of cs-gpio defined in
 slaves controller-data(child) node.
 
 Also updates the Device tree Documentation.
 
 Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
 Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk
 Cc: Doug Anderson diand...@chromium.org
 ---
 Changes since v1:
 1. fixed a compilation warning thus squashing the other patch into this.
 2. Updated device tree description in spi-samsung.txt
 
  .../devicetree/bindings/spi/spi-samsung.txt|8 ++-
  drivers/spi/spi-s3c64xx.c  |   56 
 
  2 files changed, 38 insertions(+), 26 deletions(-)
 
 diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt 
 b/Documentation/devicetree/bindings/spi/spi-samsung.txt
 index 86aa061..13bfcb5 100644
 --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt
 +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt
 @@ -42,15 +42,13 @@ Optional Board Specific Properties:
  - num-cs: Specifies the number of chip select lines supported. If
not specified, the default number of chip select lines is set to 1.
  
 +- cs-gpios: should specify GPIOs used for chipselects (see spi-bus.txt)
 +
  SPI Controller specific data in SPI slave nodes:
  
  - The spi slave nodes should provide the following information which is 
 required
by the spi controller.
  
 -  - cs-gpio: A gpio specifier that specifies the gpio line used as
 -the slave select line by the spi controller. The format of the gpio
 -specifier depends on the gpio controller.
 -
- samsung,spi-feedback-delay: The sampling phase shift to be applied on the
  miso line (to account for any lag in the miso line). The following are 
 the
  valid values.
 @@ -85,6 +83,7 @@ Example:
   #size-cells = 0;
   pinctrl-names = default;
   pinctrl-0 = spi0_bus;
 + cs-gpios = gpa2 5 1 0 3;

While at it, please change the GPIO specifier format, this one is not
valid any more.

   w25q80bw@0 {
   #address-cells = 1;
 @@ -94,7 +93,6 @@ Example:
   spi-max-frequency = 1;
  
   controller-data {
 - cs-gpio = gpa2 5 1 0 3;
   samsung,spi-feedback-delay = 0;
   };
  
 diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
 index 75a5696..4594dde 100644
 --- a/drivers/spi/spi-s3c64xx.c
 +++ b/drivers/spi/spi-s3c64xx.c
 @@ -750,47 +750,56 @@ static int s3c64xx_spi_transfer_one(struct spi_master 
 *master,
  }
  
  static struct s3c64xx_spi_csinfo *s3c64xx_get_slave_ctrldata(
 - struct spi_device *spi)
 + struct spi_device *spi,
 + struct s3c64xx_spi_csinfo *cs)
  {
 - struct s3c64xx_spi_csinfo *cs;
 - struct device_node *slave_np, *data_np = NULL;
 - struct s3c64xx_spi_driver_data *sdd;
 + struct device_node *data_np = NULL;
   u32 fb_delay = 0;
  
 - sdd = spi_master_get_devdata(spi-master);
 - slave_np = spi-dev.of_node;
 - if (!slave_np) {
 - dev_err(spi-dev, device node not found\n);
 + data_np = of_get_child_by_name(spi-dev.of_node, controller-data);
 + if (!data_np) {
 + dev_err(spi-dev, child node 'controller-data' not found\n);
   return ERR_PTR(-EINVAL);
   }
  
 - data_np = of_get_child_by_name(slave_np, controller-data);
 - if (!data_np) {
 - dev_err(spi-dev, child node 'controller-data' not found\n);
 + of_property_read_u32(data_np, samsung,spi-feedback-delay, fb_delay);
 + cs-fb_delay = fb_delay;
 + of_node_put(data_np);
 +
 + return cs;
 +}
 +
 +static struct s3c64xx_spi_csinfo *s3c64xx_get_cs_gpios(struct spi_device 
 *spi)
 +{
 + struct device_node *parent_np = NULL;
 + struct s3c64xx_spi_driver_data *sdd;
 + struct s3c64xx_spi_csinfo *cs;
 +
 + parent_np = of_get_parent(spi-dev.of_node);
 + if (!parent_np) {
 + dev_err(spi-dev, Parent node not found\n);
   return ERR_PTR(-EINVAL);
   }
  
 + sdd = spi_master_get_devdata(spi-master);
 +
   cs = kzalloc(sizeof(*cs), GFP_KERNEL);
   if (!cs) {
 - of_node_put(data_np);
 + of_node_put(parent_np);
   return ERR_PTR(-ENOMEM);
   }
  
   

[PATCH RESEND] spi: s3c64xx: Fix pm_runtime_get_sync() return value check

2013-06-10 Thread Sylwester Nawrocki
If the device is already in a runtime PM enabled state
pm_runtime_get_sync() will return 1, so a test for negative
value should be used to check for errors.

Without this patch there are seen errors like:

[8.54] s3c64xx-spi 1393.spi: Failed to enable device: 1
[8.545000] spi_master spi1: failed to prepare transfer hardware

Likely because the driver uses synchronous API to runtime enable
the device and asynchronous one to disable it.

Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
I used broo...@kernel.org e-mail address this time, as found in MAINATAINERS,
instead of broo...@opensource.wolfsonmicro.com which seems to be inactive.

 drivers/spi/spi-s3c64xx.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 5000586..71cc3e6 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -444,7 +444,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master 
*spi)
}

ret = pm_runtime_get_sync(sdd-pdev-dev);
-   if (ret != 0) {
+   if (ret  0) {
dev_err(dev, Failed to enable device: %d\n, ret);
goto out_tx;
}
--
1.7.9.5


--
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


[PATCH] spi: s3c64xx: Don't free controller_data on non-dt platforms

2012-09-13 Thread Sylwester Nawrocki
When s3c64xx-spi is instantiated from device tree an instance of
struct s3c64xx_spi_csinfo is dynamically allocated in the driver.
For non-dt platform it is passed from board code through
spi_register_board_info(). On error path in s3c64xx_spi_setup()
function there is an attempt to free this data struct
s3c64xx_spi_csinfo object as it would have been allocated in the
driver for both, dt and non-dt based platforms. This leads to
following bug when gpio request fails:

spi spi1.0: Failed to get /CS gpio [21]: -16
kernel BUG at mm/slub.c:3478!
Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM
Modules linked in:
CPU: 0Not tainted  (3.6.0-rc5-00092-g9b0b493-dirty #6111)
PC is at kfree+0x148/0x158
LR is at s3c64xx_spi_setup+0xac/0x290
pc : [c00a513c]lr : [c0227014]psr: 4013
sp : ee043e10  ip : c032883c  fp : c0481f7c
r10: ee0abd80  r9 : 0063  r8 : 
r7 : ee129e78  r6 : ee104a00  r5 : fff0  r4 : c047bc64
r3 : 4400  r2 : c047bc64  r1 : c04def60  r0 : 0004047b
Flags: nZcv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
Control: 10c5387d  Table: 4000404a  DAC: 0015
Process swapper/0 (pid: 1, stack limit = 0xee0422f0)
Stack: (0xee043e10 to 0xee044000)
...
[c00a513c] (kfree+0x148/0x158) from [c0227014] 
(s3c64xx_spi_setup+0xac/0x290)
[c0227014] (s3c64xx_spi_setup+0xac/0x290) from [c02251a4] 
(spi_setup+0x34/0x4c)
[c02251a4] (spi_setup+0x34/0x4c) from [c02258d0] (spi_add_device+0x98/0x128)
[c02258d0] (spi_add_device+0x98/0x128) from [c02259d4] 
(spi_new_device+0x74/0xa8)
[c02259d4] (spi_new_device+0x74/0xa8) from [c0225a2c] 
(spi_match_master_to_boardinfo+0x24/0x44)
[c0225a2c] (spi_match_master_to_boardinfo+0x24/0x44) from [c0225b40] 
(spi_register_master+0xf4/0x2a8)
[c0225b40] (spi_register_master+0xf4/0x2a8) from [c043fe0c] 
(s3c64xx_spi_probe+0x34c/0x42c)
[c043fe0c] (s3c64xx_spi_probe+0x34c/0x42c) from [c01fc198] 
(platform_drv_probe+0x18/0x1c)

There should be no attempt to kfree controller_data when it was
externally provided through the board code. Fix this by freeing
controller_data only when dev-of_node is not null.

Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
 drivers/spi/spi-s3c64xx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index d1c8441f..7f75d4e 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -976,7 +976,8 @@ err_msgq:
spi_set_ctldata(spi, NULL);

 err_gpio_req:
-   kfree(cs);
+   if (spi-dev.of_node)
+   kfree(cs);

return err;
 }
--
1.7.11.3


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Sylwester Nawrocki
On 07/04/2012 06:11 PM, Mark Brown wrote:
 Saves some error handling and a small amount of code.
 
 Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
 Acked-by: Linus Walleij linus.wall...@linaro.org
 ---
  drivers/spi/spi-s3c64xx.c |   25 +
  1 file changed, 1 insertion(+), 24 deletions(-)
 
 diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
 index f4e2341..b7aeb5d 100644
 --- a/drivers/spi/spi-s3c64xx.c
 +++ b/drivers/spi/spi-s3c64xx.c
 @@ -1028,19 +1028,7 @@ static int __init s3c64xx_spi_probe(struct 
 platform_device *pdev)
   /* the spi-mode bits understood by this driver: */
   master-mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH;
  
 - if (request_mem_region(mem_res-start,
 - resource_size(mem_res), pdev-name) == NULL) {
 - dev_err(pdev-dev, Req mem region failed\n);
 - ret = -ENXIO;
 - goto err0;
 - }
 -
 - sdd-regs = ioremap(mem_res-start, resource_size(mem_res));
 - if (sdd-regs == NULL) {
 - dev_err(pdev-dev, Unable to remap IO\n);
 - ret = -ENXIO;
 - goto err1;
 - }
 + sdd-regs = devm_request_and_ioremap(pdev-dev, mem_res);

It doesn't seem right. Why is is the check for valid sdd-regs removed ?
This should have rather been:

+   sdd-regs = devm_request_and_ioremap(pdev-dev, mem_res);
+   if (sdd-regs == NULL) {
+   dev_err(pdev-dev, Failed to request memory region\n);
+   return -ENXIO;
+   }

Currently whne devm_request_and_ioremap() fails and returns NULL kernel oops
would happen right on first writel() in s3c64xx_spi_hwninit().


Thanks,
Sylwester

   if (sci-cfg_gpio == NULL || sci-cfg_gpio(pdev)) {
   dev_err(pdev-dev, Unable to config gpio\n);
 @@ -1124,10 +1112,6 @@ err4:
   clk_put(sdd-clk);
  err3:
  err2:
 - iounmap((void *) sdd-regs);
 -err1:
 - release_mem_region(mem_res-start, resource_size(mem_res));
 -err0:
   platform_set_drvdata(pdev, NULL);
   spi_master_put(master);
  
 @@ -1138,7 +1122,6 @@ static int s3c64xx_spi_remove(struct platform_device 
 *pdev)
  {
   struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));
   struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master);
 - struct resource *mem_res;
  
   pm_runtime_disable(pdev-dev);
  
 @@ -1154,12 +1137,6 @@ static int s3c64xx_spi_remove(struct platform_device 
 *pdev)
   clk_disable(sdd-clk);
   clk_put(sdd-clk);
  
 - iounmap((void *) sdd-regs);
 -
 - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 - if (mem_res != NULL)
 - release_mem_region(mem_res-start, resource_size(mem_res));
 -
   platform_set_drvdata(pdev, NULL);
   spi_master_put(master);

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Sylwester Nawrocki
Hi,

On 07/05/2012 02:33 PM, Mark Brown wrote:
 Saves some error handling and a small amount of code.
 
 Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
 Acked-by: Linus Walleij linus.wall...@linaro.org

Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com

--
Regards,
Sylwester

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH] spi: Add the use of DMA config operation

2012-02-08 Thread Sylwester Nawrocki
Hi,

On 02/08/2012 07:52 AM, Kyoungil Kim wrote:
 Config operation is separated from request operation in DMA common operation.
 Because spi driver can change the DMA config for every message.
 So this patch is using the separated DMA config operation.
 
 Signed-off-by: Boojin Kim boojin@samsung.com
 Signed-off-by: Kyoungil Kim ki0351@samsung.com
 ---
  drivers/spi/spi-s3c64xx.c |   35 +--
  1 files changed, 21 insertions(+), 14 deletions(-)

I'm getting following compilation errors with this patch:

  CC  drivers/spi/spi-s3c64xx.o
drivers/spi/spi-s3c64xx.c: In function ‘prepare_dma’:
drivers/spi/spi-s3c64xx.c:268: error: storage size of ‘info’ isn’t known
drivers/spi/spi-s3c64xx.c:269: error: storage size of ‘config’ isn’t known
drivers/spi/spi-s3c64xx.c:278: error: ‘struct samsung_dma_ops’ has no member
named ‘config’
drivers/spi/spi-s3c64xx.c:286: error: ‘struct samsung_dma_ops’ has no member
named ‘config’
drivers/spi/spi-s3c64xx.c:269: warning: unused variable ‘config’
drivers/spi/spi-s3c64xx.c:268: warning: unused variable ‘info’
drivers/spi/spi-s3c64xx.c: In function ‘acquire_dma’:
drivers/spi/spi-s3c64xx.c:302: error: storage size of ‘req’ isn’t known
drivers/spi/spi-s3c64xx.c:302: warning: unused variable ‘req’

Which tree has it been created off of ?

It seems there are some patches not yet in mainline that it depends on.


Thanks,
-- 
Sylwester Nawrocki
Samsung Poland RD Center


--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


[PATCH] spi: Add spi-s3c64xx driver dependency on ARCH_EXYNOS4

2012-01-25 Thread Sylwester Nawrocki
The spi-s3c64xx driver is also used on Exynos4 so update the dependency
to enable build on those platforms.

Cc: Jaswinder Singh jassi.b...@samsung.com
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
 drivers/spi/Kconfig |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 3f9a47e..a9f8faf 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -299,7 +299,7 @@ config SPI_S3C24XX_FIQ
 
 config SPI_S3C64XX
tristate Samsung S3C64XX series type SPI
-   depends on (ARCH_S3C64XX || ARCH_S5P64X0)
+   depends on (ARCH_S3C64XX || ARCH_S5P64X0 || ARCH_EXYNOS4)
select S3C64XX_DMA if ARCH_S3C64XX
help
  SPI driver for Samsung S3C64XX and newer SoCs.
-- 
1.7.8.3


--
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:24 PM, Mark Brown wrote:
 Although the hardware supports interrupts we're not currently using them
 at all since for small transfers the overhead is greater than that for
 busy waiting and for large transfers we have interrupts from the DMA.
 This means that if the hardware reports an error (especially one which
 might not stall transfer) we might miss it.
 
 Take a first pass at dealing with such errors by enabling the interrupt
 if we can and logging the errors if they happen. Ideally we'd report the
 error via the affected transfer but since we're in master mode it's very
 difficult to trigger errors at present and this code is much simpler.
 
 Signed-off-by: Mark Brownbroo...@opensource.wolfsonmicro.com
 Acked-by: Linus Walleijlinus.wall...@linaro.org
 ---
...
   static void s3c64xx_spi_hwinit(struct s3c64xx_spi_driver_data *sdd, int 
 channel)
   {
   struct s3c64xx_spi_info *sci = sdd-cntrlr_info;
 @@ -970,7 +999,8 @@ static int __init s3c64xx_spi_probe(struct 
 platform_device *pdev)
   struct s3c64xx_spi_driver_data *sdd;
   struct s3c64xx_spi_info *sci;
   struct spi_master *master;
 - int ret;
 + int ret, irq;
 + char clk_name[16];

clk_name seems to be unused, otherwise looks good.

--

Thanks,
Sylwester

--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 04:29 PM, Mark Brown wrote:
 On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote:
 On 01/21/2012 02:24 PM, Mark Brown wrote:
 
 -   int ret;
 +   int ret, irq;
 +   char clk_name[16];
 
 clk_name seems to be unused, otherwise looks good.
 
 That's git cherry-pick being too clever for me when I pulled this out of
 my -next branch for Grant.  clk_name is used in -next by some updates
 which I guess Kukjin is carrying, I hadn't noticed they weren't in the
 SPI tree.  I don't know if it's better to just leave things as they are
 for now given that it'll all come out in the merge window?

Indeed, the orphaned variable is already sitting in -next. I guess it
can be handled during merge.

--
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general