Re: [PATCH] spi/pl022: Fill master->dev.of_node to get spi devices registered via DT
On Wed, Aug 22, 2012 at 11:16 AM, Viresh Kumar wrote: > On 19 August 2012 03:56, Linus Walleij wrote: >> On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar >> Isn't this one of those things that *have* to be #ifdef CONFIG_OF? >> >> Next iteration, remember to add Mark Brown on To: because je's taking >> care of SPI patches for the moment. > > Ahh!! Forgot to reply :( > > Dropping this patch as it is already fixed in Roland's patches No problem, I was probably wrong anyway. It appears that part of the device struct is no longer ifdef:ed, so it will compile nicely. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi/pl022: Fill master->dev.of_node to get spi devices registered via DT
On 19 August 2012 03:56, Linus Walleij wrote: > On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar > wrote: > > > spi_register_master() calls of_register_spi_devices() to register spi > devices. > > This routine expects master->dev.of_node to be a valid pointer. This is > > responsibility of master driver to fill this field, which wasn't done > for pl022. > > Fix it to get devices added to pl022. > > Isn't this one of those things that *have* to be #ifdef CONFIG_OF? > > Next iteration, remember to add Mark Brown on To: because je's taking > care of SPI patches for the moment. > Ahh!! Forgot to reply :( Dropping this patch as it is already fixed in Roland's patches viresh -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi/pl022: Fill master->dev.of_node to get spi devices registered via DT
On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar wrote: > spi_register_master() calls of_register_spi_devices() to register spi devices. > This routine expects master->dev.of_node to be a valid pointer. This is > responsibility of master driver to fill this field, which wasn't done for > pl022. > Fix it to get devices added to pl022. OK... > master->rt = platform_info->rt; > + master->dev.of_node = dev->of_node; Isn't this one of those things that *have* to be #ifdef CONFIG_OF? Next iteration, remember to add Mark Brown on To: because je's taking care of SPI patches for the moment. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH] spi/pl022: Fill master->dev.of_node to get spi devices registered via DT
spi_register_master() calls of_register_spi_devices() to register spi devices. This routine expects master->dev.of_node to be a valid pointer. This is responsibility of master driver to fill this field, which wasn't done for pl022. Fix it to get devices added to pl022. Signed-off-by: Viresh Kumar --- drivers/spi/spi-pl022.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index aab518e..3a46848 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2029,6 +2029,7 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id) master->transfer_one_message = pl022_transfer_one_message; master->unprepare_transfer_hardware = pl022_unprepare_transfer_hardware; master->rt = platform_info->rt; + master->dev.of_node = dev->of_node; /* * Supports mode 0-3, loopback, and active low CS. Transfers are -- 1.7.12.rc2.18.g61b472e -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
