Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 04:28:34PM +0200, Ulf Hansson wrote: > I will do a resend and include some explanation for the reverts in the > "cover-letter". It'd be good if the explanation could be in the commit logs so that people reading history can understand things. --

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-10-03 Thread Ulf Hansson
k has been helping out merging >> spi patches, did not know that when sending out this series. Anyway, >> do you guys see any issues merging this? > >> [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe" >> [PATCH 2/3] Revert "spi/pl022: enable run

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: > Heard from Linus Walleij that you Mark has been helping out merging > spi patches, did not know that when sending out this series. Anyway, > do you guys see any issues merging this? > [PATCH 1/3] Revert "spi/pl022:

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-10-03 Thread Ulf Hansson
Hi Mark and Grant, Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe" [PATCH 2/3] Revert

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-30 Thread Linus Walleij
On Sun, Sep 30, 2012 at 12:14 PM, Russell King - ARM Linux wrote: > The real answer is to revert both commits to get the driver back to a > sane state, before then progressing with the driver in a sane manner. > This is what Ulf is doing. Aha, mea culpa. Acked-by: Linus Walleij For all of them

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-30 Thread Russell King - ARM Linux
On Sun, Sep 30, 2012 at 10:44:17AM +0200, Linus Walleij wrote: > On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson > wrote: > > > From: Ulf Hansson > > > > This reverts commit 6887237cd7da904184dab2750504040c68f3a080. > > > > Signed-off-by: Ulf Hansson > > Why? > > It was removed in this commit,

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-30 Thread Linus Walleij
On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson wrote: > From: Ulf Hansson > > This reverts commit 6887237cd7da904184dab2750504040c68f3a080. > > Signed-off-by: Ulf Hansson Why? It was removed in this commit, is it wrong? Author: Michel JAOUEN Date: Fri Aug 17 17:28:41 2012 +0200 spi/pl0

Re: [PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-28 Thread vipul kumar samar
Hello Ulf, On 9/28/2012 4:51 PM, Ulf HANSSON wrote: > From: Ulf Hansson > > This reverts commit 6887237cd7da904184dab2750504040c68f3a080. > > Signed-off-by: Ulf Hansson > --- > drivers/spi/spi-pl022.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/spi/spi-pl022.c b/drivers/

[PATCH 1/3] Revert "spi/pl022: fix spi-pl022 pm enable at probe"

2012-09-28 Thread Ulf Hansson
From: Ulf Hansson This reverts commit 6887237cd7da904184dab2750504040c68f3a080. Signed-off-by: Ulf Hansson --- drivers/spi/spi-pl022.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index f8568b4..3f2f36c 100644 --- a/drivers/spi/spi-pl