Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-31 Thread Shubhrajyoti Datta
Hi Mark, On Mon, Jan 30, 2012 at 3:10 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sat, Jan 28, 2012 at 10:30:36PM +0530, Shubhrajyoti Datta wrote: Please delete irrelevant context from your replies. +   ret = request_irq(irq, s3c64xx_spi_irq, 0, spi-s3c64xx, sdd); Could

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-28 Thread Shubhrajyoti Datta
Hi Mark, Some minor doubts/ questions. On 1/21/12, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have interrupts from the DMA. This means that if the hardware reports an error (especially one which might not

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 02:24 PM, Mark Brown wrote: Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have interrupts from the DMA. This means that if the hardware

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:24 PM, Mark Brown wrote: - int ret; + int ret, irq; + char clk_name[16]; clk_name seems to be unused, otherwise looks good. That's git cherry-pick being too clever for me when I pulled this out of

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Sylwester Nawrocki
On 01/21/2012 04:29 PM, Mark Brown wrote: On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:24 PM, Mark Brown wrote: - int ret; + int ret, irq; + char clk_name[16]; clk_name seems to be unused, otherwise looks good. That's git cherry-pick being

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2011-12-05 Thread Mark Brown
Although the hardware supports interrupts we're not currently using them at all since for small transfers the overhead is greater than that for busy waiting and for large transfers we have interrupts from the DMA. This means that if the hardware reports an error (especially one which might not