Re: [PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-02-05 Thread Grant Likely 
On Fri, 25 Jan 2013 14:14:31 +, Arnd Bergmann a...@arndb.de wrote:
 Since we no longer allow building without hotplug, the
 atmel_spi_remove function is always present and we should
 not use __exit_p() to refer to it.
 
 Without this patch, building at91_dt_defconfig results in:
 
 drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not 
 used [-Wunused-function]

Looks good, but I took a deeper look and it is incomplete. I found an
whole bunch more references. I've crafted a new patch to get rid of
them. I'll post and commit it to my tree.

g.


--
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013 
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

Re: [PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-01-28 Thread Nicolas Ferre 
On 01/25/2013 11:44 PM, Arnd Bergmann :
 Since we no longer allow building without hotplug, the
 atmel_spi_remove function is always present and we should
 not use __exit_p() to refer to it.
 
 Without this patch, building at91_dt_defconfig results in:
 
 drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not 
 used [-Wunused-function]
 
 Signed-off-by: Arnd Bergmann a...@arndb.de
 Cc: Nicolas Ferre nicolas.fe...@atmel.com

Acked-by: Nicolas Ferre nicolas.fe...@atmel.com

 Cc: Grant Likely grant.lik...@secretlab.ca
 Cc: spi-devel-general@lists.sourceforge.net
 ---
  drivers/spi/spi-atmel.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
 index ab34497..656d137 100644
 --- a/drivers/spi/spi-atmel.c
 +++ b/drivers/spi/spi-atmel.c
 @@ -1088,7 +1088,7 @@ static struct platform_driver atmel_spi_driver = {
   .suspend= atmel_spi_suspend,
   .resume = atmel_spi_resume,
   .probe  = atmel_spi_probe,
 - .remove = __exit_p(atmel_spi_remove),
 + .remove = atmel_spi_remove,
  };
  module_platform_driver(atmel_spi_driver);
  
 


-- 
Nicolas Ferre

--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-01-25 Thread Arnd Bergmann 
Since we no longer allow building without hotplug, the
atmel_spi_remove function is always present and we should
not use __exit_p() to refer to it.

Without this patch, building at91_dt_defconfig results in:

drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not 
used [-Wunused-function]

Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Nicolas Ferre nicolas.fe...@atmel.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: spi-devel-general@lists.sourceforge.net
---
 drivers/spi/spi-atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index ab34497..656d137 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1088,7 +1088,7 @@ static struct platform_driver atmel_spi_driver = {
.suspend= atmel_spi_suspend,
.resume = atmel_spi_resume,
.probe  = atmel_spi_probe,
-   .remove = __exit_p(atmel_spi_remove),
+   .remove = atmel_spi_remove,
 };
 module_platform_driver(atmel_spi_driver);
 
-- 
1.8.0


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general

[PATCH 14/19] spi/atmel: remove incorrect __exit_p()

2013-01-25 Thread Arnd Bergmann 
Since we no longer allow building without hotplug, the
atmel_spi_remove function is always present and we should
not use __exit_p() to refer to it.

Without this patch, building at91_dt_defconfig results in:

drivers/spi/spi-atmel.c:1006:12: warning: 'atmel_spi_remove' defined but not 
used [-Wunused-function]

Signed-off-by: Arnd Bergmann a...@arndb.de
Cc: Nicolas Ferre nicolas.fe...@atmel.com
Cc: Grant Likely grant.lik...@secretlab.ca
Cc: spi-devel-general@lists.sourceforge.net
---
 drivers/spi/spi-atmel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index ab34497..656d137 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1088,7 +1088,7 @@ static struct platform_driver atmel_spi_driver = {
.suspend= atmel_spi_suspend,
.resume = atmel_spi_resume,
.probe  = atmel_spi_probe,
-   .remove = __exit_p(atmel_spi_remove),
+   .remove = atmel_spi_remove,
 };
 module_platform_driver(atmel_spi_driver);
 
-- 
1.8.0


--
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general