Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-08-21 Thread David Daney
On 05/19/2012 10:46 PM, Grant Likely wrote: On Fri, 11 May 2012 14:34:46 -0700, David Daney ddaney.c...@gmail.com wrote: From: David Daney david.da...@cavium.com Add the driver, link it into the kbuild system and provide device tree binding documentation. Signed-off-by: David Daney

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Mon, 14 May 2012 11:13:41 -0700, David Daney ddaney.c...@gmail.com wrote: On 05/13/2012 10:46 PM, Shubhrajyoti Datta wrote: Hi David, A few comments. On Sat, May 12, 2012 at 3:04 AM, David Daneyddaney.c...@gmail.com wrote: [...] + +#define DRV_VERSION 2.0 /* Version 1 was the

Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.

2012-05-19 Thread Grant Likely
On Fri, 11 May 2012 14:34:46 -0700, David Daney ddaney.c...@gmail.com wrote: From: David Daney david.da...@cavium.com Add the driver, link it into the kbuild system and provide device tree binding documentation. Signed-off-by: David Daney david.da...@cavium.com Some comments below, but