Re: [PATCH 2/4] spi: spi-pl022: Minor simplification for runtime pm
On Wed, Oct 17, 2012 at 4:39 PM, Ulf Hansson wrote: > We have discussed this patch previously. I think we shall use it, but > we should change the commit msg since it does not reflect the truth. > It is no more true that "upper layer in driver core is preventing the > device from being runtime suspended by a pm_runtime_get*". This was > the case earlier. OK I'll update the commit message and respin this one *only* as [PATCH 2/4 v2] hold on... Yours, Linus Walleij -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 2/4] spi: spi-pl022: Minor simplification for runtime pm
Hi,
We have discussed this patch previously. I think we shall use it, but
we should change the commit msg since it does not reflect the truth.
It is no more true that "upper layer in driver core is preventing the
device from being runtime suspended by a pm_runtime_get*". This was
the case earlier.
Kind regards
Ulf Hansson
On 17 October 2012 14:27, Linus Walleij wrote:
> From: Ulf Hansson
>
> In probe pm_runtime_put_autosuspend has the same effect as doing
> pm_runtime_put. This due to upper layer in driver core is preventing
> the device from being runtime suspended by a pm_runtime_get*.
>
> Signed-off-by: Ulf Hansson
> Signed-off-by: Linus Walleij
> ---
> drivers/spi/spi-pl022.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
> index a1db91a..51b7a95 100644
> --- a/drivers/spi/spi-pl022.c
> +++ b/drivers/spi/spi-pl022.c
> @@ -2246,10 +2246,9 @@ pl022_probe(struct amba_device *adev, const struct
> amba_id *id)
> pm_runtime_set_autosuspend_delay(dev,
> platform_info->autosuspend_delay);
> pm_runtime_use_autosuspend(dev);
> - pm_runtime_put_autosuspend(dev);
> - } else {
> - pm_runtime_put(dev);
> }
> + pm_runtime_put(dev);
> +
> return 0;
>
> err_spi_register:
> --
> 1.7.11.3
>
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 2/4] spi: spi-pl022: Minor simplification for runtime pm
From: Ulf Hansson
In probe pm_runtime_put_autosuspend has the same effect as doing
pm_runtime_put. This due to upper layer in driver core is preventing
the device from being runtime suspended by a pm_runtime_get*.
Signed-off-by: Ulf Hansson
Signed-off-by: Linus Walleij
---
drivers/spi/spi-pl022.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c
index a1db91a..51b7a95 100644
--- a/drivers/spi/spi-pl022.c
+++ b/drivers/spi/spi-pl022.c
@@ -2246,10 +2246,9 @@ pl022_probe(struct amba_device *adev, const struct
amba_id *id)
pm_runtime_set_autosuspend_delay(dev,
platform_info->autosuspend_delay);
pm_runtime_use_autosuspend(dev);
- pm_runtime_put_autosuspend(dev);
- } else {
- pm_runtime_put(dev);
}
+ pm_runtime_put(dev);
+
return 0;
err_spi_register:
--
1.7.11.3
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
