Re: [PATCH 2/6] spi/spi-pl022: Use GFP_NOWAIT for allocation from tasklet

2011-08-09 Thread viresh kumar
On 08/09/2011 04:56 PM, Jassi Brar wrote: > Since this could be called from when we actually need the transfer start, > maybe we could try harder using GFP_ATOMIC instead ? Yes. Will do it. -- viresh -- uberSVN's rich s

Re: [PATCH 2/6] spi/spi-pl022: Use GFP_NOWAIT for allocation from tasklet

2011-08-09 Thread Jassi Brar
On Tue, Aug 9, 2011 at 4:35 PM, Viresh Kumar wrote: > tasklets don't allow invocation to sleeping routines. In configure_dma() > routine, sg_alloc_table() was called with GFP_KERNEL flag and so this causes > crash when called from tasklet. > > Replace GFP_KERNEL with GFP_NOWAIT to get this fixed.

[PATCH 2/6] spi/spi-pl022: Use GFP_NOWAIT for allocation from tasklet

2011-08-09 Thread Viresh Kumar
tasklets don't allow invocation to sleeping routines. In configure_dma() routine, sg_alloc_table() was called with GFP_KERNEL flag and so this causes crash when called from tasklet. Replace GFP_KERNEL with GFP_NOWAIT to get this fixed. Signed-off-by: Viresh Kumar --- drivers/spi/spi-pl022.c |