Re: [PATCH 4/6] spi/pl022: skip default configuration before suspending
On Wed, Nov 9, 2011 at 11:55 AM, Viresh Kumar wrote: > On 11/9/2011 4:09 PM, Linus WALLEIJ wrote: >> >> - amba_vcore_enable(pl022->adev); >> - amba_pclk_enable(pl022->adev); >> - load_ssp_default_config(pl022); >> - amba_pclk_disable(pl022->adev); >> - amba_vcore_disable(pl022->adev); >> - dev_dbg(dev, "suspended\n"); >> + dev_dbg(&adev->dev, "suspended\n"); > > why adev->dev instead of dev? Plain bug. It doesn't even compile with -DDEBUG :-/ I'll fix it up.. Linus -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 4/6] spi/pl022: skip default configuration before suspending
On 11/9/2011 4:09 PM, Linus WALLEIJ wrote: > From: Virupax Sadashivpetimath > > The loading of the default configuration before suspending has > been in the driver since its inception, but it is not really > needed. Especially so since we take to all the trouble of > enabling and disabling power and clock just to do this. Let's > scrap this now. > > Signed-off-by: Virupax Sadashivpetimath > > Signed-off-by: Linus Walleij > --- > drivers/spi/spi-pl022.c |7 +-- > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c > index fa3eaae..bffad2a 100644 > --- a/drivers/spi/spi-pl022.c > +++ b/drivers/spi/spi-pl022.c > @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev) > return status; > } > > - amba_vcore_enable(pl022->adev); > - amba_pclk_enable(pl022->adev); > - load_ssp_default_config(pl022); > - amba_pclk_disable(pl022->adev); > - amba_vcore_disable(pl022->adev); > - dev_dbg(dev, "suspended\n"); > + dev_dbg(&adev->dev, "suspended\n"); why adev->dev instead of dev? > return 0; > } > -- viresh -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 4/6] spi/pl022: skip default configuration before suspending
From: Virupax Sadashivpetimath The loading of the default configuration before suspending has been in the driver since its inception, but it is not really needed. Especially so since we take to all the trouble of enabling and disabling power and clock just to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath Signed-off-by: Linus Walleij --- drivers/spi/spi-pl022.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index fa3eaae..bffad2a 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2314,12 +2314,7 @@ static int pl022_suspend(struct device *dev) return status; } - amba_vcore_enable(pl022->adev); - amba_pclk_enable(pl022->adev); - load_ssp_default_config(pl022); - amba_pclk_disable(pl022->adev); - amba_vcore_disable(pl022->adev); - dev_dbg(dev, "suspended\n"); + dev_dbg(&adev->dev, "suspended\n"); return 0; } -- 1.7.3.2 -- RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
