Re: [PATCH V2 0/6] spi/spi-pl022 fixes
On Tue, Sep 20, 2011 at 04:46:44PM +0530, Viresh Kumar wrote: > On 9/1/2011 4:26 PM, Linus Walleij wrote: > > I agree. Acked-by: Linus Walleij for > > all except 6/6, it's probably just as possible to keep the channel handle > > taken in the driver if we modify the affected DMA driver instead. > > This would be better for performance I think. > > Hi Grant, > > Any updates on this? Applied 1-5, thanks. g. > > -- > viresh -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/6] spi/spi-pl022 fixes
On 9/1/2011 4:26 PM, Linus Walleij wrote: > I agree. Acked-by: Linus Walleij for > all except 6/6, it's probably just as possible to keep the channel handle > taken in the driver if we modify the affected DMA driver instead. > This would be better for performance I think. Hi Grant, Any updates on this? -- viresh -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity and more. Splunk takes this data and makes sense of it. Business sense. IT sense. Common sense. http://p.sf.net/sfu/splunk-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/6] spi/spi-pl022 fixes
On Thu, Sep 1, 2011 at 12:04 PM, Viresh Kumar wrote: > On 8/10/2011 2:20 PM, Viresh KUMAR wrote: >> >> This patchset mainly covers following fixes: >> - formatting related issues >> - Passing GFP_ATOMIC for sg allocation from tasklet >> - Fixing calculate_effective_freq() routine >> - Allocate/free DMA channels as and when required. >> > > Grant, > > Did you already pushed this patchset? > There are few concerns on PATCH 6/6 and i am not sure if there are any > decisions > on it. > @Linus: What do you say? I agree. Acked-by: Linus Walleij for all except 6/6, it's probably just as possible to keep the channel handle taken in the driver if we modify the affected DMA driver instead. This would be better for performance I think. Thanks, Linus Walleij -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH V2 0/6] spi/spi-pl022 fixes
On 8/10/2011 2:20 PM, Viresh KUMAR wrote: > Hi Grant, > > I have added Tested-by: Linus Walleij on all > patches. > > This patchset mainly covers following fixes: > - formatting related issues > - Passing GFP_ATOMIC for sg allocation from tasklet > - Fixing calculate_effective_freq() routine > - Allocate/free DMA channels as and when required. > Grant, Did you already pushed this patchset? There are few concerns on PATCH 6/6 and i am not sure if there are any decisions on it. @Linus: What do you say? So, probably you can push first 5 patches for now. -- viresh -- Special Offer -- Download ArcSight Logger for FREE! Finally, a world-class log management solution at an even better price-free! And you'll get a free "Love Thy Logs" t-shirt when you download Logger. Secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsisghtdev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH V2 0/6] spi/spi-pl022 fixes
Hi Grant, I have added Tested-by: Linus Walleij on all patches. This patchset mainly covers following fixes: - formatting related issues - Passing GFP_ATOMIC for sg allocation from tasklet - Fixing calculate_effective_freq() routine - Allocate/free DMA channels as and when required. Changes since V1: - Replace GFP_NOWAIT with GFP_ATOMIC - Wrote inline routine spi_rate instead of macro Viresh Kumar (6): spi/spi-pl022: Resolve formatting issues spi/spi-pl022: Use GFP_ATOMIC for allocation from tasklet spi/spi-pl022: Don't allocate more sg than required. spi/spi-pl022: calculate_effective_freq() must set rate <= requested rate spi/spi-pl022: Call pl022_dma_remove(pl022) only if enable_dma is true spi/spi-pl022: Request/free DMA channels as and when required. drivers/spi/spi-pl022.c | 269 ++- 1 files changed, 151 insertions(+), 118 deletions(-) -- 1.7.2.2 -- uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
