Re: [PATCH v2] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-28 Thread Mark Brown
On Tue, Sep 25, 2012 at 01:21:57PM +0200, Dirk Behme wrote:
 From: Knut Wohlrab knut.wohl...@de.bosch.com
 
 There are SPI devices which need a SPI clock with active low polarity and
 high inactive state.

Applied, thanks.

--
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general


[PATCH v2] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-25 Thread Dirk Behme
From: Knut Wohlrab knut.wohl...@de.bosch.com

There are SPI devices which need a SPI clock with active low polarity and
high inactive state.

Add the setting of the inactive state ECSPIx_CONFIGREG:SCLK CTL
according to the clock polarity ECSPIx_CONFIGREG:SCLK POL:

DT without spi-cpol = 0 = clock active high polarity = inactive state low
DT withspi-cpol = 1 = clock active low  polarity = inactive state high

Signed-off-by: Knut Wohlrab knut.wohl...@de.bosch.com
Signed-off-by: Dirk Behme dirk.be...@de.bosch.com
Acked-by: Shawn Guo shawn@linaro.org
CC: Mark Brown broo...@opensource.wolfsonmicro.com
---
Changes in v2:
No functional changes on the patch itself. Add Acked-by and Sob tags,
CC to Mark Brown.

 drivers/spi/spi-imx.c |6 --
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index e834ff8..d64655b 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -197,6 +197,7 @@ static unsigned int spi_imx_clkdiv_2(unsigned int fin,
 #define MX51_ECSPI_CONFIG_SCLKPOL(cs)  (1  ((cs) +  4))
 #define MX51_ECSPI_CONFIG_SBBCTRL(cs)  (1  ((cs) +  8))
 #define MX51_ECSPI_CONFIG_SSBPOL(cs)   (1  ((cs) + 12))
+#define MX51_ECSPI_CONFIG_SCLKCTL(cs)  (1  ((cs) + 20))
 
 #define MX51_ECSPI_INT 0x10
 #define MX51_ECSPI_INT_TEEN(1   0)
@@ -287,9 +288,10 @@ static int __maybe_unused mx51_ecspi_config(struct 
spi_imx_data *spi_imx,
if (config-mode  SPI_CPHA)
cfg |= MX51_ECSPI_CONFIG_SCLKPHA(config-cs);
 
-   if (config-mode  SPI_CPOL)
+   if (config-mode  SPI_CPOL) {
cfg |= MX51_ECSPI_CONFIG_SCLKPOL(config-cs);
-
+   cfg |= MX51_ECSPI_CONFIG_SCLKCTL(config-cs);
+   }
if (config-mode  SPI_CS_HIGH)
cfg |= MX51_ECSPI_CONFIG_SSBPOL(config-cs);
 
-- 
1.7.0.4


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general