Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote:
> This patch adds dma maxburst size initialization.
> The maxburst should be set by MODE_CFGn.DMA_TYPE,
> because the pl330 dma driver supports burst mode.
>
> Signed-off-by: Hyeonkook Kim
Acked-by: Grant Likely
This series probably needs to be merged together through the arm-soc
tree.
g.
> ---
> drivers/spi/spi-s3c64xx.c | 18 ++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index e862ab8..5e6cafe 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -287,10 +287,20 @@ static void prepare_dma(struct s3c64xx_spi_dma_data
> *dma,
> struct s3c64xx_spi_driver_data *sdd;
> struct samsung_dma_prep info;
> struct samsung_dma_config config;
> + void __iomem *regs;
> + unsigned int mode_cfg;
>
> if (dma->direction == DMA_DEV_TO_MEM) {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, rx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->rx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
> config.width = sdd->cur_bpw / 8;
> @@ -298,6 +308,14 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
> } else {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, tx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->tx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
> config.width = sdd->cur_bpw / 8;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote:
> This patch adds dma maxburst size initialization.
> The maxburst should be set by MODE_CFGn.DMA_TYPE,
> because the pl330 dma driver supports burst mode.
>
> Signed-off-by: Hyeonkook Kim
Hello Hyeonkook,
I applied this patch but then discovered that it relys on the previous
patches that you've posted. When patched depend on each other like this
please post them as a series with [PATCH x/4] in the subject line.
'git send-email' will format this correctly for you.
g.
> ---
> drivers/spi/spi-s3c64xx.c | 18 ++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index e862ab8..5e6cafe 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -287,10 +287,20 @@ static void prepare_dma(struct s3c64xx_spi_dma_data
> *dma,
> struct s3c64xx_spi_driver_data *sdd;
> struct samsung_dma_prep info;
> struct samsung_dma_config config;
> + void __iomem *regs;
> + unsigned int mode_cfg;
>
> if (dma->direction == DMA_DEV_TO_MEM) {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, rx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->rx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
> config.width = sdd->cur_bpw / 8;
> @@ -298,6 +308,14 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
> } else {
> sdd = container_of((void *)dma,
> struct s3c64xx_spi_driver_data, tx_dma);
> +
> + regs = sdd->regs;
> + mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
> + if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
> + config.maxburst = 4;
> + else
> + config.maxburst = 1;
> +
> config.direction = sdd->tx_dma.direction;
> config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
> config.width = sdd->cur_bpw / 8;
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies, Ltd.
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization
On Fri, 22 Feb 2013 17:09:18 +0900, Boojin Kim wrote: > This patch adds dma maxburst size initialization. > The maxburst should be set by MODE_CFGn.DMA_TYPE, > because the pl330 dma driver supports burst mode. > > Signed-off-by: Hyeonkook Kim Applied, thanks. g. -- Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH v2 3/4] spi: s3c64xx: add dma maxburst size initialization
This patch adds dma maxburst size initialization.
The maxburst should be set by MODE_CFGn.DMA_TYPE,
because the pl330 dma driver supports burst mode.
Signed-off-by: Hyeonkook Kim
---
drivers/spi/spi-s3c64xx.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index e862ab8..5e6cafe 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -287,10 +287,20 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
struct s3c64xx_spi_driver_data *sdd;
struct samsung_dma_prep info;
struct samsung_dma_config config;
+ void __iomem *regs;
+ unsigned int mode_cfg;
if (dma->direction == DMA_DEV_TO_MEM) {
sdd = container_of((void *)dma,
struct s3c64xx_spi_driver_data, rx_dma);
+
+ regs = sdd->regs;
+ mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
+ if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
+ config.maxburst = 4;
+ else
+ config.maxburst = 1;
+
config.direction = sdd->rx_dma.direction;
config.fifo = sdd->sfr_start + S3C64XX_SPI_RX_DATA;
config.width = sdd->cur_bpw / 8;
@@ -298,6 +308,14 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma,
} else {
sdd = container_of((void *)dma,
struct s3c64xx_spi_driver_data, tx_dma);
+
+ regs = sdd->regs;
+ mode_cfg = readl(regs + S3C64XX_SPI_MODE_CFG);
+ if (mode_cfg & S3C64XX_SPI_MODE_4BURST)
+ config.maxburst = 4;
+ else
+ config.maxburst = 1;
+
config.direction = sdd->tx_dma.direction;
config.fifo = sdd->sfr_start + S3C64XX_SPI_TX_DATA;
config.width = sdd->cur_bpw / 8;
--
1.7.5.4
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
