Re: [spi-devel-general] [PATCH 3/3] max3100: adds console support for MAX3100

2010-03-22 Thread christian pellegrin
On Mon, Mar 22, 2010 at 2:31 AM, Feng Tang feng.t...@intel.com wrote: Hi Christian, Hi, You'd better not call max3110_sr (which calls spi_sync) here, a console's putchar() func may be called in some atomic context. ack, I didn't realize that. Unfortunately this makes reliable use of

Re: [spi-devel-general] [PATCH 3/3] max3100: adds console support for MAX3100

2010-03-21 Thread christian pellegrin
On Fri, Mar 19, 2010 at 8:31 PM, Grant Likely grant.lik...@secretlab.ca wrote: +config SERIAL_MAX3100_CONSOLE_N +       int Number of MAX3100 chips to wait before registering console +       depends on SERIAL_MAX3100_CONSOLE=y +       default 1 +       help +         Unfortunately due to

Re: [spi-devel-general] [PATCH 3/3] max3100: adds console support for MAX3100

2010-03-21 Thread David Brownell
On Sunday 21 March 2010, christian pellegrin wrote: Anybody know the right thing to do here? when to register consoles is a general mess. I've seeen some success in having it be board-specific data, at the level of port 3 should be a console ... or in this case, maybe having platform data say

Re: [spi-devel-general] [PATCH 3/3] max3100: adds console support for MAX3100

2010-03-21 Thread Feng Tang
On Fri, 19 Mar 2010 16:39:57 +0800 Christian Pellegrin chrip...@fsfe.org wrote: +#ifdef CONFIG_SERIAL_MAX3100_CONSOLE + +static void max3100_console_putchar(struct uart_port *port, int ch) +{ + struct max3100_port *s = container_of(port, struct max3100_port, port); + unsigned long

Re: [spi-devel-general] [PATCH 3/3] max3100: adds console support for MAX3100

2010-03-19 Thread Grant Likely
Hi Christian, Comments below. g. On Fri, Mar 19, 2010 at 2:39 AM, Christian Pellegrin chrip...@fsfe.org wrote: This patch adds console support for the MAX3100 UART (console=ttyMAX0,11500). The SPI subsystem and an suitable SPI master driver have to be compiled in the kernel. Signed-off-by: