[PATCH 1/2] spi/pl022: only enable RX interrupts when TX is complete

2011-10-06 Thread Linus Walleij
-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 3653f00..4761b31 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c

Re: [PATCH 11/16] spi: pl022: Enable module alias autogeneration for AMBA drivers

2011-10-06 Thread Linus Walleij
2011/10/5 Dave Martin dave.mar...@linaro.org: Signed-off-by: Dave Martin dave.mar...@linaro.org ---  drivers/spi/spi-pl022.c |    2 ++  1 files changed, 2 insertions(+), 0 deletions(-) Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij

[PATCH 1/3] spi/pl022: fix build warnings

2011-10-17 Thread Linus Walleij
From: Jonas Aaberg jonas.ab...@stericsson.com The driver build complains with newer compilers unless you initialize this struct properly. Signed-off-by: Jonas Aaberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |2 +- 1 files

[PATCH 2/3] spi/pl022: disable the PL022 block when unused

2011-10-17 Thread Linus Walleij
From: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Make sure we clear the enable bit when the block is not used. This will save some energy in certain hardware versions. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus

[PATCH 3/3] spi/pl022: skip default configuration before suspending

2011-10-17 Thread Linus Walleij
to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-pl022.c

Re: [PATCH 2/2] spi/pl022: elevate workqueue to realtime priority

2011-10-17 Thread Linus Walleij
On Thu, Oct 6, 2011 at 9:03 AM, Linus Walleij linus.wall...@stericsson.com wrote: From: Chris Blair chris.bl...@stericsson.com The PL022 is used in performance-critical applications where we need soft realtime response from the SPI data pipe. Elevating the workqueue to realtime has been

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-10-22 Thread Linus Walleij
patches are merged, so put this in Russell's patch tracker so he can put it on his AMBA PM branch. But looks correct. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- The demand for IT networking

Re: [PATCH] spi/pl022: Enable clock in probe an use runtime_idle

2011-10-24 Thread Linus Walleij
fixup that in the aftermath of the merge window, no hurries. Yours, Linus Walleij -- The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more

Re: [PATCH V2] spi/pl022: Enable clock in probe

2011-11-03 Thread Linus Walleij
On Thu, Nov 3, 2011 at 4:55 PM, Ulf Hansson ulf.hans...@stericsson.com wrote: Make sure we enable the clock before leaving probe. Signed-off-by: Ulf Hansson ulf.hans...@stericsson.com --- Changes in v2:        -Remove runtime_idle Looking good Acked-by: Linus Walleij linus.wall

[PATCH 1/6] spi/pl022: only enable RX interrupts when TX is complete

2011-11-09 Thread Linus Walleij
-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 5559b22..b251926 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c

[PATCH 2/6] spi/pl022: fix build warnings

2011-11-09 Thread Linus Walleij
From: Jonas Aaberg jonas.ab...@stericsson.com The driver build complains with newer compilers unless you initialize this struct properly. Signed-off-by: Jonas Aaberg jonas.ab...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |2 +- 1 files

[PATCH 4/6] spi/pl022: skip default configuration before suspending

2011-11-09 Thread Linus Walleij
to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-pl022

[PATCH 5/6] spi/pl022: move device disable to workqueue thread

2011-11-09 Thread Linus Walleij
in another thread. Signed-off-by: Chris Blair chris.bl...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/spi/spi-pl022.c b/drivers

[PATCH] spi/pl022: make the chip deselect handling thread safe

2011-11-18 Thread Linus Walleij
to double-activate it. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 72 --- 1 files changed, 37 insertions(+), 35 deletions(-) diff

[PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
in another thread. Signed-off-by: Chris Blair chris.bl...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Moved this patch before the block disable patch at request from Viresh. - Insert blank line... --- drivers/spi/spi-pl022.c | 26

[PATCH 5/7] spi/pl022: disable the PL022 block when unused

2011-11-22 Thread Linus Walleij
virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Move this patch after the movement of disabling code to workqueue at Viresh:s request. - Add Vireshs Reviewed-by --- drivers/spi/spi-pl022.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions

[PATCH 3/7] spi/pl022: skip default configuration before suspending

2011-11-22 Thread Linus Walleij
to do this. Let's scrap this now. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Use local dev pointer instead of copy/paste bug adev-dev --- drivers/spi/spi-pl022.c |5 - 1 files

[PATCH 7/7] spi/pl022: make the chip deselect handling thread safe

2011-11-22 Thread Linus Walleij
to double-activate it. Signed-off-by: Virupax Sadashivpetimath virupax.sadashivpetim...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 72 --- 1 files changed, 37 insertions(+), 35 deletions(-) diff

[PATCH 6/7] spi/pl022: add support for pm_runtime autosuspend

2011-11-22 Thread Linus Walleij
then takes place before the autosuspend timeout, the call to resume the device can return immediately rather than needing to risk sleeping in order to resume the device. Reviewed-by: Viresh Kumar viresh.ku...@st.com Signed-off-by: Chris Blair chris.bl...@stericsson.com Signed-off-by: Linus Walleij

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-11-22 Thread Linus Walleij
On Tue, Nov 22, 2011 at 9:28 AM, Viresh Kumar viresh.ku...@st.com wrote: On 11/22/2011 1:55 PM, Linus WALLEIJ wrote:       if (list_empty(pl022-queue) || !pl022-running) { +             if (pl022-busy) { +                     pm_runtime_put(pl022-adev-dev); +             } We used to get

Re: [PATCH] spi/s3c64xx: Log error interrupts

2011-12-02 Thread Linus Walleij
transfer but since we're in master mode it's very difficult to trigger errors at present and this code is much simpler. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Looks good to me: Acked-by: Linus Walleij linus.wall...@linaro.org (Cc:ing Jassi so he doesn't miss this.) Yours

Re: [PATCH/RFC] spi: Fix device unregistration when unregistering the bus master

2011-12-02 Thread Linus Walleij
-dev; Just my €0.01... Yours, Linus Walleij -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Linus Walleij
and one using distributed clock management ... Yours, Linus Walleij -- All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-06 Thread Linus Walleij
factor out once the pattern is clearly visible. I agree with this. I will go forward in the same manner with Ux500 for the time being. Thanks, Linus Walleij -- Cloud Services Checklist: Pricing and Packaging Optimization

Re: [PATCH/RFC] spi: Fix device unregistration when unregistering the bus master

2011-12-06 Thread Linus Walleij
if somebody screams ... Linus Walleij -- Cloud Services Checklist: Pricing and Packaging Optimization This white paper is intended to serve as a reference, checklist and point of discussion for anyone considering optimizing

Re: [PATCH 4/7] spi/pl022: move device disable to workqueue thread

2011-12-07 Thread Linus Walleij
added them to my branch and waited for Grant to get back online. The patches and ACKs are accumulated on this branch: git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-stericsson.git pl022 If you want to make a huge bundle to send to Grant, please pull this into your tree. Thanks, Linus

Re: [PATCH v2] spi: Fix device unregistration when unregistering the bus master

2011-12-13 Thread Linus Walleij
unregistered. Fix this by registering devices as direct children of the bus master. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij

[GIT PULL] PL022 patches for 3.3

2011-12-13 Thread Linus Walleij
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Grant, can you please pull in my PL022 patch stack that has been floated on the list recently into your SPI for-next branch? Thanks! Linus Walleij The following changes since commit caca6a03d365883564885f2c1da3e88dcf65d139: Linux 3.2-rc3

[PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-17 Thread Linus Walleij
found in jornada720_ssp is probably not going to play well with the SPI subsystem so this has been replaced by a mutex. Cc: Kristoffer Ericson kristoffer.eric...@gmail.com Cc: Nicolas Pitre nicolas.pi...@linaro.org Cc: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Linus Walleij linus.wall

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-18 Thread Linus Walleij
functionality. It'd be nice if you could make the branch available once you push that stuff to -next. Yours, Linus Walleij -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning

Re: [PATCH] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-01-19 Thread Linus Walleij
On Wed, Jan 18, 2012 at 1:30 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 18, 2012 at 01:13:29PM +0100, Linus Walleij wrote: We usually merge drivers for microwire, TI, Motorola ... etc into drivers/spi as well. It's a good enough fit, the differences are very small

[PATCH] spi/pl022: Add high priority message pump support

2012-01-24 Thread Linus Walleij
by measurements. Realtime priority elevation for a certain PL022 port can be requested from platform data. Signed-off-by: Chris Blair chris.bl...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c| 77

Re: [PATCH] spi/pl022: Add high priority message pump support

2012-01-26 Thread Linus Walleij
On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown broo...@sirena.org.uk wrote: On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote: This switches the PL022 worker to a kthread in order to get hold of a mechanism to control the message pump priority. On low-latency systems elevating

[PATCH 0/3] spi: generalize message queueing

2012-02-02 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This is a patch series based on a suggestion from Mark Brown to make the message queueing found in PL022 more general. [1/3] is just the same minor update to the PL022 driver that was discussed before (I hope this can atleast go in). [2/3] refactors

[PATCH 2/3] spi: split spi_register_master

2012-02-02 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This splits the spi_register_master() function in two parts, easing the addition of a queued master and making the code somewhat easier to read. Cc: Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Linus Walleij linus.wall...@linaro.org

[PATCH 3/3] spi: create an optional message queueing infrastructure

2012-02-02 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread will need to select the symbol SPI_MASTER_QUEUE and implement three methods in place

Re: [PATCH 3/3] spi: create an optional message queueing infrastructure

2012-02-03 Thread Linus Walleij
so we do need different logic. Yes atleast for now, I looked at the per-transfer pump we have but I cannot right now figure out if that part can also be genericizied so lets do it piecemal. Fixing the comment in v2. Thanks, Linus Walleij

Re: [PATCH 3/3] spi: create an optional message queueing infrastructure

2012-02-03 Thread Linus Walleij
? OK I'll post v2 soon with these changes. Thanks, Linus Walleij -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio

[PATCH v2] spi: create a message queueing infrastructure

2012-02-03 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread will need to define the new per-messags transfer methods and leave the deprecated transfer

Re: [PATCH] spi/s3c64xx: Convert to using core message queue

2012-02-15 Thread Linus Walleij
On Wed, Feb 15, 2012 at 11:48 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Convert the s3c64xx driver to using the new message queue factored out of the pl022 driver by Linus Walleij, saving us a nice block of code and getting the benefits of improvements implemented in the core

Re: [PATCH v2] spi: create a message queueing infrastructure

2012-02-15 Thread Linus Walleij
On Fri, Feb 3, 2012 at 3:03 PM, Linus Walleij linus.wall...@stericsson.com wrote: From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread

[PATCH v3] spi: create a message queueing infrastructure

2012-02-22 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread will need to define the new per-messags transfer methods and leave the deprecated transfer

Re: [PATCH] spi/s3c64xx: Convert to using core message queue

2012-02-22 Thread Linus Walleij
On Wed, Feb 15, 2012 at 11:48 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Convert the s3c64xx driver to using the new message queue factored out of the pl022 driver by Linus Walleij, saving us a nice block of code and getting the benefits of improvements implemented in the core

Re: [PATCH v3] spi: create a message queueing infrastructure

2012-03-06 Thread Linus Walleij
On Wed, Feb 22, 2012 at 10:05 AM, Linus Walleij linus.wall...@stericsson.com wrote: From: Linus Walleij linus.wall...@linaro.org This rips the message queue in the PL022 driver out and pushes it into (optional) common infrastructure. Drivers that want to use the message pumping thread

Re: [PATCH] spi: bitbang: convert to using core message queue

2012-03-18 Thread Linus Walleij
g.liakhovet...@gmx.de This is great stuff! Acked-by: Linus Walleij linus.wall...@linaro.org (Since I've never really used the bitbang driver I wouldn't trust me to do any deeper review.) Quick thought: +static int spi_bitbang_dummy_prepare(struct spi_master *master) +{ +       return 0

Re: [PATCH] SPI/Pl022: Include types.h to remove compilation warnings

2012-03-23 Thread Linus Walleij
-by: Viresh Kumar viresh.ku...@st.com Looks reasonable! Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here http

Re: [PATCH/RFC] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
and fixes up taking the above regulators. That said I'm all for replacing it - but I'd need to figure out the details on how to do that. We do have code for ux500 power domains. If it will will be enough to handle this I can try to hack it up and submit it. Yours, Linus Walleij

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
is really lost... And I do like the change, if for nothing else so for the fact that it eventually pushes to power domains what belongs there, so: Acked-by: Linus Walleij linus.wall...@linaro.org But to the defence: power domain code was not in the kernel when the AMBA vcore regulator

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
On Sun, Apr 1, 2012 at 9:39 PM, Rabin Vincent ra...@rab.in wrote: On Mon, Apr 2, 2012 at 00:52, Linus Walleij linus.wall...@linaro.org wrote: Combined with the PL022 patch this causes a power regression since the PL022 is hereafter always on. How can there be a power regression here

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Linus Walleij
On Sun, Apr 1, 2012 at 11:27 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sun, Apr 01, 2012 at 09:22:50PM +0200, Linus Walleij wrote: Combined with the PL022 patch this causes a power regression since the PL022 is hereafter always on. I guess this code isn't in mainline

Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-02 Thread Linus Walleij
On Mon, Apr 2, 2012 at 12:43 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Apr 02, 2012 at 11:14:28AM +0100, Mark Brown wrote: On Mon, Apr 02, 2012 at 12:39:11AM +0200, Linus Walleij wrote: Mark: as Rabin says the v1 patch is probably fine, are you pushing this to ARM

Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

2012-04-17 Thread Linus Walleij
message is incorrect, that prints range is from 1 to 16. Fix both these issues. Signed-off-by: Vinit Shenoy vinit.she...@st.com --- V1-V2: - Fixed the check:        if (pl022-vendor-max_bpw = 32) - Re-written complete range check logic. Looks correct to me: Acked-by: Linus Walleij

Re: [PATCH] spi: bitbang: convert to using core message queue

2012-04-18 Thread Linus Walleij
On Wed, Apr 11, 2012 at 10:56 PM, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Hi Grant On Tue, 20 Mar 2012, Grant Likely wrote: On Mon, 19 Mar 2012 00:33:14 +0100, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Mar 17, 2012 at 12:39 AM, Guennadi Liakhovetski g.liakhovet

Re: [PATCH] spi: pl022: Allow request for higher frequency than maximum possible

2012-04-19 Thread Linus Walleij
max possible. But should program it to max possible. Reported-by: Vinit Kamalaksha Shenoy vinit.she...@st.com Signed-off-by: Viresh Kumar viresh.ku...@st.com Looks reasonable and mostly harmless :-) Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated

2012-05-10 Thread Linus Walleij
drivers to populate empty functions to prevent crashing. This patch prevents the call to prepare/unprepare if not populated. Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Great! Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware.

2012-05-14 Thread Linus Walleij
; +               uint64_t clkdiv:13; +               uint64_t reserved_29_63:35; +#endif This boggles my mind, but I see there are many drivers doing this, but using uint64_t looks overly scary. Can't you break it apart using a set of u32's like in drivers/net/ethernet/micrel/ksz884x.c? Yours, Linus Walleij

Re: [PATCH] SPI: PRIMA2: use the newest APIs of PINCTRL to fix compiling errors

2012-05-15 Thread Linus Walleij
declaration of function 'pinmux_put' make[3]: *** [drivers/spi/spi-sirf.o] Error 1 Signed-off-by: Barry Song baohua.s...@csr.com Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Linus Walleij linus.wall...@linaro.org Acked-by: Linus Walleij linus.wall...@linaro.org Counting on Grant to pick

Re: [PATCH 3/3] spi: bitbang: convert to using core message queue

2012-05-21 Thread Linus Walleij
g.liakhovet...@gmx.de Acked-by: Linus Walleij linus.wall...@linaro.org Thanks, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed

Re: [PATCH 2/9] SPI: Refactor spi-orion to use SPI framework queue.

2012-06-11 Thread Linus Walleij
On Sun, Jun 10, 2012 at 12:31 PM, Andrew Lunn and...@lunn.ch wrote: Replace the deprecated master-transfer with transfer_one_message() and allow the SPI subsystem handle all the queuing of messages. Signed-off-by: Andrew Lunn and...@lunn.ch Acked-by: Linus Walleij linus.wall...@linaro.org

[PATCH 2/3] spi/pl022: delete DB5500 support

2012-06-12 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org This ASIC variant has been deleted from the ARM tree, no need to keep support around. Cc: Vinit Shenoy vinit.she...@st.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 14 -- 1 file changed, 14

[PATCH 3/3] spi/pl022: enable runtime PM

2012-06-12 Thread Linus Walleij
From: Linus Walleij linus.wall...@linaro.org If we're gonna use runtime PM it's a pretty good idea to actually enable it in probe() and disable it in remove() too, so it gets used for real. Up until now we only fooled around with the reference count. Cc: Vinit Shenoy vinit.she...@st.com Signed

[PATCH v2] RFC: spi/sa1100: rewrite the SA1100 SPI driver

2012-06-13 Thread Linus Walleij
found in jornada720_ssp is probably not going to play well with the SPI subsystem so this has been replaced by a mutex. Cc: Kristoffer Ericson kristoffer.eric...@gmail.com Cc: Nicolas Pitre nicolas.pi...@linaro.org Cc: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Linus Walleij linus.wall

Re: [PATCH] spi/pl022: cleanup pl022 header documentation

2012-06-17 Thread Linus Walleij
-by: Roland Stigge sti...@antcom.de Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks for fixing this! Grant, will you please pick this to the SPI tree. Yours, Linus Walleij -- Live Security Virtual Conference

Re: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER

2012-06-18 Thread Linus Walleij
-by: Roland Stigge sti...@antcom.de Acked-by: Linus Walleij linus.wall...@linaro.org Should this patch be joined with gpiolib-of's patch to of_get_named_gpio()? Or should they just be issued as a series? If it's not bisectable unless you change this in the same patch then join them. Else I'd put

Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

2012-06-25 Thread Linus Walleij
. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint

Re: [PATCH] spi: Unlock a spinlock before calling into the controller driver.

2012-06-25 Thread Linus Walleij
before making the call. Rework the logic a bit to hold queue_lock to protect the 'busy' flag, then release it to call unprepare_transfer_hardware(). Signed-off-by: Bryan Freed bfr...@chromium.org Yes, this looks correct to me! Good catch. Acked-by: Linus Walleij linus.wall...@linaro.org Yours

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Linus Walleij
On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Elegant, monsieur. Acked-by: Linus Walleij linus.wall...@linaro.org I'm starting

[GIT PULL] PL022 patches for v3.6

2012-07-05 Thread Linus Walleij
) Alexandre Pereira da Silva (1): spi/pl022: cleanup pl022 header documentation Linus Walleij (2): spi/pl022: delete DB5500 support spi/pl022: enable runtime PM Virupax Sadashivpetimath (1): spi/pl022: disable port when unused drivers/spi/spi-pl022.c| 23

Re: [PATCH RFC] spi/gpio: start with CS non-active

2012-07-09 Thread Linus Walleij
a difference. ping You probably want to resend this with Linus W in the CCs. It all makes sense to me so: Acked-by: Linus Walleij linus.wall...@linaro.org Now the SPI maintainer needs to pick it up though, if your proposal to pick it up goes through this patch is all yours now. Yours, Linus

Fwd: [GIT PULL] PL022 patches for v3.6

2012-07-10 Thread Linus Walleij
Hi Mark, Can you please pull in these PL022 patches to your spi-next tree? Yours, Linus Walleij -- Forwarded message -- From: Linus Walleij linus.wall...@linaro.org Date: Thu, Jul 5, 2012 at 4:27 PM Subject: [GIT PULL] PL022 patches for v3.6 To: Wolfram Sang w.s

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-08-04 Thread Linus Walleij
...@secretlab.ca Cc: Linus Walleij linus.wall...@stericsson.com From a GPIO point of view this looks good to me. Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference

[PATCH] spi/pl022: fix spi-pl022 pm enable at probe

2012-08-17 Thread Linus Walleij
Signed-off-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-pl022.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index aab518e..6abbe23 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2053,7 +2053,6

Re: [PATCH] spi/pl022: Fill master-dev.of_node to get spi devices registered via DT

2012-08-18 Thread Linus Walleij
patches for the moment. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Linus Walleij
++) + pl022-chipselect[i] = -EINVAL; Why? Instead, add a int *chipselects; field to the struct pl022_ssp_controller platform data in include/linux/amba/pl022.h and copy it from there if num_chipselects in the same data != 0. (First patch.) Yours, Linus Walleij

Re: [PATCH RESEND v4] spi/pl022: add devicetree support

2012-08-20 Thread Linus Walleij
. At some point there has been a chip needing these to be set to some magic values. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [PATCH] spi/pl022: Fill master-dev.of_node to get spi devices registered via DT

2012-08-22 Thread Linus Walleij
On Wed, Aug 22, 2012 at 11:16 AM, Viresh Kumar viresh.ku...@linaro.org wrote: On 19 August 2012 03:56, Linus Walleij linus.wall...@linaro.org wrote: On Sat, Aug 18, 2012 at 4:25 AM, Viresh Kumar viresh.ku...@linaro.org Isn't this one of those things that *have* to be #ifdef CONFIG_OF? Next

Re: [PATCH v5 2/2] spi/pl022: Add devicetree support

2012-08-22 Thread Linus Walleij
property on all GPIO drivers. The rest looks good. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-08-22 Thread Linus Walleij
on the initial patch by Alexandre Pereira da Silva aletes@gmail.com Signed-off-by: Roland Stigge sti...@antcom.de Acked-by: Alexandre Pereira da Silva aletes@gmail.com Thanks Roland, excellent work! Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij

Re: [PATCH v6 3/3] DT bindings documentation: num-cs property for SPI controllers

2012-08-22 Thread Linus Walleij
-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH v6 2/3] spi/pl022: Add devicetree support

2012-08-22 Thread Linus Walleij
Silva aletes@gmail.com Reviewed-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-02 Thread Linus Walleij
as it is. And the other way too, since I'm not very picky.) Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how

Re: [PATCH v6 1/3] spi/pl022: Add chip select handling via GPIO

2012-09-03 Thread Linus Walleij
of pl022 is now int *). Do you get my point ? This would go way beyond memory allocated for chipselects. Yes of course ... how could I not see this. Sorry! Yours, Linus Walleij -- Live Security Virtual Conference Exclusive

Re: [PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-03 Thread Linus Walleij
) but to a multiple of bytes after it because of the (int *) type. Replacing the kludgy pointer arithmetic with managed memory allocation for the chip selects. Signed-off-by: Roland Stigge sti...@antcom.de Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks for fixing this! And thanks to Shiraz

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-03 Thread Linus Walleij
On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack zon...@gmail.com wrote: On 05.08.2012 21:12, Linus Walleij wrote: On Sun, Aug 5, 2012 at 1:57 PM, Daniel Mack zon...@gmail.com wrote: Acked-by: Linus Walleij linus.wall...@linaro.org Ok, thanks. Mark, did the patches reach you this time? I think

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-17 Thread Linus Walleij
clk_prepare/unprepare at probe and removed, so I guess what you're trying to say is that on your platform the clk_unprepare() process context call is needed to save power? Please elaborate... Yours, Linus Walleij -- Live

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-18 Thread Linus Walleij
bus. In some designs these two clocks are one and the same, and these won't currently get into any clock disabled states, sadly. (We need to fix that some day.) Yours, Linus Walleij -- Live Security Virtual Conference

Re: [PATCH 09/19] ARM: ux500: Enable SSP (SPI) for HREF when booting Device Tree

2012-09-18 Thread Linus Walleij
On Mon, Sep 17, 2012 at 7:03 PM, Roland Stigge sti...@antcom.de wrote: On 09/10/2012 01:11 PM, Linus Walleij wrote: It appears Roland has written his bindings such that DT data augments platform data (yes, I am also getting crazy about this prioritization, mea culpa for ACKing this without

Re: [PATCH v2 2/2] ARM: OMAP2+: Enable pinctrl dummy states

2012-09-18 Thread Linus Walleij
have pinmuxes configured before the drivers probe. Signed-off-by: Matt Porter mpor...@ti.com Looks like a good idea, so FWIW: Acked-by: Linus Walleij linus.wall...@linaro.org Yours, Linus Walleij -- Live Security Virtual

[PATCH] spi/pl022: adopt pinctrl support

2012-09-19 Thread Linus Walleij
vinit.she...@st.com Cc: Viresh Kumar viresh.ku...@arm.com Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- arch/arm/mach-u300/core.c | 3 --- drivers/spi/spi-pl022.c | 46 ++ 2 files

Re: [PATCH] spi: pl022: Add clk_{un}prepare() support in runtime PM

2012-09-20 Thread Linus Walleij
On Wed, Sep 19, 2012 at 5:31 AM, viresh kumar viresh.ku...@linaro.org wrote: On Tue, Sep 18, 2012 at 5:20 PM, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Sep 18, 2012 at 6:09 AM, viresh kumar viresh.ku...@linaro.org wrote: The amba layer is taking care of interface clock only

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
, during ordinary suspend the device is runtime resumed for example. Rafael, Magnus: help. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat

Re: [PATCH 2/2] ARM: ABMA: Disable/Enable interface clock from suspend/resume

2012-09-26 Thread Linus Walleij
) have choosen to call out to the AMBA level to make sure semantics are preserved. Yours, Linus Walleij -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
On Wed, Sep 26, 2012 at 2:19 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar SPI functional clock must be disalble/enable in non RTPM suspend/resume hooks. Currently

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Linus Walleij
On Wed, Sep 26, 2012 at 4:08 PM, viresh kumar viresh.ku...@linaro.org wrote: On Wed, Sep 26, 2012 at 5:49 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar SPI

[PATCH] spi/pl022: use more managed resources

2012-09-26 Thread Linus Walleij
This switches the PL022 SPI driver to use devm_* managed resources for IRQ, clocks, ioremap and GPIO. Prior to this, the GPIOs would even leak. Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- drivers/spi/spi-pl022.c | 31 ++- 1 file changed, 10

[PATCH] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
reference counter to 0, runtime resume having previously increased it to 1. Cc: Ulf Hansson ulf.hans...@linaro.org Cc: Vipul Kumar Samar vipulkumar.sa...@st.com Cc: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- Vipin: can you confirm

Re: [PATCH] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
! Yours, Linus Walleij -- Got visibility? Most devs has no idea what their production app looks like. Find out how fast your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219671;13503038;y? http

[PATCH v2] spi/pl022: get/put resources on suspend/resume

2012-09-26 Thread Linus Walleij
reference counter to 0, runtime resume having previously increased it to 1. Cc: Vipul Kumar Samar vipulkumar.sa...@st.com Cc: Viresh Kumar viresh.ku...@linaro.org Acked-by: Ulf Hansson ulf.hans...@linaro.org Signed-off-by: Linus Walleij linus.wall...@stericsson.com --- ChangeLog v1-v2: - Add more

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-09-30 Thread Linus Walleij
-pl022 ssp0: Unbalanced pm_runtime_enable! Signed-off-by: Michel JAOUEN michel.jao...@stericsson.com Signed-off-by: Linus Walleij linus.wall...@linaro.org Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Yours, Linus Walleij

Re: [PATCH 2/3] Revert spi/pl022: enable runtime PM

2012-09-30 Thread Linus Walleij
On Fri, Sep 28, 2012 at 1:21 PM, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 2fb30d1147c599f5657e8c62c862f9a0f58d9d99. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Reviewed-by: Linus Walleij linus.wall...@linaro.org Thanks

  1   2   3   >