[PATCH] spi/s3c64xx: Log error interrupts

2011-11-28 Thread Mark Brown
and this code is much simpler. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 56 +++- 1 files changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index dcf7e10

[PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 39

[PATCH 1/2] spi/s3c64xx: Convert to dev_pm_ops

2011-12-05 Thread Mark Brown
In preparation for the addition of runtime PM ops. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index

[PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops

2011-12-05 Thread Mark Brown
In preparation for the addition of runtime PM ops. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index

[PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 39

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2011-12-05 Thread Mark Brown
and this code is much simpler. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 56 +++- 1 files changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi

Re: [PATCH 2/2] spi/s3c64xx: Implement runtime PM support

2011-12-05 Thread Mark Brown
On Mon, Dec 05, 2011 at 10:41:21PM +0100, Linus Walleij wrote: Just wanted to mention that I had this discussion with Magnus Damm about how they do this in shmobile: in there their central runtime PM policy in arch/arm/mach-shmobile/pm_runtime.c adds in the pm_clk_notifier from

Re: mc13xxx: add I2C support

2012-01-19 Thread Mark Brown
On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote: I've never looked at regmap deeply but can't it be done with regmap or is it just a bad idea ? Glancing quickly at the existing code it should map on reasonably well, though a new format definition may be required for the 25 bit

Re: mc13xxx: add I2C support

2012-01-20 Thread Mark Brown
On Fri, Jan 20, 2012 at 06:55:35PM +1100, Marc Reilly wrote: On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote: On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote: I've never looked at regmap deeply but can't it be done with regmap or is it just a bad idea

[PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
got dropped on the floor somewhere along the line. Mark Brown (3): spi/s3c64xx: Log error interrupts spi/s3c64xx: Convert to dev_pm_ops spi/s3c64xx: Implement runtime PM support drivers/spi/spi-s3c64xx.c | 115 1 files changed, 104

[PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
and this code is much simpler. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 57 +++- 1 files changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi

[PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
Enable and disable the clocks to the SPI controller using runtime PM. This serves the dual purpose of reducing power consumption a little and letting the core know when the device is idle. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall

[PATCH 2/3] spi/s3c64xx: Convert to dev_pm_ops

2012-01-21 Thread Mark Brown
In preparation for the addition of runtime PM ops. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index

Re: [PATCH 3/3] spi/s3c64xx: Implement runtime PM support

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 02:41:59PM +0100, Bill Gatliff wrote: What about using autosuspend instead? If a client is doing a lot of closely-spaced SPI transactions on a relatively flat device tree, might the resulting runtime suspend/resume overhead between each transaction become noticeable?

Re: [PATCH 0/3] spi/s3c64xx diagnostic and PM updates

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 07:27:23AM -0700, Grant Likely wrote: Pushed out to git://git.secretlab.ca/git/linux-2.6.git spi/merge. I'll ask Linus to pull in a couple of days after it has hit linux-next. Thanks. Obviously it'd be nice to get it into 3.3 but I don't see a huge rush and it did

Re: [PATCH 1/3] spi/s3c64xx: Log error interrupts

2012-01-21 Thread Mark Brown
On Sat, Jan 21, 2012 at 04:27:16PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:24 PM, Mark Brown wrote: - int ret; + int ret, irq; + char clk_name[16]; clk_name seems to be unused, otherwise looks good. That's git cherry-pick being too clever for me when I pulled this out

Re: [PATCH] spi/pl022: Add high priority message pump support

2012-01-25 Thread Mark Brown
On Tue, Jan 24, 2012 at 10:14:32PM +0100, Linus Walleij wrote: From: Chris Blair chris.bl...@stericsson.com This switches the PL022 worker to a kthread in order to get hold of a mechanism to control the message pump priority. On low-latency systems elevating the message kthread to realtime

Re: [PATCH] spi/pl022: Add high priority message pump support

2012-01-26 Thread Mark Brown
On Thu, Jan 26, 2012 at 03:48:59PM +0100, Linus Walleij wrote: On Wed, Jan 25, 2012 at 3:02 PM, Mark Brown broo...@sirena.org.uk wrote: It really feels like we should be pulling this into the core - lots of drivers use a workqueue to drive data through the system and they're all going

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Tue, Jan 31, 2012 at 04:54:06PM +0100, Tobias Klauser wrote: From: Frederic Lambert frdr...@gmail.com Until now we let the code in spi.c assign us the bus number if the platform device didn't specify its id. This patch adds the possibility to explicitely specify the bus number via device

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 03:01:53PM +0100, Frederic LAMBERT wrote: Don't top post! Because this bus number is used to create the device name on /sys/bus/spi/..., name that the user app must know to work with. Why must the user application know this? What is missing to allow the application to

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 03:25:33PM +0100, Frederic LAMBERT wrote: Because this bus number is used to create the device name on /sys/bus/spi/..., name that the user app must know to work with. Why must the user application know this? What is missing to allow the application to discover

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 03:53:00PM +0100, Frederic LAMBERT wrote: I wrote a piece of code that uses this nvSRAM as a persistent storage. This runs in a softcore embedded in an FPGA, in an equipment. The PC version of this application uses a simple file to emulate this behavior. The simulated

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 04:29:25PM +0100, Frederic LAMBERT wrote: To sumarize, I have a same code that works for the 3 architecture, the single difference being in the device name: /sys/proc/spi/drivers/at25/spi0.0/eeprom for Nios2 dataBase.dat on Linux /dev/sdb on the Virtual

Re: [PATCH] spi/spi-altera: Allow to explicitely override bus number via dts

2012-02-01 Thread Mark Brown
On Wed, Feb 01, 2012 at 04:52:14PM +0100, Frederic LAMBERT wrote: Yes, that seems simple said like that. It was thus more simple for me, at that time, to modify a specific driver for a specific port (Nios2), than to modify a core used by every one. Question of time, and confidence in my own

[PATCH] spi/s3c64xx: Convert to using core message queue

2012-02-15 Thread Mark Brown
Convert the s3c64xx driver to using the new message queue factored out of the pl022 driver by Linus Walleij, saving us a nice block of code and getting the benefits of improvements implemented in the core. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Only lightly tested thus

[PATCH] spi: Mark spi_register_board_info() __devinit

2012-02-17 Thread Mark Brown
than __devinit so this usage isn't legal. Change the annotation to __devinit to handle this. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index

[PATCH] spi: s3c64xx: Fix build

2012-03-14 Thread Mark Brown
Commit 054ebc (spi: Compatibility with direction which is used in samsung DMA operation) does not build as one hunk adds a brace to the first branch of an if statement without adding at least the correspoding close. Remove the unwanted brace. Signed-off-by: Mark Brown broo

[PATCH/RFC] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Mark Brown
currently there are no mainline systems which actually provide a vcore regulator so none need updating. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- RFC because there's some disagreement about this. drivers/amba/bus.c | 42

[PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support

2012-04-01 Thread Mark Brown
that it is enabled for these users, this is likely to have no impact on practical systems as probably at least one of these devices will be active and cause AMBA to hold the supply on anyway. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- Updated to add the always_on constraint

Re: [PATCH v5 2/4] mfd: mc13xxx-core: use regmap for register access

2012-04-02 Thread Mark Brown
On Sun, Apr 01, 2012 at 04:41:37PM +1000, Marc Reilly wrote: This change converts the mc13xxx core to use regmap rather than direct spi r/w. The spidev member of mc13xxx struct becomes redundant and is removed. Extra debugging aids are added to mc13xxx_reg_rmw. To repeat what I've said on

Re: [PATCH 10/10] spi: s3c64xx: add device tree support

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:54AM +0530, Thomas Abraham wrote: +- gpios: The gpio specifier for clock, mosi and miso interface lines (in no + particular order). The format of the gpio specifier depends on the gpio + controller. This seems odd... This isn't a bitbanging controller, and

Re: [PATCH 06/10] ARM: Samsung: Modify s3c64xx_spi{0|1|2}_set_platdata function

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:50AM +0530, Thomas Abraham wrote: + s3c64xx_spi0_set_platdata(s3c6410-spi, NULL, 0, 1); Shouldn't we just set the name in the struct platform_device rather than requiring the machine to pass it through by hand?

Re: [PATCH 05/10] ARM: Samsung: Update the device names for spi clock lookup

2012-05-09 Thread Mark Brown
On Wed, May 09, 2012 at 03:34:49AM +0530, Thomas Abraham wrote: With the addition of platform specific driver data in the spi-s3c64xx driver, the device name of spi controllers are changed. Accordingly, update the device name of spi clocks instances. This should've been squashed into the patch

[PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Mark Brown
Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c

[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites

2012-06-28 Thread Mark Brown
They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi

[PATCH 2/2] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites

2012-07-04 Thread Mark Brown
They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus

[PATCH] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Mark Brown
Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/spi

Re: [PATCH RFC] spi/gpio: start with CS non-active

2012-07-09 Thread Mark Brown
On Thu, Jul 05, 2012 at 09:45:40AM +0200, Uwe Kleine-K?nig wrote: On Thu, Feb 09, 2012 at 10:21:45PM +0100, Uwe Kleine-K?nig wrote: The chip select line was configured as output with the initial value being active explicitly. It was later deasserted during spi_bitbang_setup() without any

Re: [PATCH v4 5/6] spi: s3c64xx: Remove the 'set_level' callback from controller data

2012-07-10 Thread Mark Brown
On Tue, Jul 10, 2012 at 07:57:38PM +0530, Thomas Abraham wrote: The set_level callback in the controller data, which is used to configure the slave select line, cannot be supported when migrating the driver to device tree based discovery. Since all the platforms currently use gpio as the slave

Re: [PATCH 00/10] MXS SPI driver

2012-07-17 Thread Mark Brown
On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote: This patchset adds SPI master support for Freescale i.MX233/i.MX28. This is rebased on top of next-20120713. Please consider applying, bugs shall now be squashed during the previous two review rounds. Always CC maintainers, and in

Re: [PATCH 00/10] MXS SPI driver

2012-07-18 Thread Mark Brown
On Wed, Jul 18, 2012 at 12:09:54AM +0200, Marek Vasut wrote: On Mon, Jul 16, 2012 at 02:09:47PM +0200, Marek Vasut wrote: Always CC maintainers, and in this case me as well (I'm collecting SPI patches for this release since Grant's mostly offline). Ah, I wasn't aware you're the SPI

[PATCH 4/4] spi/s3c64xx: Expand S3C64XX_SPI_{DE, }ACT macros at call sites

2012-07-18 Thread Mark Brown
They have very few users and they're both just doing a single register write so the advantage of having the macro is a bit limited. An inline function might make sense but it's as easy to just do the writes directly. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus

[PATCH 1/4] spi/s3c64xx: Fix handling of errors in gpio_request()

2012-07-18 Thread Mark Brown
depriving the caller of information and breaking automatic probe deferral pushing back from the GPIO level. Also reformat the non-DT log message so it's not word wrapped and we can grep for it. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c |9

[PATCH 3/4] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-18 Thread Mark Brown
Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 18 +- 1 file changed, 1

[PATCH 2/4] spi/s3c64xx: Put the /CS GPIO into output mode

2012-07-18 Thread Mark Brown
to configure them. Without this fix Cragganmore systems can't talk to their SPI devices. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-s3c64xx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi

Re: [PATCH 1/2] SPI: spi-gpio: store chipselect information in private structure

2012-07-25 Thread Mark Brown
On Wed, Jul 25, 2012 at 01:44:11PM +0200, Daniel Mack wrote: The spi-gpio driver currently assumes the chipselect gpio number is stored in -controller_data of the device's static board information. Always CC maintainers on things... you've not CCed Grant or Linus W, and for now I'm handling

Re: [PATCH 1/2] SPI: spi-gpio: store chipselect information in private structure

2012-07-25 Thread Mark Brown
On Wed, Jul 25, 2012 at 10:00:18PM +0200, Daniel Mack wrote: I don't know what's wrong here, but clearly, the message in my inbox has To: spi-devel-general@lists.sourceforge.net Cc: grant.lik...@secretlab.ca, rob.herr...@calxeda.com, devicetree-disc...@lists.ozlabs.org,

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-01 Thread Mark Brown
On Mon, Jul 23, 2012 at 10:40:48PM +0200, Marek Vasut wrote: This is slightly reworked version of the SPI driver. Support for DT has been added and it's been converted to queued API. Looks reasonable overall. + bits_per_word = dev-bits_per_word; + if (t t-bits_per_word) +

Re: [PATCH 08/10 RESEND] spi: Add DMA support into SPI driver

2012-08-01 Thread Mark Brown
On Mon, Jul 23, 2012 at 10:40:50PM +0200, Marek Vasut wrote: + /* + * Small blocks can be transfered via PIO. + * Measured by empiric means: + * + * dd if=/dev/mtdblock0 of=/dev/null bs=1024k count=1 + * +

Re: [PATCH 06/10 V2] spi: Add SPI driver for mx233/mx28

2012-08-02 Thread Mark Brown
On Thu, Aug 02, 2012 at 04:58:38PM +0200, Marek Vasut wrote: It'd be nice to only keep the clocks enabled while doing transfers but again totally non-essential. Hm, this is spread across mxs. Shawn, is there any plan for PM implementation for MXS ? Take a look at s3c64xx - I did

Re: [PATCH] spi/s3c64xx: Add missing static storage class specifiers

2012-08-04 Thread Mark Brown
On Fri, Aug 03, 2012 at 10:08:12AM +0530, Sachin Kamat wrote: Silences the following sparse warnings: drivers/spi/spi-s3c64xx.c:1482:32: warning: Applied, thanks. -- Live Security Virtual Conference Exclusive live

Re: [PATCH resend 1/2] SPI: spi-gpio: store chipselect information in private structure

2012-08-04 Thread Mark Brown
On Wed, Aug 01, 2012 at 10:57:17PM +0200, Daniel Mack wrote: The spi-gpio driver currently assumes the chipselect gpio number is stored in -controller_data of the device's static board information. Applied both, thanks. It's a bit sad that we need an explict property for num-chipselects

Re: [PATCH] spi: omap2-mcspi: Fix the error handling in probe

2012-08-04 Thread Mark Brown
On Thu, Aug 02, 2012 at 04:41:25PM +0530, Shubhrajyoti D wrote: The kfree() is taken care of by the spi core (spi_master_release() function) that is called once the last reference to the underlying struct device has been released. So the driver need not call kfree. Applied, thanks.

Re: [RFC PATCH] spi/bcm63xx: Ensure that memory is freed only after it is no longer used

2012-08-13 Thread Mark Brown
On Fri, Aug 10, 2012 at 01:56:27PM -0700, Guenter Roeck wrote: The call to spi_unregister_master() in the device remove function frees device memory, and with it any device local data. However, device local data is still accessed after the call to spi_unregister_master(). Applied, thanks.

Re: [PATCH 00/10 V3] MXS SPI driver

2012-08-13 Thread Mark Brown
On Fri, Aug 03, 2012 at 05:26:05PM +0200, Marek Vasut wrote: This patchset adds SPI master support for Freescale i.MX233/i.MX28. This is rebased on top of next-20120713. Please consider applying, bugs shall now be squashed during the previous two review rounds. Do we have any ETA for review

Re: [PATCH] spi: spi-altera: Use of_match_ptr

2012-08-15 Thread Mark Brown
On Wed, Aug 15, 2012 at 08:09:07AM -0500, Rob Herring wrote: On 08/15/2012 02:30 AM, Tobias Klauser wrote: Instead of having to define the match table to NULL if CONFIG_OF isn't set, use the of_match_ptr() macro which will do this for us. Signed-off-by: Tobias Klauser tklau...@distanz.ch

Re: [PATCH] spi: spi-altera: Use of_match_ptr

2012-08-15 Thread Mark Brown
On Wed, Aug 15, 2012 at 09:30:28AM +0200, Tobias Klauser wrote: Instead of having to define the match table to NULL if CONFIG_OF isn't set, use the of_match_ptr() macro which will do this for us. Applied, thanks. --

Re: [PATCH] spi: spi-bcm63xx: Pass NULL to platform_set_drvdata

2012-08-16 Thread Mark Brown
On Thu, Aug 16, 2012 at 12:44:38PM +0200, Tobias Klauser wrote: platform_set_drvdata expects a void *, so pass NULL instead of 0. Signed-off-by: Tobias Klauser tklau...@distanz.ch Better yet, remove these calls - they're completely redundant.

Re: [PATCH 1/2] spi: spi-coldfire-qspi: Drop extra spi_master_put in device remove function

2012-08-17 Thread Mark Brown
On Thu, Aug 16, 2012 at 08:25:59PM -0700, Guenter Roeck wrote: The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which and results in device memory being freed. The subsequent call to spi_master_put is

Re: [PATCH] spi/pl022: fix spi-pl022 pm enable at probe

2012-08-17 Thread Mark Brown
On Fri, Aug 17, 2012 at 05:28:41PM +0200, Linus Walleij wrote: From: Michel JAOUEN michel.jao...@stericsson.com amba drivers does not need to enable pm runtime at probe. amba_probe already enables pm runtime. This rids this warning in the ux500 boot log: ssp-pl022 ssp0: Unbalanced

Re: [PATCH] spi: omap2-mcspi: Remove the call to platform_set_drvdata(pdev, NULL)

2012-08-17 Thread Mark Brown
On Thu, Aug 16, 2012 at 08:49:30PM +0530, Shubhrajyoti D wrote: Remove the call of platform_set_drvdata(pdev, NULL) as they are not needed anymore. Applied, thanks. These calls were never *needed* people just like to put them in.

Re: [PATCH] spi/mxs: Fix device remove function

2012-08-25 Thread Mark Brown
On Fri, Aug 24, 2012 at 01:37:39PM -0700, Guenter Roeck wrote: For some reason most spi drivers have similar problems. I learned it the hard way when I tested my own driver, and decided to fix as many drivers as I can. Which is why you see all those patches from me lately. It's not exactly

Re: [PATCH] mxs/spi: Restart the block after unsuccessful transfer

2012-08-27 Thread Mark Brown
On Fri, Aug 24, 2012 at 04:34:18AM +0200, Marek Vasut wrote: Restart the SSP block in case the SSP transfer failed in any way. The block hung in some cases otherwise. Applied, thanks. -- Live Security Virtual

Re: [PATCH V3] mxs/spi: Fix misuse of init_completion

2012-08-27 Thread Mark Brown
On Fri, Aug 24, 2012 at 04:56:27AM +0200, Marek Vasut wrote: The init_completion() call does reinit not only the variable carrying the flag that the completion finished, but also initialized the waitqueue associated with the completion. On the contrary, the INIT_COMPLETION() call only reinits

Re: [PATCH 1/3] spi/stmp: Fix device remove function

2012-08-27 Thread Mark Brown
On Thu, Aug 23, 2012 at 08:08:47PM -0700, Guenter Roeck wrote: The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which results in device memory being freed. The remove function accesses the freed memory after

Re: [PATCH] mxs/spi: Add SPI slave mode operation DT prop

2012-08-27 Thread Mark Brown
On Fri, Aug 24, 2012 at 04:42:41AM +0200, Marek Vasut wrote: This allows user to select the slave mode of operation of the controller. This is by no means standard, see the binding documentation for details, there is plenty of them. Sadly, such knowledge is not provided in the chip

Re: [PATCH] spi/s3c64xx: Drop extra calls to spi_master_get in suspend/remove functions

2012-08-27 Thread Mark Brown
On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote: Suspend and resume functions call spi_master_get() without matching spi_master_put(). The extra references are unnecessary and cause subsequent module unload attempts to fail. Drop the calls. Applied, thanks.

Re: [PATCH] spi/mxs: Fix device remove function

2012-08-27 Thread Mark Brown
On Fri, Aug 24, 2012 at 11:03:02AM -0700, Guenter Roeck wrote: The call sequence spi_alloc_master/spi_register_master/spi_unregister_master is complete; it reduces the device reference count to zero, which results in device memory being freed. The remove function accesses the freed memory after

Re: [PATCH resend 2/2] SPI: spi-gpio: Add DT bindings

2012-09-04 Thread Mark Brown
On Mon, Sep 03, 2012 at 01:50:34PM +0200, Linus Walleij wrote: On Sun, Sep 2, 2012 at 10:17 PM, Daniel Mack zon...@gmail.com wrote: Hmm, I don't know whether anyone took those patches yet? Mark? Mark better take them, ping on Mark. IIRC I did reply saying that the patches didn't apply for

Re: [PATCH RESEND-2 1/2] SPI: spi-gpio: store chipselect information in private structure

2012-09-05 Thread Mark Brown
On Wed, Sep 05, 2012 at 11:04:35AM +0200, Daniel Mack wrote: The spi-gpio driver currently assumes the chipselect gpio number is stored in -controller_data of the device's static board information. Applied both, thanks.

Re: [PATCH 0/4] mxs/spi: Fixes and improvements

2012-09-05 Thread Mark Brown
On Tue, Sep 04, 2012 at 04:40:14AM +0200, Marek Vasut wrote: I humbly present fixes for further issues found in the SPI driver for i.MX23/i.MX28. Applied all, thanks. -- Live Security Virtual Conference Exclusive live

Re: [PATCH 1/4] drivers/spi/spi-sh-hspi.c: drop frees of devm_ alloc'd data

2012-09-05 Thread Mark Brown
On Sat, Sep 01, 2012 at 06:33:08PM +0200, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr devm free functions should not have to be explicitly used. Applied, thanks. -- Live Security Virtual Conference

Re: [PATCH] spi/pl022: Fix chipselects pointer computation

2012-09-05 Thread Mark Brown
On Mon, Sep 03, 2012 at 10:14:29AM +0200, Roland Stigge wrote: The new chip select handling via GPIO introduced a pointer computation bug: Applied, thanks. -- Live Security Virtual Conference Exclusive live event will

Re: [PATCH] spi: spi-tle62x0: Use module_spi_driver macro

2012-09-05 Thread Mark Brown
On Tue, Sep 04, 2012 at 04:58:35PM +0530, Sachin Kamat wrote: module_spi_driver eliminates module_init and module_exit calls and makes the code simpler. Applied, thanks. -- Live Security Virtual Conference Exclusive

Re: [PATCH] mxs/spi: Fix misuse of init_completion

2012-09-05 Thread Mark Brown
On Wed, Aug 22, 2012 at 10:57:45PM +0200, Marek Vasut wrote: Signed-off-by: Marek Vasut ma...@denx.de Applied, thanks. -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security

[PATCH] spi/gpio: Fix stub for spi_gpio_probe_dt()

2012-09-06 Thread Mark Brown
The gpio_ was missing from the name. Add a name for the parameter while we're at it since GCC warns. Reported-by: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com --- drivers/spi/spi-gpio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-11 Thread Mark Brown
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. I'd ideally like some testing from the

Re: [PATCH] spi: omap2-mcspi: Cleanup the omap2_mcspi_txrx_dma function

2012-09-12 Thread Mark Brown
On Tue, Sep 11, 2012 at 12:13:20PM +0530, Shubhrajyoti D wrote: Currently in omap2_mcspi_txrx_dma the tx and the rx support is interleaved. Make the rx related code in omap2_mcspi_rx_dma and the tx related code omap2_mcspi_tx_dma and call the functions. Applied, thanks.

Re: [PATCH 5/5] ASoC: tegra: remove support of legacy DMA driver based access

2012-09-14 Thread Mark Brown
On Thu, Sep 13, 2012 at 05:36:30PM -0600, Stephen Warren wrote: Please note that I've applied this to Tegra's for-3.7/dmaengine branch, even though it hasn't been ack'd by an ASoC maintainer. Please don't apply this without review, we've got quite enough problems with the dmaengine stuff as it

Re: [PATCH 4/5] spi: tegra: remove support of legacy DMA driver based access

2012-09-14 Thread Mark Brown
On Thu, Sep 06, 2012 at 05:50:07PM -0600, Stephen Warren wrote: On 08/16/2012 08:13 AM, Laxman Dewangan wrote: Remove the support code which uses the legacy APB DMA driver for accessing the SPI FIFO. The driver will use the dmaengine based APB DMA driver for accessing reqding/writing to

Re: [PATCH 4/5] spi: tegra: remove support of legacy DMA driver based access

2012-09-14 Thread Mark Brown
On Fri, Sep 14, 2012 at 09:57:48AM -0600, Stephen Warren wrote: On 09/06/2012 05:50 PM, Stephen Warren wrote: I'd like to take this patch through the Tegra tree, since it relies on the previous Tegra patches to convert to dmaengine. Could I please get an ack if that's OK? Thanks. I'm

Re: [PATCH 5/5] ASoC: tegra: remove support of legacy DMA driver based access

2012-09-14 Thread Mark Brown
On Fri, Sep 14, 2012 at 09:57:35AM -0600, Stephen Warren wrote: On 09/06/2012 05:50 PM, Stephen Warren wrote: I'd like to take this patch through the Tegra tree, since it relies on the previous Tegra patches to convert to dmaengine. Could I please get an ack if that's OK? Thanks. I'm

Re: [PATCH 5/5] ASoC: tegra: remove support of legacy DMA driver based access

2012-09-14 Thread Mark Brown
On Fri, Sep 14, 2012 at 10:00:39AM -0600, Stephen Warren wrote: But do note that I pinged 8 days ago for an ack, and received no objections, and you were well aware that the bug was fixed since you I didn't read these mails enough to notice that they were asking for an ack, they were followups

Re: [PATCH RESEND 4/5] spi: tegra: remove support of legacy DMA driver based access

2012-09-17 Thread Mark Brown
FIFO. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH RESEND 5/5] ASoC: tegra: remove support of legacy DMA driver based access

2012-09-17 Thread Mark Brown
FIFO. Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com -- Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can

Re: [PATCH] spi/pl022: adopt pinctrl support

2012-09-20 Thread Mark Brown
On Wed, Sep 19, 2012 at 02:23:46PM +0200, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@stericsson.com Amend the PL022 pin controller to optionally take a pin control handle and set the state of the pins to default on boot and runtime resume, and to sleep at runtime suspend.

Re: [RFC PATCH 13/13] Documentation: add schedule for removing private EDMA API

2012-09-20 Thread Mark Brown
On Thu, Sep 20, 2012 at 10:43:46AM -0400, Matt Porter wrote: Documentation/feature-removal-schedule.txt | 10 ++ 1 file changed, 10 insertions(+) We decided at kernel summit that we'd stop bothering with this, it's mostly just bitrot and rarely read. I guess the ASoC driver update

Re: [PATCH resend] spi core: Provide means to instantiate devices through sysfs

2012-09-22 Thread Mark Brown
On Mon, Sep 17, 2012 at 04:51:20PM -0700, Guenter Roeck wrote: The I2C core provides a means to instantiate devices from userspace using sysfs attributes. Provide the same mechanism for SPI devices. So, unlike I2C this is only going to work for a subset of controllers - anything that relies on

Re: [PATCH] spi: s3c64xx: Don't free controller_data on non-dt platforms

2012-09-22 Thread Mark Brown
On Thu, Sep 13, 2012 at 04:31:30PM +0200, Sylwester Nawrocki wrote: When s3c64xx-spi is instantiated from device tree an instance of struct s3c64xx_spi_csinfo is dynamically allocated in the driver. Applied, thanks. --

Re: [PATCH] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-24 Thread Mark Brown
On Mon, Sep 24, 2012 at 08:34:27AM +0200, Dirk Behme wrote: Being not so familiar with the flow of SPI patches, I was told that you are taking care of spi patches recently? Do you like to have a look to this patch? Well, nobody appears to have sent me a copy of it...

Re: [PATCH] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-25 Thread Mark Brown
On Mon, Sep 24, 2012 at 01:31:22PM +0200, Dirk Behme wrote: Let me know if you can find above thread on one of the both mailing lists. If not, I would be happy to resend it again. Yes, of course - it's hard to apply patches from web archives.

Re: [PATCH 1/2] spi:pl022: Disable/Enable functional clock from suspend/resume

2012-09-26 Thread Mark Brown
On Wed, Sep 26, 2012 at 02:17:36PM +0200, Linus Walleij wrote: On Wed, Sep 26, 2012 at 1:24 PM, Vipul Kumar Samar SPI functional clock must be disalble/enable in non RTPM suspend/resume hooks. Currently it is only done for RTPM cases. This patch add support to disable/enbale clock for

Re: [PATCH] spi/pl022: use more managed resources

2012-09-28 Thread Mark Brown
On Wed, Sep 26, 2012 at 04:48:36PM +0200, Linus Walleij wrote: This switches the PL022 SPI driver to use devm_* managed resources for IRQ, clocks, ioremap and GPIO. Prior to this, the GPIOs would even leak. Applied, thanks.

Re: [PATCH v2] spi/pl022: get/put resources on suspend/resume

2012-09-28 Thread Mark Brown
On Wed, Sep 26, 2012 at 06:06:22PM +0200, Linus Walleij wrote: This factors out the resource handling in runtime suspend/resume and also calls it from the ordinary suspend and resume hooks. Applied, thanks. -- Got

Re: [PATCH v2] spi/imx: set the inactive state of the clock according to the clock polarity

2012-09-28 Thread Mark Brown
On Tue, Sep 25, 2012 at 01:21:57PM +0200, Dirk Behme wrote: From: Knut Wohlrab knut.wohl...@de.bosch.com There are SPI devices which need a SPI clock with active low polarity and high inactive state. Applied, thanks.

Re: [PATCH] spi: remove completely broken Tegra driver

2012-10-01 Thread Mark Brown
On Mon, Oct 01, 2012 at 03:11:41PM +0530, Laxman Dewangan wrote: It will be great if this goes in k3.7 so that we can post the new driver on K3.8. Why would this make any difference to the ability to post a new version? I do wish stop making up version numbers, it's very irritating. I

Re: [PATCH] spi: remove completely broken Tegra driver

2012-10-01 Thread Mark Brown
On Fri, Sep 28, 2012 at 10:15:48AM -0600, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com The current SPI driver has many issues. Examples are: Applied, thanks. -- Got visibility? Most devs has no idea

[GIT PULL] SPI updates for 3.7

2012-10-02 Thread Mark Brown
Mark Brown (4): spi/gpio: Fix stub for spi_gpio_probe_dt() Merge tag 'v3.6-rc6' into spi-drivers Merge tag 'v3.6-rc6' into spi-mxs Merge branches 'spi-drivers' and 'spi-mxs' into spi-next Matt Porter (1): spi: omap2-mcspi: add pinctrl support Patrice Chotard (1

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable

Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe

2012-10-03 Thread Mark Brown
On Wed, Oct 03, 2012 at 04:28:34PM +0200, Ulf Hansson wrote: I will do a resend and include some explanation for the reverts in the cover-letter. It'd be good if the explanation could be in the commit logs so that people reading history can understand things.

  1   2   >