Re: [Spice-devel] [Qxl PATCH] Change surfaces allocation method.

2010-08-18 Thread Yonit Halperin
On 08/17/2010 05:36 PM, Alexander Larsson wrote: On Tue, 2010-08-17 at 14:26 +0300, Yonit Halperin wrote: The driver no longer claims to support DirectDraw. It uses mspace to allocate surfaces and not HeapVidMemAllocAligned. This fixes freedesktop bug #29254. Ack (although you should git rm

Re: [Spice-devel] [PATCH] server: remove unnecessary dependency between surfaces and Glz drawables

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-11 at 14:21 +0300, Yonit Halperin wrote: Fixes freedesktop bug #28568 --- Ack, although it would be nice to split this into two commits. One that removes the unnecessary red_clear_surface_glz_drawables() calls and moves the red_destroy_surface() call to release_drawable, which

Re: [Spice-devel] [PATCH] spice: vdagent: support x64 arch

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: /* 7.18.1.4 Integer types capable of holding object pointers */ +#ifndef _WIN64 + typedef int intptr_t; typedef unsigned uintptr_t; +#endif + So, the win64 compiler supports (u)intptr_t, but the win32 one doesn't?

Re: [Spice-devel] [PATCH] spice: vdagent: return error code -1 on service install/uninstall failure #576625

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa agil...@agilboa.usersys.redhat.com --- Ack -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alexander Larsson
On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa agil...@agilboa.usersys.redhat.com -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size bug in VDService::handle_pipe_data()

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Attila Sukosd
Sorry for hijacking this, but whats the irc server/channel name? Cheers, Attila On Wed, Aug 18, 2010 at 2:15 PM, Alexander Larsson al...@redhat.com wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa agil...@agilboa.usersys.redhat.com -currently supports

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Gerd Hoffmann
On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboaagil...@agilboa.usersys.redhat.com -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in VDAgent::read_completion() handle multi-chunk msgs -fix chunk size

Re: [Spice-devel] [PATCH] vdagent: use vdagent.h

2010-08-18 Thread Arnon Gilboa
Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboa agil...@agilboa.usersys.redhat.com --- common/vdcommon.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/common/vdcommon.h b/common/vdcommon.h index 2e4ed5d..ba9d0ec

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alon Levy
- Gerd Hoffmann kra...@redhat.com wrote: On 08/18/10 14:15, Alexander Larsson wrote: On Mon, 2010-08-09 at 12:58 +0300, Arnon Gilboa wrote: From: Arnon Gilboaagil...@agilboa.usersys.redhat.com -currently supports text only (UTF8) -add VDAgent::dispatch_message() -in

Re: [Spice-devel] [PATCH] spice: vdagent: add basic clipboard support

2010-08-18 Thread Alexander Larsson
On Wed, 2010-08-18 at 14:18 +0200, Attila Sukosd wrote: Sorry for hijacking this, but whats the irc server/channel name? #spice on gimpnet -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Alexander LarssonRed Hat, Inc

[Spice-devel] [Qxl PATCH] aligning surfaces stride to 4

2010-08-18 Thread Yonit Halperin
--- display/res.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/display/res.c b/display/res.c index 3fe5fe6..6be006e 100644 --- a/display/res.c +++ b/display/res.c @@ -600,15 +600,17 @@ _inline void GetSurfaceMemory(PDev *pdev, UINT32 x, UINT32 y, UINT32