В Втр, 31/08/2010 в 17:00 +0200, Alexander Larsson пишет:
> After some delays due to holidays we today proudly released Spice 0.6.0.
> This is the beginning of a new stable series based on the new spice
> network protocol major version. It has some new exciting features like
> offscreen surfaces an
After some delays due to holidays we today proudly released Spice 0.6.0.
This is the beginning of a new stable series based on the new spice
network protocol major version. It has some new exciting features like
offscreen surfaces and WAN mode, as well as a more solid codebase and a
saner qemu inte
- al...@redhat.com wrote:
> From: Alexander Larsson
>
> When scaling part of an image we need to specify the source
> coordinates in transformed coordinates. For large magnifications this
> means we will get pretty large values.
>
> Now, if e.g. src_x * transform is larger than 32765, then
v2:
use qdev.reset instead of old API.
diff --git a/hw/spice-vmc.c b/hw/spice-vmc.c
index 434c70f..0636973 100644
--- a/hw/spice-vmc.c
+++ b/hw/spice-vmc.c
@@ -189,6 +189,15 @@ static void vmc_print_optional_subtypes(void)
fprintf(stderr, "\n");
}
+static void vmc_reset(DeviceState *opaqu
ack.
On 08/31/2010 01:17 PM, Alon Levy wrote:
v3:
allocate to maximal size on start (even if default is smaller)
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..79f5e6d 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
R
v3:
allocate to maximal size on start (even if default is smaller)
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..79f5e6d 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
RedClient& _client;
};
+uint32_t default_agent_ca
Hi,
Sorry, but still no ack...
On 08/31/2010 12:42 PM, Alon Levy wrote:
v2:
use new[]
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..9a3b0ed 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
RedClient& _client;
};
v2:
use new[]
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..9a3b0ed 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
RedClient& _client;
};
+uint32_t default_agent_caps[] = {
+(1 << VD_AGENT_CAP_MOUSE_STATE) |
+
On Tue, 2010-08-31 at 10:29 +0300, Yonit Halperin wrote:
> This will prevent: 1) rendering problems (commands sent to the client in the
> wrong order)
> 2) sending commands for surfaces that haven't been created yet on the client
> side.
> ---
Ack.
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
On Tue, 2010-08-31 at 11:59 +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> server/red_parse_qxl.c | 14 ++
> 1 files changed, 14 insertions(+), 0 deletions(-)
Ack
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Alexander Larsson
From: Alexander Larsson
When scaling part of an image we need to specify the source
coordinates in transformed coordinates. For large magnifications this
means we will get pretty large values.
Now, if e.g. src_x * transform is larger than 32765, then the
coordinate ends up outside the pixman 16b
From: Alexander Larsson
This reverts commit e13be77f33609cb3fdae354ce1f2686ae865f9e0.
---
common/sw_canvas.c | 136 ---
1 files changed, 32 insertions(+), 104 deletions(-)
diff --git a/common/sw_canvas.c b/common/sw_canvas.c
index 0d4367e..a92cff
From: Alexander Larsson
After a talk with soeren i came up with a better fix for the
scaling issue that doesn't have to create the sub-image. Instead
we embed the src coordinate offset in the transform. I thought
I tried this before and it ended up not using the scaling fast-path,
however that is
Signed-off-by: Gerd Hoffmann
---
server/red_parse_qxl.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c
index e6e700b..e0eba20 100644
--- a/server/red_parse_qxl.c
+++ b/server/red_parse_qxl.c
@@ -820,6 +820,13
On 08/31/2010 12:46 PM, Gerd Hoffmann wrote:
While we are at it: How should surfaces_dest (and surfaces_rect) be
filled for spice 0.4 commands? Right now they are just zero-initialized
(see red_get_compat_drawable() in red_parse_qxl.c).
Best to fill surfaces_dest with -1. For consistency (thoug
Hi,
On 08/31/2010 10:30 AM, Alon Levy wrote:
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..e1a322e 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
RedClient& _client;
};
+uint32_t default_agent_caps[] = {
+(1<<
While we are at it: How should surfaces_dest (and surfaces_rect) be
filled for spice 0.4 commands? Right now they are just zero-initialized
(see red_get_compat_drawable() in red_parse_qxl.c).
Best to fill surfaces_dest with -1. For consistency (though not
necessary right now), in QXL_COPY_BITS s
Hi All,
As you know my first week I've been working on setting up
a live migration test environment (not that I've run much tests
yet).
I thought it would be good to document what I did / how to
create a similar setup. This is intended to be put at:
http://spice-space.org/page/Howtos
But before
On 08/31/2010 11:24 AM, Gerd Hoffmann wrote:
On 08/31/10 10:11, Yonit Halperin wrote:
On 08/31/2010 11:05 AM, Gerd Hoffmann wrote:
+static inline int is_drawable_independent_from_surfaces(Drawable
*drawable)
+{
+ int x;
+
+ for (x = 0; x< 3; ++x) {
+ if (drawable->surfaces_dest[x] != -1) {
+ re
diff --git a/client/red_client.cpp b/client/red_client.cpp
index 6c6e066..e1a322e 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -75,6 +75,12 @@ private:
RedClient& _client;
};
+uint32_t default_agent_caps[] = {
+(1 << VD_AGENT_CAP_MOUSE_STATE) |
+(1 << VD_AGENT_C
Hi,
+drawable->surfaces_dest[0] = -1;
+drawable->surfaces_dest[1] = - 1;
+drawable->surfaces_dest[2] = -1;
ACK. No need to push, I'll add it in when preparing .v18 today.
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.f
On 08/31/10 10:11, Yonit Halperin wrote:
On 08/31/2010 11:05 AM, Gerd Hoffmann wrote:
+static inline int is_drawable_independent_from_surfaces(Drawable
*drawable)
+{
+ int x;
+
+ for (x = 0; x< 3; ++x) {
+ if (drawable->surfaces_dest[x] != -1) {
+ return FALSE;
+ }
+ }
+ return TRUE;
+}
What h
Hi,
I've pushed two patches (right now just on spice.v17, should be on
spice.kvm.v14 too) that change the required flags to spicevmc.
The new syntax requires you to specify a subtype argument, only value right
now is vdagent. So:
-device spicevmc,subtype=vdagent
instead of just
-device sp
On 08/31/2010 11:05 AM, Gerd Hoffmann wrote:
+static inline int is_drawable_independent_from_surfaces(Drawable
*drawable)
+{
+ int x;
+
+ for (x = 0; x< 3; ++x) {
+ if (drawable->surfaces_dest[x] != -1) {
+ return FALSE;
+ }
+ }
+ return TRUE;
+}
What happens if this meets qemu without the surf
+static inline int is_drawable_independent_from_surfaces(Drawable *drawable)
+{
+int x;
+
+for (x = 0; x< 3; ++x) {
+if (drawable->surfaces_dest[x] != -1) {
+return FALSE;
+}
+}
+return TRUE;
+}
What happens if this meets qemu without the surfaces ini
Hi,
SpiceCoreInterface doesn't allow creation/removal of devices and
chardevs.
I don't think allowing spice client add/remove guest devices is a good idea.
Right now it seems to be the right direction - add some
calls (two) for that, following qemu API closely (exactly).
Following qemu A
This will prevent: 1) rendering problems (commands sent to the client in the
wrong order)
2) sending commands for surfaces that haven't been created yet on the client
side.
---
server/red_worker.c | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/server/red_w
---
spice-display.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/spice-display.c b/spice-display.c
index fec2432..fed2056 100644
--- a/spice-display.c
+++ b/spice-display.c
@@ -72,6 +72,9 @@ SimpleSpiceUpdate
*qemu_spice_create_update(SimpleSpiceDisplay *ssd)
dr
Hi,
And again 1 small nitpick.
On 08/30/2010 05:00 PM, Alon Levy wrote:
diff --git a/vdagent/vdagent.cpp b/vdagent/vdagent.cpp
index b1f47c0..634f3a0 100644
--- a/vdagent/vdagent.cpp
+++ b/vdagent/vdagent.cpp
@@ -37,6 +37,8 @@ private:
VDAgent();
void input_desktop_message_loop();
Hi,
Correction make that 1 small nitpick and one bug found, see below.
On 08/30/2010 04:57 PM, Alon Levy wrote:
diff --git a/client/red_client.cpp b/client/red_client.cpp
index b6a412e..72b5909 100644
--- a/client/red_client.cpp
+++ b/client/red_client.cpp
@@ -328,6 +328,8 @@ RedClient::RedClie
Hi,
2 small nitpicks, see inline comments.
On 08/30/2010 04:55 PM, Alon Levy wrote:
diff --git a/spice/vd_agent.h b/spice/vd_agent.h
index 1fcda88..9b79f0f 100644
--- a/spice/vd_agent.h
+++ b/spice/vd_agent.h
@@ -64,6 +64,8 @@ enum {
VD_AGENT_REPLY,
VD_AGENT_CLIPBOARD,
VD_AGE
31 matches
Mail list logo
