Sorry, I resend because I missed subject.
---
If SPICE_SERVER_VERSION < 0.6.0, occur error unused variable
'streaming_video'.
So, move streaming_video to block.
---
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 813cc10..1b51924 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -325,7 +
On Thu, Oct 28, 2010 at 04:00:48PM +0200, Hans de Goede wrote:
> Hi,
>
> Please do *not* push these yet, I first want to create
> a spice-0.6 branch in git for doing 0.6.x bugfix releases.
>
> Thanks!
sure. Anyhow the major parts haven't been reviewed yet (9,10,11,12)
>
> I'll try do get this
Hi,
Please do *not* push these yet, I first want to create
a spice-0.6 branch in git for doing 0.6.x bugfix releases.
Thanks!
I'll try do get this done before this weekend.
Regards,
Hans
On 10/27/2010 06:36 PM, Alon Levy wrote:
Please try to review the channel even though it is big and not
Ack, I remember these lines from somewhere;)
Hans de Goede wrote:
These rarely happen as most apps have the decency to do a SetSelectionOwner
None before exiting. But some do not, so listen for these too.
---
client/x11/platform.cpp | 18 +++---
1 files changed, 15 insertions(+),
On 10/27/2010 06:36 PM, Alon Levy wrote:
---
python_modules/ptypes.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py
index 0ae57ec..9c4b7de 100644
--- a/python_modules/ptypes.py
+++ b/python_modules/ptypes.py
@@ -24
On Thu, Oct 28, 2010 at 11:03:51AM +0200, Gerd Hoffmann wrote:
> >+#ifdef USE_SMARTCARD
> >+#define SUBTYPE_SMARTCARD "smartcard"
> >+#endif
>
> Any reason to make this a compile time option in the spice server?
> I think there isn't any external dependency, correct?
> I'd prefer to not have those
These rarely happen as most apps have the decency to do a SetSelectionOwner
None before exiting. But some do not, so listen for these too.
---
client/x11/platform.cpp | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/client/x11/platform.cpp b/client/x11/pla
+#ifdef USE_SMARTCARD
+#define SUBTYPE_SMARTCARD "smartcard"
+#endif
Any reason to make this a compile time option in the spice server?
I think there isn't any external dependency, correct?
I'd prefer to not have those ifdefs all over the place ...
cheers,
Gerd
___
On 10/27/10 18:36, Alon Levy wrote:
+channel SmartcardChannel : BaseChannel {
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 10/27/10 18:36, Alon Levy wrote:
+static void spice_server_char_device_remove_interface(SpiceBaseInstance *sin)
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/ma
On 10/27/10 18:36, Alon Levy wrote:
+red_printf("CHAR_DEVICE %s", char_device->subtype);
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-d
On 10/27/10 18:36, Alon Levy wrote:
--- /dev/null
+++ b/server/char_device.h
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 10/27/10 18:36, Alon Levy wrote:
-int spice_server_char_device_add_interface(SpiceServer *s,
+static int spice_server_char_device_add_interface(SpiceServer *s,
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists
On 10/27/10 18:36, Alon Levy wrote:
-red_printf("vdi port already attached");
+red_printf("vdagent already attached");
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
htt
On 10/27/10 18:36, Alon Levy wrote:
+#ifndef __SPICE_EXPERIMENTAL_H__
+#define __SPICE_EXPERIMENTAL_H__
Acked-by: Gerd Hoffmann
cheers,
Gerd
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listi
15 matches
Mail list logo
