[Spice-devel] [PATCH v2 0/2] Fix unsafe access to a drawable

2011-07-12 Thread Yonit Halperin
Hi, This version is more efficient since it removes the other_drawable from the tree before red_handle_drawable_surfaces_client_synced is called. In this manner, other_drawable won't be unnecessarily rendered if update_area is called. Yonit Halperin (2): server: fix access to a released

[Spice-devel] [PATCH v2 1/2] server: fix access to a released drawable. RHBZ #713474

2011-07-12 Thread Yonit Halperin
red_pipe_add_drawable can lead to removal of drawables from current tree (since it calls red_handle_drawable_surfaces_client_synced), which can also lead to releasing these drawables. Before the fix, red_current_add_equal, called red_pipe_add_drawable, without assuring afterwards that the

[Spice-devel] [PATCH v2 2/2] server: add missing calls to red_handle_drawable_surfaces_client_synced

2011-07-12 Thread Yonit Halperin
red_handle_drawable_surfaces_client_synced was called only from red_pipe_add_drawable, while it should also be called from red_pipe_add_drawable_after. Otherwise, the client might receive a command with a reference to a surface it doesn't hold and crash. --- server/red_worker.c |2 ++ 1

[Spice-devel] Dual head issues with Win7 Guests...

2011-07-12 Thread Naga Mohan Pothula
Hi, I did setup Dual head environment for Win7 guests with Spice v0.8.1,  and using Qemu v0.14.0. I'm facing few issues with this environment. 1.)  I've noticed Secondary display is disconnected by default. I'm trying to Extend /Disconnect Displays at win7 Guest based on physical monitors

[Spice-devel] [PATCHv4] server/red_worker: *_release_item: less frequent debug messages

2011-07-12 Thread Alon Levy
--- server/red_worker.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 9a61e86..8ae89a2 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9140,7 +9140,7 @@ static void display_channel_release_item(RedChannel

[Spice-devel] [PATCHv4] server/red_worker: remove print on handle_dev_destroy_surfaces

2011-07-12 Thread Alon Levy
--- server/red_worker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 8ae89a2..d8d032d 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9541,7 +9541,7 @@ static inline void

[Spice-devel] [PATCHv4] server: add async io support

2011-07-12 Thread Alon Levy
The new _ASYNC io's in qxl_dev listed at the end get six new api functions, and an additional callback function async_complete. When the async version of a specific io is used, completion is notified by calling async_complete, and no READY message is written or expected by the dispatcher.

[Spice-devel] [PATCHv4] server: add QXLInterface::update_area_complete callback

2011-07-12 Thread Alon Levy
when update_area_async is called update_area_complete will be called with the surfaces dirty rectangle list. --- server/red_worker.c | 60 +- server/spice.h |3 ++ 2 files changed, 47 insertions(+), 16 deletions(-) diff --git

[Spice-devel] [PATCHv4] server: add QXLWorker.flush_surfaces_async for S3/S4 support

2011-07-12 Thread Alon Levy
This does the following, all to remove any referenced memory on the pci bars: flush_all_qxl_commands(worker); flush_all_surfaces(worker); red_wait_outgoing_item((RedChannel *)worker-display_channel); red_wait_outgoing_item((RedChannel *)worker-cursor_channel); The added api is

[Spice-devel] [PATCHv4] server/spice.h: bump QXL_MINOR because of QXLWorker and QXLInterface changes

2011-07-12 Thread Alon Levy
--- server/spice.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/server/spice.h b/server/spice.h index da147cd..d88307b 100644 --- a/server/spice.h +++ b/server/spice.h @@ -89,7 +89,7 @@ struct SpiceCoreInterface { #define SPICE_INTERFACE_QXL qxl #define

Re: [Spice-devel] [PATCH] mjpeg_encoder: allocate row on demand

2011-07-12 Thread Andrea Celestino
Which version of libjpeg I should use? If I use libjpeg8, I receive this compile error: mjpeg_encoder.c:178:13: error: static declaration of 'jpeg_mem_dest' follows non-static declaration /usr/include/jpeglib.h:956:14: note: previous declaration of 'jpeg_mem_dest' was here Thanks. 2011/7/6