Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Christophe Fergeau
On Thu, Jul 14, 2011 at 10:50:49AM +0300, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT, tested on F15. What use case do you have in mind for this? Is it meant for

Re: [Spice-devel] merge spice-protocol master to 0.8

2011-07-18 Thread Christophe Fergeau
Hi, On Sun, Jul 17, 2011 at 06:12:57PM +0300, Alon Levy wrote: Going over all the changes in master from 0.8 branch, there is nothing that breaks an old client or server afaict. Can anyone give a good reason not to git merge master 0.8? Yes, I went through these commits too and didn't spot

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: On Thu, Jul 14, 2011 at 10:50:49AM +0300, Alon Levy wrote: Add a backtrace printing function copied from xserver os/backtrace.c that uses gstack which seems to be available enough that xserver uses it :) Used in ASSERT,

Re: [Spice-devel] merge spice-protocol master to 0.8

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 10:28:13AM +0200, Christophe Fergeau wrote: Hi, On Sun, Jul 17, 2011 at 06:12:57PM +0300, Alon Levy wrote: Going over all the changes in master from 0.8 branch, there is nothing that breaks an old client or server afaict. Can anyone give a good reason not to

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Christophe Fergeau
On Mon, Jul 18, 2011 at 11:57:47AM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: What use case do you have in mind for this? Is it meant for use during development when something asserts but we forgot to run it in gdb? Or do you want to get more

Re: [Spice-devel] merge spice-protocol master to 0.8

2011-07-18 Thread Liang Guo
2011/7/18 Alon Levy al...@redhat.com: On Mon, Jul 18, 2011 at 10:28:13AM +0200, Christophe Fergeau wrote: Hi, On Sun, Jul 17, 2011 at 06:12:57PM +0300, Alon Levy wrote:  Going over all the changes in master from 0.8 branch, there is nothing  that breaks an old client or server afaict. Can

Re: [Spice-devel] [PATCH] common: add backtrace via gstack

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 11:13:50AM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 11:57:47AM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 10:13:27AM +0200, Christophe Fergeau wrote: What use case do you have in mind for this? Is it meant for use during development when

Re: [Spice-devel] [PATCH 1/5] client: s/recive/receive

2011-07-18 Thread Christophe Fergeau
Ping for this series? On Fri, Jul 08, 2011 at 12:17:28PM +0200, Christophe Fergeau wrote: --- client/red_channel.cpp | 32 client/red_channel.h |6 +++--- client/red_peer.cpp|8 client/red_peer.h |4 ++-- 4 files changed,

Re: [Spice-devel] [PATCH] Fix spice-server/qemu channel version checks

2011-07-18 Thread Christophe Fergeau
Ping? On Fri, Jul 08, 2011 at 03:58:28PM +0200, Christophe Fergeau wrote: When qemu creates a channel, reds.c contains code to check the minor/major channel versions known to QEMU (ie the ones that were current in spice-server when QEMU was compiled) and to compare these versions against the

Re: [Spice-devel] [PATCH 5/5] client: don't crash when agent is missing WAN support

2011-07-18 Thread Alon Levy
On Fri, Jul 08, 2011 at 12:17:32PM +0200, Christophe Fergeau wrote: If you try to connect to a linux guest with WAN options, SPICE window opens up and is blank - it then fails with vdagent timeout message. It should give a warning that this is only applicable for windows guest and still

Re: [Spice-devel] [PATCH 3/5] x11: don't return freed memory from get_clipboard

2011-07-18 Thread Alon Levy
On Fri, Jul 08, 2011 at 12:17:30PM +0200, Christophe Fergeau wrote: There is a double free in client/x11/platform.cpp. In get_selection(), in the exit: case with ret_val == -1 and data != NULL, *data_ret (which is returned to the caller) has already been assigned data, so it will be pointing

Re: [Spice-devel] [PATCH 5/5] client: don't crash when agent is missing WAN support

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 05:28:26PM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 05:51:30PM +0300, Alon Levy wrote: --- client/red_client.cpp | 28 1 files changed, 20 insertions(+), 8 deletions(-) diff --git a/client/red_client.cpp

Re: [Spice-devel] [PATCH 5/5] client: don't crash when agent is missing WAN support

2011-07-18 Thread Alon Levy
On Fri, Jul 08, 2011 at 12:17:32PM +0200, Christophe Fergeau wrote: If you try to connect to a linux guest with WAN options, SPICE window opens up and is blank - it then fails with vdagent timeout message. It should give a warning that this is only applicable for windows guest and still

Re: [Spice-devel] [PATCH 5/5] client: don't crash when agent is missing WAN support

2011-07-18 Thread Christophe Fergeau
On Mon, Jul 18, 2011 at 06:43:31PM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 05:28:26PM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 05:51:30PM +0300, Alon Levy wrote: @@ -1046,6 +1047,17 @@ void RedClient::on_agent_announce_capabilities( // not sending the

Re: [Spice-devel] [PATCH v2] common: add backtrace via gstack or glibc backtrace

2011-07-18 Thread Christophe Fergeau
On Mon, Jul 18, 2011 at 06:42:14PM +0300, Alon Levy wrote: diff --git a/common/spice_common.h b/common/spice_common.h index bc74486..6c5154c 100644 --- a/common/spice_common.h +++ b/common/spice_common.h @@ -22,9 +22,11 @@ #include stdint.h #include time.h #include stdlib.h +#include

Re: [Spice-devel] [PATCH] Fix spice-server/qemu channel version checks

2011-07-18 Thread Christophe Fergeau
On Mon, Jul 18, 2011 at 05:47:11PM +0300, Alon Levy wrote: On Mon, Jul 18, 2011 at 04:16:59PM +0200, Christophe Fergeau wrote: Ping? ACK. Pushed, thanks. Christophe pgpQxg54YZVzi.pgp Description: PGP signature ___ Spice-devel mailing list

Re: [Spice-devel] [PATCH v2] common: add backtrace via gstack or glibc backtrace

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 06:21:43PM +0200, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 06:42:14PM +0300, Alon Levy wrote: diff --git a/common/spice_common.h b/common/spice_common.h index bc74486..6c5154c 100644 --- a/common/spice_common.h +++ b/common/spice_common.h @@ -22,9 +22,11

Re: [Spice-devel] Spice QXL Driver does not work for Windows 7

2011-07-18 Thread Alon Levy
On Mon, Jul 18, 2011 at 07:34:03PM +0200, Mario wrote: Hi, I was just trying to build the latest qxl windows drivers with the 0.8.0 protocol headers. I followed this guide exactly: http://spice-space.org/page/WinQXL I built the drivers for both Windows XP/x86 and Windows 7/x86. XP is

Re: [Spice-devel] [PATCH v2] common: add backtrace via gstack or glibc backtrace

2011-07-18 Thread Uri Lublin
On 07/18/2011 07:21 PM, Christophe Fergeau wrote: On Mon, Jul 18, 2011 at 06:42:14PM +0300, Alon Levy wrote: diff --git a/common/spice_common.h b/common/spice_common.h index bc74486..6c5154c 100644 --- a/common/spice_common.h +++ b/common/spice_common.h @@ -22,9 +22,11 @@ #includestdint.h