[Spice-devel] [PATCH 9/9] qxl: abstract object allocation away from surface/image/cursor code

This abstracts the object bo/surface allocation away from the user code. The idea is we can then plug in a KMS backend for this abstraction and mostly keep the surrounding code intact. This is probably the biggest change to the driver in terms of impact of KMS code on UMS code. At the moment I'm

[Spice-devel] [PATCH 8/9] qxl: add direct pointer from qxl surface to qxl screen

This is prep work to allow the cache to be bypassed for kms. Signed-off-by: Dave Airlie --- src/qxl_surface.c | 12 +++- src/qxl_surface.h | 3 ++- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index 90cf8c6..eaf1761 100644 --- a/sr

[Spice-devel] [PATCH 7/9] qxl: pass surface struct instead of ids in drawable functions.

this just changes it so we pass the surfaces not just the ids. Signed-off-by: Dave Airlie --- src/qxl_surface.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index d95054b..90cf8c6 100644 --- a/src/qxl_surfa

[Spice-devel] [PATCH 6/9] qxl_edid: add missing config.h

Signed-off-by: Dave Airlie --- src/qxl_edid.c | 4 1 file changed, 4 insertions(+) diff --git a/src/qxl_edid.c b/src/qxl_edid.c index de52f11..adaab61 100644 --- a/src/qxl_edid.c +++ b/src/qxl_edid.c @@ -44,6 +44,10 @@ *Dave Airlie */ +#ifdef HAVE_CONFIG_H +#include "config.h" +#

[Spice-devel] [PATCH 5/9] qxl: split common pre init code out from qxl pre init

This just moves the options parsing and color setup calls to a separate function. Signed-off-by: Dave Airlie --- src/qxl_driver.c | 76 +--- 1 file changed, 45 insertions(+), 31 deletions(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c ind

[Spice-devel] [PATCH 4/9] qxl: fix memory leak on driver exit.

We were leaking two allocations on driver exit. Signed-off-by: Dave Airlie --- src/qxl_driver.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index 9a8de82..73c7534 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -258,10 +25

[Spice-devel] [PATCH 3/9] qxl_surface: move to using struct to avoid ordering issues with typedef.

Signed-off-by: Dave Airlie --- src/qxl_surface.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qxl_surface.h b/src/qxl_surface.h index 450a563..e57d282 100644 --- a/src/qxl_surface.h +++ b/src/qxl_surface.h @@ -18,8 +18,8 @@ struct qxl_surface_t void *

[Spice-devel] [PATCH 2/9] qxl: pass qxl instead of surface cache to some functions

This is more preparation work for adding bo abstraction layer. Signed-off-by: Dave Airlie --- src/qxl.h | 4 ++-- src/qxl_driver.c | 2 +- src/qxl_surface.c | 13 +++-- src/qxl_uxa.c | 2 +- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/qxl.h b/src/

[Spice-devel] [PATCH 1/9] qxl: split surface struct out into its own header file.

This is just ground work for kms addition. Signed-off-by: Dave Airlie --- src/Makefile.am | 2 ++ src/qxl_surface.c | 48 +--- src/qxl_surface.h | 52 3 files changed, 55 insertions(+), 47 deletio

[Spice-devel] qxl X.org driver bo abstraction for user mode setting

Hi, Okay this is the next chunk of prep for getting KMS into the driver, the first 8 patches are just preparation work and moving stuff around, along with a couple of minor fixes. The big guy on the end adds the BO abstraction layer, and makes all the code use it, it doesn't contain any kms code

Re: [Spice-devel] xorg driver cleanups

> > Well the whitespace is possibly already there and I'm just moving it around! yeah its all cut-n-paste whitespace damage, so the current tree is hardly in a good place, I've cleaned up some of it in the moving code around. >> I guess I was also ignoring the small problems, that and that the fi

[Spice-devel] [PATCH spice-gtk] smartcard: do not register monitor before smartcard init

Never call vevent_get_next_vevent() before calling vcard_emul_init() Some mutexes are initialized in vevent_queue_init(), during emul_init() --- gtk/smartcard-manager.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/gtk/smartcard-manager.c

Re: [Spice-devel] spice crashes

Just one additional information about that. I have one host that uses > qemu-kvm-1.0.1 > spice-0.12.0 > spice-protocol-0.12.2 > usbredir-0.4.4 and this system runs with a Windows 7 spice guest now for 6 month without any crash/problem. On the client side it uses > virt-viewer 0.5.3 (can't remembe

Re: [Spice-devel] xorg driver cleanups

On Tue, Feb 26, 2013 at 3:48 AM, Alon Levy wrote: >> On 02/24/2013 11:31 PM, airl...@gmail.com wrote: >> > Hi, >> > >> > these patches just move code around in the X.org driver so it looks >> > more >> > like something that can be maintained, I'm going to start adding >> > KMS support >> > to it s

Re: [Spice-devel] xorg driver cleanups

> On 02/24/2013 11:31 PM, airl...@gmail.com wrote: > > Hi, > > > > these patches just move code around in the X.org driver so it looks > > more > > like something that can be maintained, I'm going to start adding > > KMS support > > to it soon and i'd like to get stuff split out a bit better with

Re: [Spice-devel] xorg driver cleanups

On Mon, Feb 25, 2013 at 03:31:08PM +1000, airl...@gmail.com wrote: > Hi, > > these patches just move code around in the X.org driver so it looks more > like something that can be maintained, I'm going to start adding KMS support > to it soon and i'd like to get stuff split out a bit better with an

Re: [Spice-devel] xorg driver cleanups

On 02/24/2013 11:31 PM, airl...@gmail.com wrote: > Hi, > > these patches just move code around in the X.org driver so it looks more > like something that can be maintained, I'm going to start adding KMS support > to it soon and i'd like to get stuff split out a bit better with an eye > towards >