[Spice-devel] how to use xf86-video-qxl driver

2013-09-11 Thread bigclouds
hi,all i have questions about xf86-video-qxl. 1.how to use it? 2.in its code, there are code related to XF86DRM. while XF86DRM is kernel driver. if xf86-video-qxl is related to kernel version . kernel 2.6.32 has no XF86DRM. thanks___ Spice-devel maili

Re: [Spice-devel] aSPICE for android with usbredir

2013-09-11 Thread i iordanov
Hello! At the moment aSPICE does not support usbredir. It is certainly something that I plan to support in the future, but I haven't even had a chance to explore the feasibility of such a feature on the Android platform. Cheers! iordan On Mon, Sep 9, 2013 at 10:22 PM, 李超 wrote: > hi: > Th

Re: [Spice-devel] [PATCH spice-gtk] proto: add fake last message in base channel

2013-09-11 Thread Yonit Halperin
Ack On 09/10/2013 05:27 PM, Marc-André Lureau wrote: This is actually for spice-common (although spice-gtk will need later then) and also spice-protocol On Tue, Sep 10, 2013 at 11:13 PM, Marc-André Lureau wrote: Make it explicit that 100 is the last value of the base channel messages. This a

Re: [Spice-devel] [PATCH spice-gtk] channel: use base handlers array

2013-09-11 Thread Marc-André Lureau
On Wed, Sep 11, 2013 at 11:34 AM, Christophe Fergeau wrote: > I'd kind some kind of check for parent_class->handle_msg being non-NULL > here. But it's really not necessary. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedeskt

Re: [Spice-devel] [PATCH spice-gtk 3/4] quic: precompute golomb codes

2013-09-11 Thread Marc-André Lureau
On Wed, Sep 11, 2013 at 11:12 AM, Christophe Fergeau wrote: > ACK > > On Tue, Sep 10, 2013 at 04:43:38PM +0200, Marc-André Lureau wrote: >> From: Marc-André Lureau >> >> We can avoid repetitive computation by using two precomputed array, of >> 4k each. hmm, I think it's 2k each actually, I'll ve

Re: [Spice-devel] [spice-gtk] implement new keyval protocol

2013-09-11 Thread Dietmar Maurer
> Who handles the keyval, do you have corresponding qemu or agent patch? > Or are you using this only with XSpice somehow? It would be nice if we could > get > the full picture before amending this. I just finished a first prototype: # git clone git://git.proxmox.com/git/spiceterm.git You need

Re: [Spice-devel] [PATCH spice-gtk] channel: use base handlers array

2013-09-11 Thread Christophe Fergeau
On Tue, Sep 10, 2013 at 04:49:02PM +0200, Marc-André Lureau wrote: > This allows to simplify a little bit derived class, to avoid overriding > handle_msg, and allows the base class more flexibility (for example for > filtering messages, as in the following patch) This would be much nicer to review

Re: [Spice-devel] [PATCH spice-gtk 3/4] quic: precompute golomb codes

2013-09-11 Thread Christophe Fergeau
ACK On Tue, Sep 10, 2013 at 04:43:38PM +0200, Marc-André Lureau wrote: > From: Marc-André Lureau > > We can avoid repetitive computation by using two precomputed array, of > 4k each. > --- > common/quic.c | 25 - > common/quic_family_tmpl.c | 22 +

Re: [Spice-devel] [PATCH spice-gtk 1/4] proto: comment future surface flags usage

2013-09-11 Thread Christophe Fergeau
On Tue, Sep 10, 2013 at 04:43:36PM +0200, Marc-André Lureau wrote: > --- > spice.proto | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice.proto b/spice.proto > index 5eede6b..8aa35c1 100644 > --- a/spice.proto > +++ b/spice.proto > @@ -425,6 +425,8 @@ flags8 string_flags { > }; >

Re: [Spice-devel] [PATCH spice-gtk 2/4] quic: compile with constant bpp

2013-09-11 Thread Christophe Fergeau
ACK On Tue, Sep 10, 2013 at 04:43:37PM +0200, Marc-André Lureau wrote: > From: Marc-André Lureau > > This simplifies a little bit function calling, and allows for compiler > to potentially specialize and optimize a bit better each version. > --- > common/quic_family_tmpl.c | 4 ++-- > common/q

Re: [Spice-devel] [PATCH spice-gtk 1/4] proto: comment future surface flags usage

2013-09-11 Thread Christophe Fergeau
ACK On Tue, Sep 10, 2013 at 04:43:36PM +0200, Marc-André Lureau wrote: > --- > spice.proto | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice.proto b/spice.proto > index 5eede6b..8aa35c1 100644 > --- a/spice.proto > +++ b/spice.proto > @@ -425,6 +425,8 @@ flags8 string_flags { > }

Re: [Spice-devel] [PATCH spice-gtk 4/4] canvas: use precomputed revers_bits

2013-09-11 Thread Christophe Fergeau
On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote: > From: Marc-André Lureau > > Thos function shows up in some profiling results, it seems we can > trivially replace it with a precomputed array of 256bytes. I forgot to ask, is the function less obvious in the profiling results a

Re: [Spice-devel] [PATCH spice-gtk 4/4] canvas: use precomputed revers_bits

2013-09-11 Thread Christophe Fergeau
On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote: > From: Marc-André Lureau > > Thos function shows up in some profiling results, it seems we can > trivially replace it with a precomputed array of 256bytes. > --- > common/canvas_base.c | 43 ++