Re: [Spice-devel] remote-viewer spice auth

2013-10-19 Thread Dietmar Maurer
> Current SASL implementation in Spice doesn't support username. > > > And you can still use tickets if you check for strlen(username) == 0 ? > > There is noneed to ask the user a username for the current methods. He > wouldn't do what to put there. Sure. That is why I asked if you would accept

Re: [Spice-devel] [PATCH v3 spice-gtk 1/2] cursor-channel.c: add cursor print function for debugging only (ifdefed)

2013-10-19 Thread Marc-André Lureau
ack series - Original Message - > --- > gtk/channel-cursor.c | 32 > 1 file changed, 32 insertions(+) > > diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c > index d1d2c34..66e91df 100644 > --- a/gtk/channel-cursor.c > +++ b/gtk/channel-cursor.c >

[Spice-devel] [PATCH v3 spice-gtk 1/2] cursor-channel.c: add cursor print function for debugging only (ifdefed)

2013-10-19 Thread Alon Levy
--- gtk/channel-cursor.c | 32 1 file changed, 32 insertions(+) diff --git a/gtk/channel-cursor.c b/gtk/channel-cursor.c index d1d2c34..66e91df 100644 --- a/gtk/channel-cursor.c +++ b/gtk/channel-cursor.c @@ -246,6 +246,35 @@ static void do_emit_main_context(GObje

[Spice-devel] [PATCH v3 spice-gtk 2/2] channel-cursor: mono cursors edge highlighting

2013-10-19 Thread Alon Levy
Fix 998529, mono (invert) cursors not visible on a black background, by doing simple edge detection on the cursor (this is done once when the cursor is changed and then cached, cursors are 32x32 generally) and thus having a cursor with contrast on both dark and light backgrounds. When (if) GDK get

Re: [Spice-devel] remote-viewer spice auth

2013-10-19 Thread Marc-André Lureau
- Original Message - > > > Would you accept a patch for that, or do you think above code is all we > > > need? > > > > We shouldn't ask username for the current auth methods. > > Why? Using SASL without username is a bit limited - or do I miss something? Current SASL implementation in

Re: [Spice-devel] remote-viewer spice auth

2013-10-19 Thread Dietmar Maurer
> > Would you accept a patch for that, or do you think above code is all we > > need? > > We shouldn't ask username for the current auth methods. Why? Using SASL without username is a bit limited - or do I miss something? And you can still use tickets if you check for strlen(username) == 0 ? _

Re: [Spice-devel] remote-viewer spice auth

2013-10-19 Thread Marc-André Lureau
Hi - Original Message - > > > Current remote viewer only ask for a password when connecting to a spice > session > > which requires auth: > > > > from virt-viewer-session-spice.c: > > > > case SPICE_CHANNEL_ERROR_AUTH: > > DEBUG_LOG("main channel: auth failure (wrong password?)")

[Spice-devel] remote-viewer spice auth

2013-10-19 Thread Dietmar Maurer
Current remote viewer only ask for a password when connecting to a spice session which requires auth: from virt-viewer-session-spice.c: case SPICE_CHANNEL_ERROR_AUTH: DEBUG_LOG("main channel: auth failure (wrong password?)"); int ret = virt_viewer_auth_collect_credentials(self