Re: [Spice-devel] [PATCH spice-gtk] continuation: fix make distcheck

2013-11-27 Thread Christophe Fergeau
On Tue, Nov 26, 2013 at 07:41:41PM +0100, Marc-André Lureau wrote: Since 0508f586, errno.h is included above #undef _FORTIFY_SOURCE. But it must be placed above system headers to take effect --- gtk/continuation.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[Spice-devel] spice-gtk release v0.22

2013-11-27 Thread Marc-André Lureau
Hi! The Spice team is pleased to release a new spice-gtk version 0.22, with the following highlights: - improve inverted cursor support - use system-wide trust certificate store - make sasl support work with other method than MD5 - fix some clipboard crasher, limit clipboard size - fix various

[Spice-devel] [PATCH spice-server] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
When creating a TLS socket, both spice-server and spice-gtk currently call SSL_CTX_new(TLSv1_method()). The TLSv1_method() function set the protocol version to TLS 1.0 exclusively. The correct way to support multiple protocol versions is to call SSLv23_method() in spite of its scary name. This

[Spice-devel] [PATCH spice-gtk] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
When creating a TLS socket, both spice-server and spice-gtk currently call SSL_CTX_new(TLSv1_method()). The TLSv1_method() function set the protocol version to TLS 1.0 exclusively. The correct way to support multiple protocol versions is to call SSLv23_method() in spite of its scary name. This

Re: [Spice-devel] [PATCH spice-server] Use TLS version 1.0 or better

2013-11-27 Thread Daniel P. Berrange
On Wed, Nov 27, 2013 at 05:23:53PM +0100, David Jaša wrote: When creating a TLS socket, both spice-server and spice-gtk currently call SSL_CTX_new(TLSv1_method()). The TLSv1_method() function set the protocol version to TLS 1.0 exclusively. The correct way to support multiple protocol versions

Re: [Spice-devel] [PATCH spice-server] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
Before writing these patches against git, I wrote them as patches to rpm packages on my system and I performed several tests. When both packages had the patch included, the TLS version in use was 1.2. When only one of them had the patch included, the TLS version falled back to 1.0 (same as status

Re: [Spice-devel] [PATCH spice-server] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
Daniel P. Berrange píše v St 27. 11. 2013 v 16:27 +: On Wed, Nov 27, 2013 at 05:23:53PM +0100, David Jaša wrote: When creating a TLS socket, both spice-server and spice-gtk currently call SSL_CTX_new(TLSv1_method()). The TLSv1_method() function set the protocol version to TLS 1.0

[Spice-devel] [PATCH spice-server v2] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
From fe1531dfae23baa6dfc8b88e08f273906196e1c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Ja=C5=A1a?= dj...@redhat.com Date: Wed, 27 Nov 2013 17:04:41 +0100 Subject: [PATCH] Use TLS version 1.0 or better When creating a TLS socket, both spice-server and spice-gtk currently call

Re: [Spice-devel] [PATCH spice-server v2] Use TLS version 1.0 or better

2013-11-27 Thread David Jaša
discard this misformatted message please. David Jaša píše v St 27. 11. 2013 v 17:39 +0100: From fe1531dfae23baa6dfc8b88e08f273906196e1c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Ja=C5=A1a?= dj...@redhat.com Date: Wed, 27 Nov 2013 17:04:41 +0100 Subject: [PATCH] Use TLS version 1.0 or

Re: [Spice-devel] [PATCH spice-server v2] Use TLS version 1.0 or better

2013-11-27 Thread Christophe Fergeau
On Wed, Nov 27, 2013 at 05:39:31PM +0100, David Jaša wrote: From fe1531dfae23baa6dfc8b88e08f273906196e1c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Ja=C5=A1a?= dj...@redhat.com Date: Wed, 27 Nov 2013 17:04:41 +0100 Subject: [PATCH] Use TLS version 1.0 or better When creating a TLS

[Spice-devel] Opus support, both series (0/4 take 6, and 0/6 take 4)

2013-11-27 Thread Jeremy White
Following are hopefully final versions of the sound rework code that adds Opus support. This patch series is different than the last as follows: 1. KR brace style is used everywhere 2. The codec creation parameters use an integer flag, rather than a pair of booleans 3. Claiming

[Spice-devel] [spice sound rework 2/4 (take 6)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-27 Thread Jeremy White
This makes celt optional, and paves the way to readily add additional codecs. Signed-off-by: Jeremy White jwh...@codeweavers.com --- README |1 - client/audio_channels.h | 12 ++- client/playback_channel.cpp | 59 ++--- client/record_channel.cpp | 69

[Spice-devel] [spice-common sound rework 1/4 (take 6)] Add a snd_codec interface to abstract the use of audio codecs such as celt.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- common/Makefile.am |7 ++ common/snd_codec.c | 277 common/snd_codec.h | 72 ++ configure.ac | 16 +++ 4 files changed, 372 insertions(+) create mode 100644

[Spice-devel] [spice-protocol opus support 1/6 (take 4)] Add support for the Opus codec

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- spice/enums.h|1 + spice/protocol.h |2 ++ 2 files changed, 3 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index f192e43..fdcffa8 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -325,6 +325,7 @@ typedef enum

[Spice-devel] [spice-gtk sound rework 4/4 (take 6)] Don't emit start signals if codec creation fails.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- gtk/channel-playback.c |4 +++- gtk/channel-record.c |4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/gtk/channel-playback.c b/gtk/channel-playback.c index 37e5c40..acb6e4e 100644 --- a/gtk/channel-playback.c

[Spice-devel] [spice-gtk sound rework 3/4 (take 6)] Use the new snd_codec interface to process encoded audio.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- README |2 +- configure.ac |8 +--- gtk/channel-playback.c | 59 - gtk/channel-record.c | 99 4 files changed, 49

[Spice-devel] [spice-common opus support 2/6 (take 4)] Add support for the Opus codec.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- common/Makefile.am |2 + common/snd_codec.c | 131 +--- common/snd_codec.h | 20 ++-- configure.ac |4 ++ spice.proto|1 + spice1.proto |1 + 6 files

[Spice-devel] [spice-gtk opus support 5/6 (take 4)] Add support for the Opus codec.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- gtk/Makefile.am|2 ++ gtk/channel-playback.c | 49 ++-- gtk/channel-record.c | 36 ++- 3 files changed, 39 insertions(+), 48 deletions(-) diff

[Spice-devel] [spice opus support 3/6 (take 4)] Add support for the Opus codec

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- client/audio_channels.h |3 +- client/audio_devices.h |8 --- client/platform.h |6 ++- client/playback_channel.cpp | 23 client/record_channel.cpp | 41 ++- client/x11/platform.cpp

[Spice-devel] [spice opus support 4/6 (take 4)] Fix typo; sampel -- sample

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- client/platform.h |4 ++-- client/windows/platform.cpp |8 client/windows/playback.cpp | 14 +++--- client/windows/playback.h |4 ++-- client/windows/record.cpp | 12 ++--

[Spice-devel] [qemu opus support 6/6 (take 4)] Add the ability to vary Spice playback and record rates, to facilitate Opus support.

2013-11-27 Thread Jeremy White
Signed-off-by: Jeremy White jwh...@codeweavers.com --- audio/spiceaudio.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index 5af436c..fceee50 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@