On Wed, Nov 12, 2014 at 12:46:40PM -0500, Marc-André Lureau wrote:
- Original Message -
On Wed, Nov 12, 2014 at 12:10:26PM -0500, Marc-André Lureau wrote:
- Original Message -
Hey,
On Sun, Nov 09, 2014 at 05:31:43PM +0100, Marc-André Lureau wrote:
On Wed, Nov 12, 2014 at 06:49:50PM +0100, Marc-André Lureau wrote:
On Wed, Nov 12, 2014 at 6:35 PM, Christophe Fergeau cferg...@redhat.com
wrote:
'git grep spice_channel_disconnect' gives:
doc/reference/spice-gtk-sections.txt:spice_channel_disconnect
gtk/channel-main.c:
Hey,
I've seen your comment saying that this patch is not working as
expected, however I had a comment related to the API doc, see below.
On Sun, Nov 09, 2014 at 10:00:39PM +0100, Marc-André Lureau wrote:
This function is somewhat useless, and dangerous since it is
calling g_object_unref() on
On Wed, Nov 12, 2014 at 05:56:26PM +0100, Marc-André Lureau wrote:
On Wed, Nov 12, 2014 at 5:08 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Rereading the commit log,
this movement seems unrelated to what you are fixing anyway?
It is related, since we change the state to
Il 19/09/2014 15:18, Fabio Fantoni ha scritto:
Il 12/09/2014 16:46, Fabio Fantoni ha scritto:
Il 08/07/2014 12:34, Fabio Fantoni ha scritto:
Il 08/07/2014 12:06, Fabio Fantoni ha scritto:
Il 08/07/2014 10:53, David Jaša ha scritto:
Hi,
On Út, 2014-07-08 at 10:13 +0200, Fabio Fantoni wrote:
Hey,
On Sun, Nov 09, 2014 at 10:00:38PM +0100, Marc-André Lureau wrote:
A channel is considered to be part of a session as long as it is
alive. However, this model is problematic, since library user may hold
channel references, and thus the channel will remain in the
session. Calling
On Thu, Nov 06, 2014 at 03:47:44PM -0600, Jonathon Jongsma wrote:
When connector properties got changed, those changes were not being
propagated to user-space. This pushes those chagnes up so that e.g. new
'chagnes' typo here.
Christophe
pgpUIQeZ4FyDT.pgp
Description: PGP signature
Il 13/11/2014 11:14, Fabio Fantoni ha scritto:
Il 19/09/2014 15:18, Fabio Fantoni ha scritto:
Il 12/09/2014 16:46, Fabio Fantoni ha scritto:
Il 08/07/2014 12:34, Fabio Fantoni ha scritto:
Il 08/07/2014 12:06, Fabio Fantoni ha scritto:
Il 08/07/2014 10:53, David Jaša ha scritto:
Hi,
On Út,
Hi
I already have patches fixing this. And yes, it will crash with newer spice-gtk
if virt-viewer doesn't have the fix.
(if we don't have this kind of fix, we will keep crashing in virt-manager, and
I yet have to check Boxes behaviour)
In any case, the current channel lifecycle model is
On Thu, Nov 13, 2014 at 08:40:22AM -0500, Marc-André Lureau wrote:
Hi
I already have patches fixing this. And yes, it will crash with newer
spice-gtk if virt-viewer doesn't have the fix.
(if we don't have this kind of fix, we will keep crashing in virt-manager,
and I yet have to check
Hi
- Original Message -
On Thu, Nov 13, 2014 at 08:40:22AM -0500, Marc-André Lureau wrote:
Hi
I already have patches fixing this. And yes, it will crash with newer
spice-gtk if virt-viewer doesn't have the fix.
(if we don't have this kind of fix, we will keep crashing in
Hey,
On Fri, Nov 07, 2014 at 10:17:11AM +0100, Javier Celaya wrote:
Hello
I resend the patch for the spice repository. I just realized I forgot to
remove a debug message from red_worker.c, sorry.
Thanks for the updated patches, they look good to me. There are 2 blank
lines at the end of
On Thu, Nov 13, 2014 at 3:03 PM, Marc-André Lureau mlur...@redhat.com
wrote:
I imagine delaying session_disconnect() in idle (while holding a ref)
could work, but will bring additional issues due to its async nature.
fwiw, delaying to idle actual disconnect works, and I will send the patch.
I
Hey,
On Wed, Nov 05, 2014 at 08:32:51AM -0600, Gilbert Standen wrote:
Hi, does your roadmap include providing support so that text can be
pasted from KVM host to Windows8 KVM Guest?
If you manually install spice-vdagent in your guest, this should work.
Christophe
pgp0N2yetQB1e.pgp
Hey, I just realized that this patch and the one for dnd of files with
unicode names were ACK'ed but had never been pushed, this is now done:
http://cgit.freedesktop.org/spice/win32/vd_agent/commit/?id=6c070843cb00635bc8bab5fd98b8fefb597e7557
Hello
There they go.
However, don't forget that, since spice-protocol is a submodule of spice-
common, once you push the commit for spice-protocol, the commit for spice-
common should point to it. The same with spice and spice-gtk in relation to
spice-common.
Regards
El Jueves, 13 de
Hi
On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau cferg...@redhat.com
wrote:
At first, I thought you meant that this function was no longer available
at all, causing an ABI break. After reading the full patch, it seems you
mean this function has no non-deprecated replacement. Indicating
On Wed, Nov 05, 2014 at 03:20:32PM +0100, Pavel Grunt wrote:
This commit introduces function for sending the message to the agent.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on:
http://lists.freedesktop.org/archives/spice-devel/2014-November/017821.html
v3:
-
On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com
wrote:
Ah, this is the bit I was missing thanks! The commit log needs to be
much more detailed and accurate, and mention explicitly the various code
paths involved to trigger the error, where the looping occurs, ...
Hey,
I wonder if we always want to do this kind of synchronization
automatically, or if it should be optional? This would mean a new
property on SpiceGtkSession which would be checked before sending the
layout.
On Wed, Nov 05, 2014 at 03:20:33PM +0100, Pavel Grunt wrote:
The keyboard
On Wed, Nov 05, 2014 at 08:54:00AM +0100, Pavel Grunt wrote:
The agent tries to set the appropriate keyboard layout
when the message is received.
RFE: https://bugs.freedesktop.org/show_bug.cgi?id=85332
---
depends on
Hey,
On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote:
On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau cferg...@redhat.com
wrote:
Ah, this is the bit I was missing thanks! The commit log needs to be
much more detailed and accurate, and mention explicitly the various
On Thu, Nov 13, 2014 at 04:43:26PM +0100, Marc-André Lureau wrote:
On Thu, Nov 13, 2014 at 10:15 AM, Christophe Fergeau cferg...@redhat.com
wrote:
It seems it could have stayed in the same place, but with the check
changed to _CONNECTING instead of != UNCONNECTED?
It is not the same
Hi,
Hey,
I wonder if we always want to do this kind of synchronization
automatically, or if it should be optional? This would mean a new
property on SpiceGtkSession which would be checked before sending the
layout.
I agree with you, it would be better to have it optional.
On Wed,
On Thu, Nov 13, 2014 at 6:38 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Hey,
On Thu, Nov 13, 2014 at 05:41:20PM +0100, Marc-André Lureau wrote:
On Thu, Nov 13, 2014 at 10:07 AM, Christophe Fergeau
cferg...@redhat.com
wrote:
Ah, this is the bit I was missing thanks! The commit
On Thu, Nov 13, 2014 at 09:03:15AM -0500, Marc-André Lureau wrote:
I imagine delaying session_disconnect() in idle (while holding a ref)
could work, but will bring additional issues due to its async nature.
Any other idea?
It seems delaying to idle works according to your other email. If
Hi
- Original Message -
On Sun, Nov 09, 2014 at 05:31:45PM +0100, Marc-André Lureau wrote:
Wait until the main channel is reset() before initiating a reconnect.
With the added precondition checks in previous patch, we hit the
following critical otherwise:
Hi
Please find the second version of the patchset to fix some migrations
and channel lifecycle issues.
This version addresses Christophe review:
- rename spice_session_set_migration()
- workaround virt-viewer disconnection crash with new lifecycle model
- various spelling, commit msg and
If the session has an ongoing migration, but it is disconnected,
abort it.
---
gtk/spice-session.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/gtk/spice-session.c b/gtk/spice-session.c
index 88bcacd..3e3f16d 100644
--- a/gtk/spice-session.c
+++ b/gtk/spice-session.c
@@ -1467,6
Those preconditions help to figure out several issues related to
migration.
---
gtk/channel-main.c | 2 ++
gtk/spice-channel.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 1ad090f..62e8905 100644
--- a/gtk/channel-main.c
+++
Track the migration session earlier, so that disconnecting before
migration finished will abort and release it.
---
gtk/channel-main.c | 6 +++---
gtk/spice-session-priv.h | 5 ++---
gtk/spice-session.c | 16
3 files changed, 13 insertions(+), 14 deletions(-)
diff
Before the signal is actually emitted, the channel may be
released. Let's keep a reference to the object during
the function time, to prevent the object from being destroyed before
calling g_signal_emit() in main context.
---
gtk/gio-coroutine.c | 5 -
1 file changed, 4 insertions(+), 1
Add a new migration state to track early migration step, when migration
session is connecting to destination
---
gtk/channel-main.c | 1 +
gtk/spice-session.h | 2 ++
2 files changed, 3 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 62e8905..873487b 100644
---
Use a more complete method for the job
---
gtk/channel-main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 5c055ed..e86fc15 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2174,8 +2174,8 @@ static void
---
gtk/spice-channel.c | 2 ++
gtk/spice-session.c | 3 ++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c
index 3966560..4fbcb18 100644
--- a/gtk/spice-channel.c
+++ b/gtk/spice-channel.c
@@ -2545,6 +2545,7 @@ static void
The migration session creation may fail. Instead of delaying the session
creation to the main_connect() callback, do it directly from the message
handler context, to report failure early to server.
---
gtk/channel-main.c | 23 +++
1 file changed, 15 insertions(+), 8
---
gtk/channel-main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 86dca87..5c055ed 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2163,7 +2163,7 @@ static void main_migrate_connect(SpiceChannel *channel,
Currently the fd request is done on the migration session, which is not
connected with the client session, so the client has no way to provide
fd for the migration. And the original and migration session ends up
stuck. Failing early seems the best for now.
---
TODO| 1 +
During migration, the original socket is closed before the coroutine
finishes, so it's not guaranteed that c-sock will still be set when the
channel is in an error state in spice_channel_iterate().
---
gtk/spice-channel.c | 4
1 file changed, 4 insertions(+)
diff --git a/gtk/spice-channel.c
The spice_session_disconnect() method now calls
spice_session_abort_migration(), so it is not necessary to do migration
cleanups in dispose anymore
---
gtk/spice-session.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions(-)
diff --git a/gtk/spice-session.c
During migration, the main channel initiating the process is waiting on
connection completion of all channels in migrate_channel_event_cb() or
it will abort migration for unexpected channel events, such as
SPICE_CHANNEL_CLOSED.
If the migration is cancelled before connection completes, but the
The following critical happens on switch-host:
(remote-viewer:4617): GSpice-CRITICAL **: channel_connect: assertion
'c-sock == NULL' failed
The critical happens since the main channel reset code calls
set_agent_connected(), which will yield to main loop, so reconnection
can't happen after
A channel is considered to be part of a session as long as it is
alive. However, this model is problematic, since library user may hold
channel references, and thus the channel will remain in the
session. Calling spice_session_disconnect() several time will end up
calling spice_channel_destroy(),
It is idiomatic for client code to clean up it's reference on channel
disconnection. Keeping a reference during disconnect help solving
potential crashes if the session is unref during callbacks.
---
gtk/spice-session.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gtk/spice-session.c
This is a workaround for existing clients such as virt-viewer that do
not hold a reference to their sessions when calling
spice_session_disconnect() and crash now that channels are removed from
session during the call. They expect disconnection events to be deferred
instead, let's defer actual
This function is somewhat useless, and dangerous since it is
calling g_object_unref() on your back (although this is mention in the
doc, I consider this a bad practice).
---
gtk/spice-channel.c | 7 ++-
gtk/spice-channel.h | 3 ++-
gtk/spice-session.c | 8
3 files changed, 12
Hi
I would like to report the problem in the link of the page and the download
page in two cases it is imposible download the spice-guest-tools the
download mark incomplete in all cases.
Regards
___
Spice-devel mailing list
47 matches
Mail list logo
