Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

Hey, On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote: --- common/canvas_base.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index c45d535..170def1 100644 --- a/common/canvas_base.c

[Spice-devel] [spice-common 3/3] ssl_verify: Move wincrypt.h related #ifdef closer to the include

Both wincrypt.h and openssl try to define X509_NAME. The wincrypt.h one is not useful for us, so we currently #undef it if this was set. However, it's done very late, right before including x509v3.h which defines the X509_NAME type. Any header included in between may try to #include x509v3.h so

Re: [Spice-devel] [PATCH 6/6] LZ4: Add support for 24bit pixman surfaces

Hello, I just saw I forgot to remove a warning that I used for debugging, I'll send the patch again. El Lunes, 26 de enero de 2015 15:15:01 Christophe Fergeau escribió: Hey, A bit worried to add new cases to surface_create, but it seems nothing is going to try to pass a r8g8b8 there except

[Spice-devel] [spice-common 2/3] Get rid of SW_CANVAS_IMAGE_CACHE

Every time it's used, it's in constructs similar to: #ifdef SW_CANVAS_CACHE , SpiceImageCache *bits_cache , SpicePaletteCache *palette_cache #elif defined(SW_CANVAS_IMAGE_CACHE) , SpiceImageCache *bits_cache

[Spice-devel] [spice-common 1/3] Remove another redundant (SW_CANVAS_CACHE) || (SW_CANVAS_IMAGE_CACHE) #ifdef

--- common/canvas_base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/common/canvas_base.c b/common/canvas_base.c index 7ebea7b..417741e 100644 --- a/common/canvas_base.c +++ b/common/canvas_base.c @@ -1588,12 +1588,10 @@ static pixman_image_t *canvas_get_mask(CanvasBase *canvas,

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

Hello, El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: Hey, On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote: --- common/canvas_base.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] [PATCH 6/6] LZ4: Add support for 24bit pixman surfaces

Hey, A bit worried to add new cases to surface_create, but it seems nothing is going to try to pass a r8g8b8 there except for the lz4 code, so ACK with the last hunk removed (whitespace change in alloc_lz_surface). Christophe On Thu, Jan 22, 2015 at 05:21:24PM +0100, Javier Celaya wrote: ---

Re: [Spice-devel] [PATCH 3/5] LZ4: Do not reverse bottom-up images

Some small comment in the commit log as to why we no longer want to swap the image would be nice (was it broken? does it make the code simpler? .. ) Christophe On Thu, Jan 22, 2015 at 05:21:06PM +0100, Javier Celaya wrote: --- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h |

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

On Mon, Jan 26, 2015 at 03:20:23PM +0100, Javier Celaya wrote: Hello, El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: Hey, On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote: --- common/canvas_base.c | 25 +++-- 1 file

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

El Lunes, 26 de enero de 2015 16:52:42 Christophe Fergeau escribió: On Mon, Jan 26, 2015 at 03:20:23PM +0100, Javier Celaya wrote: Hello, El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: Hey, On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote:

[Spice-devel] [spice-server PATCHv3 0/4] LZ4: Fix supported image formats

Same as v2, but stick with htonl Javier Celaya (4): LZ4: Limit LZ4 to RGB formats LZ4: Fix encoder output size LZ4: Do not reverse bottom-up images LZ4: Send the original format with the compressed data server/lz4_encoder.c | 21 +++-- server/lz4_encoder.h | 7 +++

[Spice-devel] [PATCH 2/4] LZ4: Fix encoder output size

--- server/lz4_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 531ab4b..aa03721 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -56,7 +56,7 @@ int lz4_encode(Lz4EncoderContext *lz4, int height, int

Re: [Spice-devel] [PATCH 5/6] LZ4: Fix the row alignment when it is not on a 32bit boundary

On Mon, Jan 26, 2015 at 03:20:23PM +0100, Javier Celaya wrote: Hello, El Lunes, 26 de enero de 2015 15:13:57 Christophe Fergeau escribió: Hey, On Thu, Jan 22, 2015 at 05:21:23PM +0100, Javier Celaya wrote: --- common/canvas_base.c | 25 +++-- 1 file

Re: [Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. How is libvirt going to introspect whether the command line supports

Re: [Spice-devel] [PATCH 5/5] LZ4: Send the original format with the compressed data

ACK. On Thu, Jan 22, 2015 at 05:21:08PM +0100, Javier Celaya wrote: --- server/lz4_encoder.c | 9 + server/lz4_encoder.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to build the Windows client. Anyway, I don't mind using one solution or another, so you tell me. spice-common may be referencing MSVC++ as the

[Spice-devel] [PATCH 3/4] LZ4: Do not reverse bottom-up images

--- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++ server/red_worker.c | 18 +- 3 files changed, 14 insertions(+), 24 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index aa03721..2327e9a 100644 --- a/server/lz4_encoder.c +++

[Spice-devel] [PATCH 1/4] LZ4: Limit LZ4 to RGB formats

--- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index a18987a..8f07ee9 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -6678,6 +6678,7 @@ static inline int red_compress_image(DisplayChannelClient *dcc,

[Spice-devel] [PATCH 4/4] LZ4: Send the original format with the compressed data

--- server/lz4_encoder.c | 9 + server/lz4_encoder.h | 2 +- server/red_worker.c | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 2327e9a..b3e38b2 100644 --- a/server/lz4_encoder.c +++ b/server/lz4_encoder.c @@ -50,7

Re: [Spice-devel] RFC - adding vp8 support

On 01/26/2015 05:16 AM, Marc-André Lureau wrote: Hi - Original Message - Hi folks, The spice-html5 client supports streaming, for low values of 'support'. So you mean the streaming for the video regions only, right? Right. It would be a fairly substantial boost to it's

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to build the Windows client. Anyway, I don't mind using one solution

Re: [Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió: On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote: On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote: I saw some comments about MSVC in spice-gtk, and I thought someone could be using it to

Re: [Spice-devel] [PATCH 2/5] LZ4: Fix encoder output size

ACK. On Thu, Jan 22, 2015 at 05:21:05PM +0100, Javier Celaya wrote: --- server/lz4_encoder.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index 531ab4b..aa03721 100644 --- a/server/lz4_encoder.c +++

Re: [Spice-devel] [PATCH 1/5] LZ4: Limit LZ4 to RGB formats

ACK (a note in the commit log explaining why we don't want to handle the other formats would be useful). On Thu, Jan 22, 2015 at 05:21:04PM +0100, Javier Celaya wrote: --- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c

Re: [Spice-devel] [PATCH 4/5] LZ4: Implement htonl to remove dependency on arpa/inte.h

Same comment as before, you can just use GUINT32_TO_BE Christophe On Thu, Jan 22, 2015 at 05:21:07PM +0100, Javier Celaya wrote: --- server/lz4_encoder.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/server/lz4_encoder.c b/server/lz4_encoder.c index

[Spice-devel] [PATCH 1/4] LZ4: Limit LZ4 to RGB formats

Currently, the LZ4 encoding only (partially) supports RGB images, so we must check the image format before using it. In the future, indexed formats may be implemented too, but their use is usually very small compared to RGB. --- server/red_worker.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [Spice-devel] [PATCH spice-gtk 1/9] channel: delay event report to after coroutine exit

On Mon, Jan 26, 2015 at 6:16 PM, Christophe Fergeau cferg...@redhat.com wrote: Is this hunk strictly needed ? The code flow when the error was emitted before exiting was not different, and I expect the old code needed to go through there before the coroutine exited ? c-event must be NONE: it

Re: [Spice-devel] [PATCH spice-gtk 1/9] channel: delay event report to after coroutine exit

On Mon, Jan 26, 2015 at 6:31 PM, Marc-André Lureau mlur...@redhat.com wrote: I think the shortlog is a bit misleading, it's only some specific events which are reported this way. In particular, SPICE_CHANNEL_ERROR_LINK is still reported as before. Right, I focused only on channel_coroutine,

[Spice-devel] [PATCH 3/4] LZ4: Do not reverse bottom-up images

Reversing the bottom-up images in the server is not needed since Pixman, in the client, is able to deal with them. As a result, the previous code was more complex and wrong. This commit fixes and cleans it. --- server/lz4_encoder.c | 13 ++--- server/lz4_encoder.h | 7 +++

Re: [Spice-devel] [PATCH spice-gtk 3/9] channel: reset connection state on error

On Tue, Jan 13, 2015 at 05:38:22PM +0100, Marc-André Lureau wrote: Fix regression introduced in 6b475802, to permit reconnection on error, the channel state must be STATE_CONNECTING. Since the error is reported after coroutine exits and channel is reset, the state can be modified before

Re: [Spice-devel] [PATCH spice-gtk 9/9] spicy: deal with spice+unix:// URI

- Original Message - On Tue, Jan 13, 2015 at 05:38:28PM +0100, Marc-André Lureau wrote: --- gtk/spicy.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 2fcd529..4c7d2c8 100644 --- a/gtk/spicy.c +++

Re: [Spice-devel] [PATCH spice-gtk 5/9] session: connect to UNIX path

On Tue, Jan 13, 2015 at 05:38:24PM +0100, Marc-André Lureau wrote: --- gtk/spice-session.c | 43 --- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index 83d8568..6f04a1a 100644 ---

Re: [Spice-devel] [PATCH spice-gtk 9/9] spicy: deal with spice+unix:// URI

On Tue, Jan 13, 2015 at 05:38:28PM +0100, Marc-André Lureau wrote: --- gtk/spicy.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 2fcd529..4c7d2c8 100644 --- a/gtk/spicy.c +++ b/gtk/spicy.c @@ -1193,10 +1193,14 @@

Re: [Spice-devel] [PATCH spice-gtk 1/9] channel: delay event report to after coroutine exit

Hey, I think the shortlog is a bit misleading, it's only some specific events which are reported this way. In particular, SPICE_CHANNEL_ERROR_LINK is still reported as before. Bit of context as to _why_ this change is needed would be nice. On Tue, Jan 13, 2015 at 05:38:20PM +0100, Marc-André

Re: [Spice-devel] [PATCH spice-gtk 1/9] channel: delay event report to after coroutine exit

- Original Message - Hey, I think the shortlog is a bit misleading, it's only some specific events which are reported this way. In particular, SPICE_CHANNEL_ERROR_LINK is still reported as before. Bit of context as to _why_ this change is needed would be nice. It's all related

Re: [Spice-devel] [PATCH spice-gtk 2/9] channel: reset tls state when client calls connect

ACK. Are there client applications calling spice_channel_connect() after the channel has been reset/disconnected? Christophe On Tue, Jan 13, 2015 at 05:38:21PM +0100, Marc-André Lureau wrote: The channel TLS state is kept during disconnection and reset, for automatic reconnection and

Re: [Spice-devel] [PATCH spice-gtk 4/9] session: add unix-path property

On Tue, Jan 13, 2015 at 05:38:23PM +0100, Marc-André Lureau wrote: --- gtk/spice-session.c | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index 7971f3c..83d8568 100644 ---

Re: [Spice-devel] is there anybody have problem when run spicy on sparc-CPU mechine

On Mon, Jan 26, 2015 at 03:42:03PM +0800, jiangdahui wrote: Hi all: we are trying to run spicy on sparc-CPU machine,but the problem is strange, for example: we get a bus error in line like if((descriptor-type == SPICE_IMAGE_TYPE_JPEG) || (descriptor-type ==

[Spice-devel] [Xspice PATCH 05/11] playback_dir_changed: rename variable index to offset

This fixes the following compiler warning. spiceqxl_audio.c: In function ‘playback_dir_changed’: spiceqxl_audio.c:386: warning: declaration of ‘index’ shadows a global declaration --- src/spiceqxl_audio.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Spice-devel] [Xspice PATCH 03/11] scripts/Xspice: add default spice-vdagent executable names

--- scripts/Xspice |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index d48318c..6eb5294 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -128,6 +128,10 @@ def agents_new_enough(args): return True if args.vdagent_enabled: +

[Spice-devel] [Xspice PATCH 02/11] scripts/Xspice: better error messages for missing vdagent binaries

Also added a check for the case variables are uninitialized (or when the executables are not found and which returns None) --- scripts/Xspice | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index fee2b0e..d48318c 100755 ---

[Spice-devel] [Xspice PATCH 04/11] scripts/Xspice: run vdagentd with -f command line option (fake uinput)

From: Charles Ricketts gith...@gmail.com --- scripts/Xspice |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index 6eb5294..281535d 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -302,7 +302,7 @@ if retpid != 0: else: if

[Spice-devel] [Xspice PATCH 01/11] scripts/Xspice: which: warn if executable is not found

Also handle None parameter case. --- scripts/Xspice |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/scripts/Xspice b/scripts/Xspice index b8a7b78..fee2b0e 100755 --- a/scripts/Xspice +++ b/scripts/Xspice @@ -26,12 +26,15 @@ import signal from subprocess import Popen,

[Spice-devel] [Xspice PATCH 00/11] Xspice script, compiler warnings and README.xspice

This patchset touches 3 areas: Patches 1-4Xspice script Add some checks/warnings and run vdagentd with -f command line option If people prefer I can squash the checks/warning patches Patches 4-9fix compiler warnings Some copromises were made in order to fix those

Re: [Spice-devel] [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE

Sorry, I forgot to patch the command-line help. Hope it helps. El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió: On 01/23/2015 07:06 AM, Javier Celaya wrote: Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one?

[Spice-devel] is there anybody have problem when run spicy on sparc-CPU mechine

Hi all: we are trying to run spicy on sparc-CPU machine,but the problem is strange, for example: we get a bus error in line like if((descriptor-type == SPICE_IMAGE_TYPE_JPEG) || (descriptor-type == SPICE_IMAGE_TYPE_JPEG_ALPHA)) where the (descriptor-type can be printed.

[Spice-devel] [PATCHv2] LZ4: warn if trying to set lz4 but not supported

--- server/reds.c | 8 1 file changed, 8 insertions(+) diff --git a/server/reds.c b/server/reds.c index e34433b..2bdc557 100644 --- a/server/reds.c +++ b/server/reds.c @@ -3501,6 +3501,14 @@ SPICE_GNUC_VISIBLE int spice_server_set_image_compression(SpiceServer *s,

[Spice-devel] [Xspice PATCH 11/11] README.xspice: clone and install xkeyboard-config

Instead of copying /usr/share/X11/xkb --- README.xspice |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/README.xspice b/README.xspice index b04a2b1..803bc6c 100644 --- a/README.xspice +++ b/README.xspice @@ -77,6 +77,7 @@ for src in \

[Spice-devel] [Xspice PATCH 06/11] vmc_read: rename variable read to nbytes

This fixes the following compiler warning. spiceqxl_vdagent.c:49: warning: declaration of ‘read’ shadows a global declaration /usr/include/unistd.h:357: warning: shadowed declaration is here --- src/spiceqxl_vdagent.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Spice-devel] [Xspice PATCH 09/11] qxl_ring: replace memcpy with a simple copy_to/from_qxl_ring

cc: Dave Airlie airl...@redhat.com Since memcpy is not supposed to be used on volatile memory, use a simple loop that copies one byte at a time. This fixes compiler warnings: qxl_ring.c: In function ‘qxl_ring_push’: qxl_ring.c:96: warning: cast discards qualifiers from pointer target type

[Spice-devel] [Xspice PATCH 10/11] README.xspice: clone more repos, add some script lines and more

This helps build on a RHEL-6 machine --- README.xspice | 92 1 files changed, 72 insertions(+), 20 deletions(-) diff --git a/README.xspice b/README.xspice index 189f8b3..b04a2b1 100644 --- a/README.xspice +++ b/README.xspice @@ -44,7

[Spice-devel] [Xspice PATCH 08/11] configure: include assert.h and values.h (fix compiler warning y1)

The compiler warns about a function being shadowed by a local variable named y1. Apparently y1 is a name of a Bessel function of the math library. For example: uxa-glyphs.c: In function ‘uxa_glyph_extents’: uxa-glyphs.c:310: warning: declaration of ‘y1’ shadows a global declaration

Re: [Spice-devel] RFC - adding vp8 support

Hi - Original Message - Hi folks, The spice-html5 client supports streaming, for low values of 'support'. So you mean the streaming for the video regions only, right? It would be a fairly substantial boost to it's performance if Spice could encode in a format supported by the

[Spice-devel] [Xspice PATCH 07/11] uxa: fix compiler warnings (initialize width, height, [xy]Dst_copy)

Some compiler warnings for example: uxa-glyphs.c:1045: warning: ‘width’ may be used uninitialized in this function uxa-glyphs.c:1045: warning: ‘height’ may be used uninitialized in this function uxa-render.c:1090: warning: ‘xDst_copy’ may be used uninitialized in this function uxa-render.c:1090:

Re: [Spice-devel] [Xspice PATCH 08/11] configure: include assert.h and values.h (fix compiler warning y1)

- Original Message - The compiler warns about a function being shadowed by a local variable named y1. Apparently y1 is a name of a Bessel function of the math library. For example: uxa-glyphs.c: In function ‘uxa_glyph_extents’: uxa-glyphs.c:310: warning: declaration of ‘y1’

Re: [Spice-devel] [Xspice PATCH 00/11] Xspice script, compiler warnings and README.xspice

Hi - Original Message - This patchset touches 3 areas: Patches 1-4Xspice script Add some checks/warnings and run vdagentd with -f command line option If people prefer I can squash the checks/warning patches Patches 4-9fix compiler warnings Some copromises