Re: [Spice-devel] [PATCH 0/2] RFC: handle startup race for monitors config

2015-04-16 Thread Jonathon Jongsma
On Thu, 2015-04-09 at 14:06 -0500, Jonathon Jongsma wrote: > On Thu, 2015-04-02 at 11:15 -0500, Jonathon Jongsma wrote: > > On Thu, 2015-04-02 at 16:42 +0200, Marc-André Lureau wrote: > > > > > > On Thu, Apr 2, 2015 at 4:36 PM, Jonathon Jongsma > > > wrote: > > > That would be a pretty dr

Re: [Spice-devel] [spice-gtk PATCH v8 2/4] audio: spice-pulse implement async volume-info

2015-04-16 Thread Marc-André Lureau
Hi A few comments below. On Thu, Apr 16, 2015 at 4:42 PM, Victor Toso wrote: > In case of volume-sync between client and guest, we request volume-info > from the availables streams and if the stream is not available we rely > on ext-stream-restore. > > By using ext-stream-restore we can get the

[Spice-devel] [spice-gtk PATCH v8 2/4] audio: spice-pulse implement async volume-info

2015-04-16 Thread Victor Toso
In case of volume-sync between client and guest, we request volume-info from the availables streams and if the stream is not available we rely on ext-stream-restore. By using ext-stream-restore we can get the last stream data of the application that is stored by PulseAudio. Related: https://bugzi

Re: [Spice-devel] [spice-gtk] Fix GSocketAddress leak in proxy_lookup_ready()

2015-04-16 Thread Christophe Fergeau
On Thu, Apr 16, 2015 at 03:56:39PM +0200, Marc-André Lureau wrote: > this patch was already acked in February. I had vague memories of already fixing that, but it's not present in my local git branch, sorry for the resend. I'll push it now this time. Christophe pgpnka2ic6hFP.pgp Description: PG

Re: [Spice-devel] [spice-gtk] Fix GSocketAddress leak in proxy_lookup_ready()

2015-04-16 Thread Marc-André Lureau
this patch was already acked in February. On Thu, Apr 16, 2015 at 3:36 PM, Christophe Fergeau wrote: > g_proxy_address_new() returns a new GProxyAddress, so we must unref it > when no longer needed. > > This fixes: > > ==6481== 234 (48 direct, 186 indirect) bytes in 1 blocks are definitely > los

[Spice-devel] [spice-gtk PATCH v8 0/4] volume-info: spice-pulse

2015-04-16 Thread Victor Toso
spice-pulse: - track later pa_operation related to ext-stream-restore that only starts after context is in READY state; - avoid triggering the above operation more then once; - cancel pa_operations when complete_all_async_tasks is called. this is useful in dispose() as we may have pa_operations

[Spice-devel] [spice-gtk PATCH v8 2/4] audio: spice-pulse implement async volume-info

2015-04-16 Thread Victor Toso
In case of volume-sync between client and guest, we request volume-info from the availables streams and if the stream is not available we rely on ext-stream-restore. By using ext-stream-restore we can get the last stream data of the application that is stored by PulseAudio. Related: https://bugzi

[Spice-devel] [spice-gtk] Fix GSocketAddress leak in proxy_lookup_ready()

2015-04-16 Thread Christophe Fergeau
g_proxy_address_new() returns a new GProxyAddress, so we must unref it when no longer needed. This fixes: ==6481== 234 (48 direct, 186 indirect) bytes in 1 blocks are definitely lost in loss record 10,062 of 10, ==6481==at 0x31FF230A58: g_type_create_instance (gtype.c:1849) ==6481==by 0x

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Fabiano Fidencio
- Original Message - > From: "Marc-André Lureau" > To: "Christophe Fergeau" > Cc: spice-de...@freedesktop.org > Sent: Thursday, April 16, 2015 12:30:27 PM > Subject: Re: [Spice-devel] [spice-gtk] Add spec files > > I don't think there are valid reason to put fedora-specific spec file i

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Daniel P. Berrange
On Thu, Apr 16, 2015 at 12:30:27PM +0200, Marc-André Lureau wrote: > I don't think there are valid reason to put fedora-specific spec file in > upstream. You can easily build a rpm with fedpkg. nack We've done this for years with all libvirt related packages and it has proved pretty userful for bo

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Marc-André Lureau
I don't think there are valid reason to put fedora-specific spec file in upstream. You can easily build a rpm with fedpkg. nack On Thu, Apr 16, 2015 at 12:17 PM, Christophe Fergeau wrote: > On Thu, Apr 16, 2015 at 06:11:40AM -0400, Marc-André Lureau wrote: > > Hi, > > > > - Original Message

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Christophe Fergeau
On Thu, Apr 16, 2015 at 06:11:40AM -0400, Marc-André Lureau wrote: > Hi, > > - Original Message - > > They can be used to build spice-gtk / mingw-spice-gtk RPM packages. > > These spec files are based off the .spec used in Fedora > > Why is it needed? > I dislike having to maintain .spec

[Spice-devel] [spice-gtk v2] Add spec files

2015-04-16 Thread Christophe Fergeau
They can be used to build spice-gtk / mingw-spice-gtk RPM packages. These spec files are based off the .spec used in Fedora --- configure.ac | 2 + data/Makefile.am | 8 ++ data/mingw-spice-gtk.spec.in | 279 +++ data/spice-gt

Re: [Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Marc-André Lureau
Hi, - Original Message - > They can be used to build spice-gtk / mingw-spice-gtk RPM packages. > These spec files are based off the .spec used in Fedora Why is it needed? I dislike having to maintain .spec files in several places. Furthermore, I don't get why we should have .spec file up

[Spice-devel] [spice-gtk] Add spec files

2015-04-16 Thread Christophe Fergeau
They can be used to build spice-gtk / mingw-spice-gtk RPM packages. These spec files are based off the .spec used in Fedora --- configure.ac | 2 + data/Makefile.am | 8 ++ data/mingw-spice-gtk.spec.in | 279 +++ data/spice-gt

Re: [Spice-devel] [spice-gtk PATCH v7 2/4] audio: spice-pulse implement async volume-info

2015-04-16 Thread Victor Toso
Hi, thanks for the review On Wed, Apr 15, 2015 at 07:52:46PM +0200, Marc-André Lureau wrote: > On Wed, Apr 15, 2015 at 6:39 PM, Victor Toso wrote: > > > In case of volume-sync between client and guest, we request volume-info > > from the availables streams and if the stream is not available we r

Re: [Spice-devel] [spice-gtk PATCH v6 2/4] audio: spice-pulse implement async volume-info

2015-04-16 Thread Victor Toso
Hi, On Wed, Apr 15, 2015 at 07:29:12PM +0200, Marc-André Lureau wrote: > On Wed, Apr 15, 2015 at 2:12 PM, Victor Toso wrote: > > > > > + > > > > +if (info->channel_map.channels == 0) { > > > > +SPICE_DEBUG("%s - Number of channels stored is zero. Ignore. > > > > (%s)", __func__, info-