Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

On Tue, 2016-05-03 at 14:56 -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi Marc-André, > > > > On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > > > This

[Spice-devel] [PATCH 12/14] Generate GTypes for spice-server enums

--- server/Makefile.am | 31 +++ 1 file changed, 31 insertions(+) diff --git a/server/Makefile.am b/server/Makefile.am index f5822ad..4337dbf 100644 --- a/server/Makefile.am +++ b/server/Makefile.am @@ -64,6 +64,8 @@ libspice_serverinclude_HEADERS = \

[Spice-devel] [PATCH 01/14] Add red_client_seamless_migration_done_for_channel()

This is a public RedClient API that handles updating itself rather than having the RedChannelClient poke around at the internal structure in rec_channel_client_seamless_migration_done(). --- server/red-channel.c | 35 +++ 1 file changed, 23 insertions(+), 12

[Spice-devel] [PATCH 03/14] Move InputsChannelClient to a separate file

Preparation for converting to GObject --- server/Makefile.am | 2 + server/inputs-channel-client.c | 92 ++ server/inputs-channel-client.h | 44 server/inputs-channel.c| 76 ++

[Spice-devel] [PATCH 06/14] Replace RedClient::channels with GList

Allows us to not expose the client_link in RedChannelClient. --- server/red-channel.c | 51 --- server/red-channel.h | 5 + 2 files changed, 29 insertions(+), 27 deletions(-) diff --git a/server/red-channel.c b/server/red-channel.c index

[Spice-devel] [PATCH 09/14] Move CommonGraphicsChannelClient to a separate file

This reduces the direct access to the struct in preparation for GObjectification --- server/Makefile.am | 3 ++ server/common-graphics-channel-client-private.h | 29 server/common-graphics-channel-client.c | 60 +

[Spice-devel] [PATCH 07/14] Limit direct access to DisplayChannelClient

Add a few more methods and accessors so that other files don't need to manipulate the struct members directly. Move the struct definition to a private header which only the dcc-* files will include. --- server/Makefile.am | 1 + server/dcc-encoders.c| 11 +++--- server/dcc-encoders.h

[Spice-devel] [PATCH 04/14] Replace RedChannel::clients with GList

Instead of using a Ring, use a GList to store the list of channel clients. This allows us to iterate the clients without poking inside of the client struct to get the channel_link. This is required in order to make the RedChannelClient struct private. --- server/display-channel.c | 64

[Spice-devel] [PATCH 00/14] Backported patches from refactory branch (May 3)

Several patches were merged, a couple were dropped or delayed to later. Jonathon Jongsma (14): Add red_client_seamless_migration_done_for_channel() Move MainChannelClient to separate file Move InputsChannelClient to a separate file Replace RedChannel::clients with GList rename

[Spice-devel] [PATCH 02/14] Move MainChannelClient to separate file

Preparation for converting to GObject --- server/Makefile.am | 2 + server/inputs-channel.c | 2 +- server/main-channel-client.c | 552 ++ server/main-channel-client.h | 163 server/main-channel.c| 616

Re: [Spice-devel] [PATCH 07/18] Change new_pipe_item_t function signature

On Thu, 2016-04-28 at 13:15 -0400, Frediano Ziglio wrote: > > > > Now that pipe_item_init() does not require a RedChannelClient* argument > > anymore, the new_pipe_item_t callback function does not ever use the > > channel client object passed to it. So just remove this and simplify > > things. >

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

Hi - Original Message - > Hi Marc-André, > > On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > > Hi > > > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > > This patches introduces and uses a spice-gtk-session property > > > for disabling

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

Hi Marc-André, On Tue, 2016-05-03 at 20:15 +0200, Marc-André Lureau wrote: > Hi > > On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > > This patches introduces and uses a spice-gtk-session property > > for disabling automatic modifiers sync. It can be useful in cases > >

Re: [Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

Hi On Tue, May 3, 2016 at 3:41 PM, Pavel Grunt wrote: > This patches introduces and uses a spice-gtk-session property > for disabling automatic modifiers sync. It can be useful in cases > where syncing currently fails - eg not working leds on the guest side, > missmatch

Re: [Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

On Tue, May 3, 2016 at 7:36 PM, Marc-André Lureau wrote: > +gtk_container_add(GTK_CONTAINER(display), d->stack); better with GTK_WIDGET() to avoid the warning, fixed -- Marc-André Lureau ___ Spice-devel mailing list

[Spice-devel] [PATCH spice-gtk] gtk: fix server-mode mouse

Since switching to gtkstack, server-side mouse mode has some issues with grabs. There seems to be some grab gtk+ issue, but it seems to fall under the API user responsability to have its own window when dealing with pointer grabs. And gtk+ commit 9d0e8401c (Turn stack into no-window widget) made

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

On Tue, 3 May 2016, Christophe Fergeau wrote: [...] > > I think it's useful to be able to print the name of the GStreamer > > encoder, particularly for this warning: > > > > spice_warning("GStreamer error: could not find the %s bitrate > > parameter", gstenc_name); > > Ah, for sure, I

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

On Tue, 3 May 2016, Christophe Fergeau wrote: [...] > > > > + /* Copy the line */ > > > > + uint8_t *src = chunks->chunk[chunk_index].data + chunk_offset; > > > > + memcpy(dst, src, stream_stride); > > > > > > Are we guaranteed that we'll have at least 'stream_stride'

Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-gtk-session: Add sync modifiers property

> It will help in cases where syncing modifiers keys is complicated: > * not working leds for modifiers keys > * different keyboard layout on the guest side > --- > src/spice-gtk-session.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git

Re: [Spice-devel] [vdagent-linux v4 7/7] console-kit: implement check for session type

Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Implementing the function that was introduced in previous commit: > session_info_is_user() > > In console-kit we can gather the session type with GetSessionType api > from Session interface.

Re: [Spice-devel] [vdagent-linux v4 6/7] session-info: check if session belongs to user

Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > session-info back-ends such as console-kit and systemd-login have the > concept of session's class which informs if session belongs to user or > not [0]. We can disable features based on the

Re: [Spice-devel] [vdagent-linux v4 4/7] session-info: check for a locked session

Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Each session back-end can return this information to vdagentd when > requested. > > The agent should use this on situations that should not work when > session is locked such as

Re: [Spice-devel] [vdagent-linux v4 3/7] console-kit: fix dangling pointer

Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Introduced recently by b1b8b71961b9a28cc4896e9973d3a3c1975ead39 > --- > src/console-kit.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/console-kit.c b/src/console-kit.c >

Re: [Spice-devel] [vdagent-linux v4 2/7] console-kit: Ignore unrequested messages from dbus

Acked-by: Jonathon Jongsma On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Instead of treating them as errors. > --- > src/console-kit.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/src/console-kit.c b/src/console-kit.c >

Re: [Spice-devel] [vdagent-linux v4 1/7] vdagentd: send file-xfer status, generic version

On Tue, 2016-05-03 at 13:01 +0200, Victor Toso wrote: > Change cancel_file_xfer() helper function to file_xfer_status() so we > can send other status to the client. I like the idea, though I'd prefer a verb in the function name to make it obvious that we're *sending* the status to the client.

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

On 05/03/2016 01:53 PM, Frediano Ziglio wrote: On 05/02/2016 11:25 AM, Frediano Ziglio wrote: This was caused by commit 1cec1c5118b65124de6bc6f984f376ff4e297bfb ("reds: Make VDIPortState a GObject") as the lifespan of RedCharDevice was changed. This could be reproduced with: - start rhel7

Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

On Tue, May 03, 2016 at 04:33:47PM +0200, Francois Gouget wrote: > On Mon, 2 May 2016, Christophe Fergeau wrote: > > > +#else > > > +gst_bus_set_sync_handler(bus, handle_pipeline_message, encoder, > > > NULL); > > > > Using _sync_handler which runs in a different thread seems quite > >

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

On Tue, May 03, 2016 at 04:53:08PM +0200, Francois Gouget wrote: > On Mon, 2 May 2016, Christophe Fergeau wrote: > [...] > > > -/* A helper for spice_gst_encoder_encode_frame() */ > > > +static const gchar* get_gst_codec_name(SpiceGstEncoder *encoder) > > > +{ > > > +switch

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

On Tue, May 03, 2016 at 03:58:58PM +0200, Francois Gouget wrote: > On Fri, 29 Apr 2016, Christophe Fergeau wrote: > [...] > > > +/* A helper for push_raw_frame() */ > > > +static inline int line_copy(SpiceGstEncoder *encoder, const SpiceBitmap > > > *bitmap, > > > +

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

> > On 05/02/2016 07:39 AM, Uri Lublin wrote: > > On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: > >> The problem happens when you run 'make dist' in a system without > >> asciidoc installed. Even though in configure time there is a check for > >> building the manual, it is required to be

Re: [Spice-devel] How to modify spice version?

Hi - Original Message - > >> 1) We should have specified --fallback in AC_INIT line > > > > Why "should we"? even autoconf.git (the source of the script) isn't using > > it. > > > > http://git.savannah.gnu.org/cgit/autoconf.git/tree/configure.ac > > > > Well, the fact that they are

Re: [Spice-devel] [spice v13 16/29] server: Give up after a while if GStreamer cannot handle the video

On Mon, 2 May 2016, Christophe Fergeau wrote: [...] > > -/* A helper for spice_gst_encoder_encode_frame() */ > > +static const gchar* get_gst_codec_name(SpiceGstEncoder *encoder) > > +{ > > +switch (encoder->base.codec_type) > > +{ > > +case SPICE_VIDEO_CODEC_TYPE_MJPEG: > > +

Re: [Spice-devel] [spice-devel]How to reduce the image resolution or definition ?

Hi, This code comment suggests that during streaming, JPG quality adjustment takes place: /* * Adjusting the stream jpeg quality and frame rate (fps): * When during_quality_eval=TRUE, we compress different frames with different * jpeg quality. By considering (1) the resulting compression

Re: [Spice-devel] [spice v13 10/29] server: Handle and recover from GStreamer encoding errors

On Mon, 2 May 2016, Christophe Fergeau wrote: [...] > > +if (GST_MESSAGE_TYPE(msg) == GST_MESSAGE_ERROR) { > > +GError *err; > > 'err' must be set to NULL here. > > > +gchar *debug_info; > > +gst_message_parse_error(msg, , _info); Done. Here is the explanation for

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

> > Hey, > > On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > > > Honestly more I look at the patch and this fix and more I think it's all > > a big bug... > > What I know for sure is that this patch fix a dandling pointer. > > NB: 'dangling' not 'dandling' (there is this

Re: [Spice-devel] [spice v13 03/29] server: Add a GStreamer 1.0 MJPEG video encoder and use it by default

On Fri, 29 Apr 2016, Christophe Fergeau wrote: [...] > > +/* A helper for push_raw_frame() */ > > +static inline int line_copy(SpiceGstEncoder *encoder, const SpiceBitmap > > *bitmap, > > +uint32_t chunk_offset, uint32_t stream_stride, > > +

[Spice-devel] [PATCH spice-gtk 2/2] spicy: Add option to control syncing modifiers

--- src/spicy.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/spicy.c b/src/spicy.c index 0475530..0826c03 100644 --- a/src/spicy.c +++ b/src/spicy.c @@ -712,6 +712,7 @@ static const char *spice_display_properties[] = { static const char *spice_gtk_session_properties[] = {

[Spice-devel] [PATCH spice-gtk 1/2] spice-gtk-session: Add sync modifiers property

It will help in cases where syncing modifiers keys is complicated: * not working leds for modifiers keys * different keyboard layout on the guest side --- src/spice-gtk-session.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/spice-gtk-session.c

[Spice-devel] [PATCH spice-gtk 0/2] Allow to disable syncing modifiers

Hi, This patches introduces and uses a spice-gtk-session property for disabling automatic modifiers sync. It can be useful in cases where syncing currently fails - eg not working leds on the guest side, missmatch between client's and guest's keyboard layout. Related:

Re: [Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

Hey, On Tue, May 03, 2016 at 06:53:49AM -0400, Frediano Ziglio wrote: > > Honestly more I look at the patch and this fix and more I think it's all > a big bug... > What I know for sure is that this patch fix a dandling pointer. NB: 'dangling' not 'dandling' (there is this typo in the short log,

[Spice-devel] [vdagent-linux v4 4/7] session-info: check for a locked session

Each session back-end can return this information to vdagentd when requested. The agent should use this on situations that should not work when session is locked such as file-transfer-start which is fixed by this patch. systemd-login is the only back-end implementing this function at the moment

[Spice-devel] [vdagent-linux v4 3/7] console-kit: fix dangling pointer

Introduced recently by b1b8b71961b9a28cc4896e9973d3a3c1975ead39 --- src/console-kit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/console-kit.c b/src/console-kit.c index c7e60df..6f86104 100644 --- a/src/console-kit.c +++ b/src/console-kit.c @@ -95,6 +95,7 @@ static void

[Spice-devel] [vdagent-linux v4 0/6] do not DnD on locked/login screen

Good summary in the v2 of this series: https://lists.freedesktop.org/archives/spice-devel/2016-April/028461.html v3->v4: * Jonathon: - Fixed dangling pointers - Ignore unrequested messages from dbus instead of treating them as errors - Send error status instead of 'cancel' status about file

[Spice-devel] [vdagent-linux v4 1/7] vdagentd: send file-xfer status, generic version

Change cancel_file_xfer() helper function to file_xfer_status() so we can send other status to the client. --- src/vdagentd.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/vdagentd.c b/src/vdagentd.c index 69332ff..263c288 100644 --- a/src/vdagentd.c +++

[Spice-devel] [vdagent-linux v4 2/7] console-kit: Ignore unrequested messages from dbus

Instead of treating them as errors. --- src/console-kit.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/console-kit.c b/src/console-kit.c index d4eecd7..c7e60df 100644 --- a/src/console-kit.c +++ b/src/console-kit.c @@ -109,12 +109,6 @@

Re: [Spice-devel] [spice-gtk EXP] Handle mismatching CapsLock

Hi, I don't follow. Which issues did you find? The patch does not introduce any delays. Can you do some examples of bumping? Frediano > > Hi Frediano, > > unfortunately this patch does not work, it was hard for me to write when > pressing and releasing capslock due to delays. Also the "bump"

Re: [Spice-devel] [spice-server 1/2] build-sys: Drop unneeded python check

ack - Original Message - > spice-gtk does not use python, the spice-common submodule needs it, but > it has its own python check through the use of AM_PATH_PYTHON > --- > configure.ac | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index

Re: [Spice-devel] [spice-gtk 1/2] build-sys: Delete pygtk2-related files

ack - Original Message - > They are no longer needed since 0917002c which dropped pygtk2 support > --- > m4/check_python.m4| 46 > src/Makefile.am | 2 - > src/spice-client-gtk-module.c | 45 --- > src/spice-client-gtk.override | 171 >

[Spice-devel] spice-html5 audio problem

Hello, I've been using the spice-html5 client for few months in a project, but we found that audio seems to have stopped working properly. When we open the client it works well, but then it stops randomly; sometimes in a few seconds, sometimes it lasts more than a minute or two. Trying to

[Spice-devel] [spice-server 2/2] build-sys: Remove 'CXX' from configure summary

We no longer make use of a c++ compiler since dropping the client, so no need to show it in the configure summary. --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2d7499d..d11fcca 100644 --- a/configure.ac +++ b/configure.ac @@ -285,7 +285,6

[Spice-devel] [spice-server 1/2] build-sys: Drop unneeded python check

spice-gtk does not use python, the spice-common submodule needs it, but it has its own python check through the use of AM_PATH_PYTHON --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 66db560..2d7499d 100644 --- a/configure.ac +++

[Spice-devel] [spice-gtk 2/2] build-sys: Drop unneeded python check

spice-gtk does not use python, the spice-common submodule needs it, but it has its own python check through the use of AM_PATH_PYTHON --- configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/configure.ac b/configure.ac index ce80d88..f4d6680 100644 --- a/configure.ac +++ b/configure.ac

[Spice-devel] [spice-gtk 1/2] build-sys: Delete pygtk2-related files

They are no longer needed since 0917002c which dropped pygtk2 support --- m4/check_python.m4| 46 src/Makefile.am | 2 - src/spice-client-gtk-module.c | 45 --- src/spice-client-gtk.override | 171 -- 4

Re: [Spice-devel] [spice-gtk EXP] Handle mismatching CapsLock

Hi Frediano, unfortunately this patch does not work, it was hard for me to write when pressing and releasing capslock due to delays. Also the "bump" still exists (it is enough to switch to vt to see it). imho the problem is on the server side (server sending capslock to the guest) Pavel On

[Spice-devel] [PATCH 2/2 v4] add a program to test redirection on Windows

This program attempt multiple redirection combination: - passing handles using either CreateProcess or SetStdHandle; - having a console or not; - redirection stdout/stderr yes or not. Signed-off-by: Frediano Ziglio --- tests/Makefile.am | 7 ++ tests/redirect-test.c |

Re: [Spice-devel] [PATCH] Make asciidoc a hard requirement

On 05/02/2016 03:32 PM, Eduardo Lima (Etrunko) wrote: On 05/02/2016 07:39 AM, Uri Lublin wrote: On 04/26/2016 12:23 AM, Eduardo Lima (Etrunko) wrote: The problem happens when you run 'make dist' in a system without asciidoc installed. Even though in configure time there is a check for building

Re: [Spice-devel] spice_get_option_group is skipped and has messy output

Visarion, On Tue, May 3, 2016 at 12:05 AM, Visarion-Mingopol Alexandru-Viorel wrote: > > Firstly, the spice_get_option_group is skipped when creating the Vala > binding and I need it for inserting the spice-gtk help menu in gnome-boxes. > > Secondly, the spice group

[Spice-devel] spice_get_option_group is skipped and has messy output

Firstly, the spice_get_option_group is skipped when creating the Vala binding and I need it for inserting the spice-gtk help menu in gnome-boxes. Secondly, the spice group options have a weird appearance on the standard terminal wifth width 80. Because their entries are so long[1]

Re: [Spice-devel] [spice-gtk v1] spicevmc: don't disconnect on "cancel"

Hi, On Mon, May 02, 2016 at 11:56:54AM -0500, Jonathon Jongsma wrote: > On Mon, 2016-05-02 at 15:16 +0200, Victor Toso wrote: > > spicevmc was designed so its _finish functions should always be called; > > With the gtask integration both _finish functions are trying to > > disconnect the

Re: [Spice-devel] [spice-gtk v1] spice-channel: fix small leak

Hi, On Mon, May 02, 2016 at 04:35:44PM +0200, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau Thanks, pushed. > > On Mon, May 02, 2016 at 04:02:32PM +0200, Victor Toso wrote: > > 182 bytes in 1 blocks are definitely lost in loss record 9,048 of 9,889 > > at