Re: [Spice-devel] [PATCH v4 13/19] Change RedGlzDrawable::drawable from pointer to boolean

On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > The field was used just as a flag. > This has the advantage to make clear to not use the pointer as we don't > have ownership. > Also many the structure a bit smaller. s/many/makes/ Acked-by: Jonathon Jongsma > >

Re: [Spice-devel] [PATCH v4 12/19] Better encoders encapsulation

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > Avoid to access some fields from dcc.c > > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 4 >  server/dcc.c  | 3 --- >  2 files

[Spice-devel] [PATCH] Remove goto within switch statement

Having a goto label in the middle of a switch/case statement is a bit confusing. But the same behavior can be achieved by simply rearranging the cases so that we fall through to the one that we wanted to jump to. --- This should apply on top of frediano's encapsulation patch series.

Re: [Spice-devel] [PATCH v4 11/19] Better encapsulation for image_encoders_compress_glz call

On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > Do not access too much encoders data. > Slightly different as now if glz is frozen lz compression is used. This *seems* safe, though I don't know the code enough to know what side-effects it might have. Would like a second opinion. >

Re: [Spice-devel] [PATCH v4 10/19] Encapsulate dcc_release_glz

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 4 +++- >  server/dcc-encoders.h | 1 - >  server/dcc.c  | 1 - >  3 files changed, 3

Re: [Spice-devel] [PATCH v4 08/19] Encapsulate code to save glz state

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 10 ++ >  server/dcc-encoders.h |  2 ++ >  server/dcc-send.c |  8 ++-- >  3 files

Re: [Spice-devel] [streaming v16 00/23] Add GStreamer support for video streaming

On 06/14/2016 10:24 AM, Christophe Fergeau wrote: > Hey, > > So I've finally pushed all of the spice-server bits save for the > patch trying to guess the number of CPUs to use for the vp8 encoder > (hopefully I did not introduce rebase issues). > > Thanks a lot (again) for all the work, and

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

Hi On Tue, Jun 14, 2016 at 10:46 AM, Christophe Fergeau wrote: >> Imho, the fix should be on server or guest/driver side, it shouldn't >> use a display monitor config with a scanout offset if there is none to >> be applied by the client. > > Regarding fixing this on the

Re: [Spice-devel] [streaming v16 00/23] Add GStreamer support for video streaming

Great job both of you! Frediano > > Hey, > > So I've finally pushed all of the spice-server bits save for the > patch trying to guess the number of CPUs to use for the vp8 encoder > (hopefully I did not introduce rebase issues). > > Thanks a lot (again) for all the work, and sorry for the

Re: [Spice-devel] [streaming v16 00/23] Add GStreamer support for video streaming

Hey, So I've finally pushed all of the spice-server bits save for the patch trying to guess the number of CPUs to use for the vp8 encoder (hopefully I did not introduce rebase issues). Thanks a lot (again) for all the work, and sorry for the time it took to get this in :( Christophe On Tue,

Re: [Spice-devel] [PATCH v4 09/19] Make some function static

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:33 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 4 ++-- >  server/dcc-encoders.h | 2 -- >  2 files changed, 2 insertions(+), 4 deletions(-) > > diff

Re: [Spice-devel] [PATCH 2/2] Rename image_encoders_free_glz_drawable()

On Tue, 2016-06-14 at 10:14 -0500, Jonathon Jongsma wrote: > Rename this function to red_glz_drawable_free() and remove the > ImageEncoders argument since the RedGlzDrawable already holds a pointer > to the ImageEncoders structure > --- >  server/dcc-encoders.c | 17 + >  1 file

[Spice-devel] [PATCH 2/2] Rename image_encoders_free_glz_drawable()

Rename this function to red_glz_drawable_free() and remove the ImageEncoders argument since the RedGlzDrawable already holds a pointer to the ImageEncoders structure --- server/dcc-encoders.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[Spice-devel] [PATCH 1/2] Rename image_encoders_free_glz_drawable_instance()

Rename this function to glz_drawable_instance_item_free() and remove the ImageEncoders argument since the RedGlzDrawable already holds a pointer to the ImageEncoders structure. --- server/dcc-encoders.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git

[Spice-devel] [PATCH 0/2] RFC: cleanup glz drawable stuff

These patches should apply on top of Frediano's "Better encapsulation of image encoding stuff" patch series. Jonathon Jongsma (2): Rename image_encoders_free_glz_drawable_instance() Rename image_encoders_free_glz_drawable() server/dcc-encoders.c | 32 +++- 1 file

Re: [Spice-devel] [PATCH v4 07/19] Encapsulate some data in dcc-encoders

On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 60 ++- > - >  server/dcc-encoders.h| 33 ++ >  server/display-channel.c | 13

Re: [Spice-devel] [PATCH] Remove a warning compiling under Windows

Acked-by: Jonathon Jongsma On Mon, 2016-06-13 at 12:31 +0100, Frediano Ziglio wrote: > On Windows long is always 32 bit so under x64 the cast from pointer to > "unsigned long" cause a warning. > > Signed-off-by: Frediano Ziglio > --- >  common/quic.c |

Re: [Spice-devel] [PATCH v4 03/19] Change dcc_encoders_init to take ImageEncoders instead of DisplayChannelClient

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c | 4 +--- >  server/dcc-encoders.h | 2 +- >  server/dcc.c  | 2 +- >  3 files changed, 3

Re: [Spice-devel] [PATCH v4 01/19] Add a structure to hold ImageEncoders shared data

Acked-by: Jonathon Jongsma On Tue, 2016-06-14 at 10:32 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- >  server/dcc-encoders.c| 121 +++--- > - >  server/dcc-encoders.h|  33

[Spice-devel] [spice-gtk] main: channel-main to increase file-transfer reference

This is a minor fix in the logic as in both situations (with or without the patch) the reference count for the SpiceFileTransferTask object is the same. The change is interesting as SpiceFileTransferTask is created but on g_file_read_async() it increases its reference count while

Re: [Spice-devel] [spice-gtk] main: assign variable after check for null

On Tue, 2016-06-14 at 14:28 +0200, Victor Toso wrote: Acked-by: Pavel Grunt > --- >  src/channel-main.c | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/channel-main.c b/src/channel-main.c > index 89675d5..e7171c1 100644 > --- a/src/channel-main.c

[Spice-devel] [spice-gtk] main: assign variable after check for null

--- src/channel-main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/channel-main.c b/src/channel-main.c index 89675d5..e7171c1 100644 --- a/src/channel-main.c +++ b/src/channel-main.c @@ -3181,12 +3181,13 @@ void spice_main_file_copy_async(SpiceMainChannel *channel,

[Spice-devel] [PATCH v4 10/19] Encapsulate dcc_release_glz

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 4 +++- server/dcc-encoders.h | 1 - server/dcc.c | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index f423f22..6668dff 100644 ---

[Spice-devel] [PATCH v4 14/19] Use Ring instead of accessing Drawable internals

Remove some coupling, we mainly need to store a list of RedGlzDrawables. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 8 server/dcc-encoders.h| 4 ++-- server/display-channel.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[Spice-devel] [PATCH v4 07/19] Encapsulate some data in dcc-encoders

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 60 ++-- server/dcc-encoders.h| 33 ++ server/display-channel.c | 13 +++ server/display-channel.h | 5 4 files changed, 63

[Spice-devel] [PATCH v4 19/19] Remove message_buf from EncoderData

This buffer was just written and then used, no reason to store into a more persistent structure. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 34 ++ server/dcc-encoders.h | 1 - 2 files changed, 18 insertions(+), 17 deletions(-)

[Spice-devel] [PATCH v4 04/19] Move others glz fields to dcc-encoders

Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/dcc-encoders.c| 76 +--- server/dcc-encoders.h| 19 +++- server/dcc.c | 18 +--- server/dcc.h

[Spice-devel] [PATCH v4 11/19] Better encapsulation for image_encoders_compress_glz call

Do not access too much encoders data. Slightly different as now if glz is frozen lz compression is used. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 15 +++ server/dcc.c | 17 - 2 files changed, 19 insertions(+), 13

[Spice-devel] [PATCH v4 05/19] Make dcc_compress_image_glz independent to DisplayChannelClient

Also rename to image_encoders_compress_glz Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/dcc.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index

[Spice-devel] [PATCH v4 08/19] Encapsulate code to save glz state

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 10 ++ server/dcc-encoders.h | 2 ++ server/dcc-send.c | 8 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 13dbff5..2e5984a

[Spice-devel] [PATCH v4 09/19] Make some function static

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 4 ++-- server/dcc-encoders.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 2e5984a..f423f22 100644 --- a/server/dcc-encoders.c +++

[Spice-devel] [PATCH v4 12/19] Better encoders encapsulation

Avoid to access some fields from dcc.c Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 4 server/dcc.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 3547adc..22cfcf3 100644

[Spice-devel] [PATCH v4 18/19] Reduce header dependency

Avoid dependencies from RedChannel stuff. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/dcc-encoders.h b/server/dcc-encoders.h index 47051b4..75962ad 100644 ---

[Spice-devel] [PATCH v4 06/19] Move image_encoders_compress_glz to dcc-encoders.c

Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/dcc-encoders.c | 133 + server/dcc-encoders.h | 4 ++ server/dcc.c | 147 -- 3

[Spice-devel] [PATCH v4 01/19] Add a structure to hold ImageEncoders shared data

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 121 +++ server/dcc-encoders.h| 33 + server/dcc.c | 26 +- server/display-channel.c | 73 ++--

[Spice-devel] [PATCH v4 13/19] Change RedGlzDrawable::drawable from pointer to boolean

The field was used just as a flag. This has the advantage to make clear to not use the pointer as we don't have ownership. Also many the structure a bit smaller. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 12 +--- 1 file changed, 5 insertions(+), 7

[Spice-devel] [PATCH v4 15/19] Do not access ImageEncoders internal to lock/unlock glz encoding

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c| 14 ++ server/dcc-encoders.h| 2 ++ server/display-channel.c | 18 +- 3 files changed, 21 insertions(+), 13 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c

[Spice-devel] [PATCH v4 17/19] Remove dependency from dcc-encoders to Drawable

Encoding image requires a RedDrawable (where the data is stored) and a Ring where to store information to free Glz structures. Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 17 ++--- server/dcc-encoders.h | 3 ++- server/dcc.c | 4 +++- 3

[Spice-devel] [PATCH v4 16/19] Make GlzSharedDictionary structure private in dcc-encoders.c

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 10 ++ server/dcc-encoders.h | 11 +-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index 7b129e4..4c7d73e 100644 ---

[Spice-devel] [PATCH v4 00/19] Better encapsulation of image encoding stuff

Hi, after the discussion and tests to reduce typedef mess I realized the code lack some proper encapsulation. In DisplayChannel there are multiple files to handle different stuff but all code needs to know all structures and basically include all stuff. Looking at code one stuff that

[Spice-devel] [PATCH v4 03/19] Change dcc_encoders_init to take ImageEncoders instead of DisplayChannelClient

Signed-off-by: Frediano Ziglio --- server/dcc-encoders.c | 4 +--- server/dcc-encoders.h | 2 +- server/dcc.c | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/server/dcc-encoders.c b/server/dcc-encoders.c index c03409c..7497029 100644 ---

[Spice-devel] [PATCH v4 02/19] Move some glz fields to ImageEncoders

Signed-off-by: Frediano Ziglio Acked-by: Jonathon Jongsma --- server/dcc-encoders.c| 95 +++- server/dcc-encoders.h| 20 +++--- server/dcc-send.c| 10 ++--- server/dcc.c | 43

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

On Mon, Jun 13, 2016 at 07:09:29PM +0200, Marc-André Lureau wrote: > My understanding is that there is some confusing between monitor > configuration position (the monitor config on main channel), and the > scanout/primary position (the monitor config on display channel). > > Imho, the fix should

Re: [Spice-devel] [spice-gtk] widget: Disable IME context on main widget

Hey, On Mon, Jun 13, 2016 at 06:07:53AM -0400, Frediano Ziglio wrote: > > > > On Fri, Jun 10, 2016 at 08:45:56AM -0400, Frediano Ziglio wrote: > > > > > > This seems quite strong! I think this will remove the IME context > > > even from the Windows desktop :) > > > > Oh? I just assumed that

Re: [Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config offset

Hey, On Mon, Jun 13, 2016 at 07:09:29PM +0200, Marc-André Lureau wrote: > >> On Thu, Jun 18, 2015 at 07:14:13PM -0400, sstut...@redhat.com wrote: > >> > From: Sandy Stutsman > >> > > >> > Each monitor on a Windows guest is represented as a separate, > >> > single-headed >

Re: [Spice-devel] [PATCH v7 server] LZ4 compression is now available at the Spicevmc channel

> > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes - exists > only if data was compressed) followed by the compressed data > > If SPICE_USBREDIR_CAP_DATA_COMPRESS_LZ4 capability is available && > data_size >

Re: [Spice-devel] [PATCH v7 spice-common 3/3] Add LZ4 data compression and use it in spicevmc channel

> > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes-exists > only if data was compressed) followed by the compressed data > > Update the required protocol to 0.12.12: > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH v7 spice-protocol] LZ4 compression is now available at the Spicevmc channel

> > -New message type for compressed messages has been added to the protocol > > Compressed message type is CompressedData which contains compression > type (1 byte) followed by the uncompressed data size (4 bytes -exists > only if data was compressed) followed by the compressed data > >